Revision - 7ff5ef2 - fix(language-service): [ivy] do not retrieve ts.Program at [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

19 April 2024, 08:24:33 UTC

Revision 7ff5ef27c7159fb1aa5ce4cad54aa83a7d6eba31 authored by Keen Yee Liau on 17 July 2020, 18:15:29 UTC, committed by Alex Rickabaugh on 30 July 2020, 23:54:20 UTC

fix(language-service): [ivy] do not retrieve ts.Program at startup (#38120)

This commit removes compiler instantiation at startup.
This is because the constructor is invoked during the plugin loading phase,
in which the project has not been completely loaded.

Retrieving `ts.Program` at startup will trigger an `updateGraph` operation,
which could only be called after the Project has loaded completely.
Without this change, the Ivy LS cannot be loaded as a tsserver plugin.

Note that the whole `Compiler` class is temporary, so changes made there are
only for development. Once we have proper integration with ngtsc the
`Compiler` class would be removed.

PR Close #38120

1 parent 03d8e31

Files
Changes

Permalinks

Tip revision: 7ff5ef27c7159fb1aa5ce4cad54aa83a7d6eba31 authored by Keen Yee Liau on 17 July 2020, 18:15:29 UTC
fix(language-service): [ivy] do not retrieve ts.Program at startup (#38120)

Tip revision: 7ff5ef2

File	Mode	Size
.circleci
.devcontainer
.github
.ng-dev
.vscode
.yarn
aio
dev-infra
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	4.3 KB
.bazelrc	-rw-r--r--	6.5 KB
.bazelversion	-rw-r--r--	213 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	314 bytes
.gitignore	-rw-r--r--	726 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.nvmrc	-rw-r--r--	8 bytes
.pullapprove.yml	-rw-r--r--	44.1 KB
.yarnrc	-rw-r--r--	128 bytes
BUILD.bazel	-rw-r--r--	1.7 KB
CHANGELOG.md	-rw-r--r--	719.3 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	14.2 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	1.2 KB
WORKSPACE	-rw-r--r--	4.3 KB
browser-providers.conf.js	-rw-r--r--	8.9 KB
gulpfile.js	-rw-r--r--	1.2 KB
karma-js.conf.js	-rw-r--r--	7.6 KB
package.json	-rw-r--r--	8.2 KB
test-events.js	-rw-r--r--	259 bytes
test-main.js	-rw-r--r--	11.3 KB
tslint.json	-rw-r--r--	2.3 KB
yarn.lock	-rw-r--r--	674.8 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(language-service): [ivy] do not retrieve ts.Program at startup (#38120)

README.md