Revision 81fcb698e03543d35c93ec6726a830aa6b9c5167 authored by Mathias Rav on 18 January 2018, 13:38:41 UTC, committed by Junio C Hamano on 19 January 2018, 22:16:56 UTC
Running git clone --single-branch --mirror -b TAGNAME previously
triggered the following error message:
fatal: multiple updates for ref 'refs/tags/TAGNAME' not allowed.
This error condition is handled in files_initial_transaction_commit().
42c7f7ff9 ("commit_packed_refs(): remove call to `packed_refs_unlock()`", 2017-06-23)
introduced incorrect unlocking in the error path of this function,
which changes the error message to
fatal: BUG: packed_refs_unlock() called when not locked
Move the call to packed_refs_unlock() above the "cleanup:" label
since the unlocking should only be done in the last error path.
Signed-off-by: Mathias Rav <m@git.strova.dk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 3013dff
| File | Mode | Size |
|---|---|---|
| files-backend.c | -rw-r--r-- | 83.1 KB |
| iterator.c | -rw-r--r-- | 10.5 KB |
| packed-backend.c | -rw-r--r-- | 43.9 KB |
| packed-backend.h | -rw-r--r-- | 1.2 KB |
| ref-cache.c | -rw-r--r-- | 14.1 KB |
| ref-cache.h | -rw-r--r-- | 8.8 KB |
| refs-internal.h | -rw-r--r-- | 24.4 KB |
Computing file changes ...
