Revision - 8344a3d - writeback: account the number of pages written back - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

17 August 2024, 15:42:30 UTC

Revision 8344a3d44be3d18671e18c4ba23bb03dd21e14ad authored by Matthew Wilcox (Oracle) on 28 June 2023, 18:55:48 UTC, committed by Andrew Morton on 08 July 2023, 16:29:30 UTC

writeback: account the number of pages written back

nr_to_write is a count of pages, so we need to decrease it by the number
of pages in the folio we just wrote, not by 1.  Most callers specify
either LONG_MAX or 1, so are unaffected, but writeback_sb_inodes() might
end up writing 512x as many pages as it asked for.

Dave added:

: XFS is the only filesystem this would affect, right?  AFAIA, nothing
: else enables large folios and uses writeback through
: write_cache_pages() at this point...
: 
: In which case, I'd be surprised if much difference, if any, gets
: noticed by anyone.

Link: https://lkml.kernel.org/r/20230628185548.981888-1-willy@infradead.org
Fixes: 793917d997df ("mm/readahead: Add large folio readahead")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>
Cc: Dave Chinner <david@fromorbit.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

1 parent 6dca4ac

Files
Changes

Permalinks

Tip revision: 8344a3d44be3d18671e18c4ba23bb03dd21e14ad authored by Matthew Wilcox (Oracle) on 28 June 2023, 18:55:48 UTC
writeback: account the number of pages written back

Tip revision: 8344a3d

File	Mode	Size
Documentation
LICENSES
arch
block
certs
crypto
drivers
fs
include
init
io_uring
ipc
kernel
lib
mm
net
rust
samples
scripts
security
sound
tools
usr
virt
.clang-format	-rw-r--r--	20.1 KB
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	151 bytes
.gitattributes	-rw-r--r--	105 bytes
.gitignore	-rw-r--r--	2.0 KB
.mailmap	-rw-r--r--	28.2 KB
.rustfmt.toml	-rw-r--r--	369 bytes
COPYING	-rw-r--r--	496 bytes
CREDITS	-rw-r--r--	100.3 KB
Kbuild	-rw-r--r--	2.5 KB
Kconfig	-rw-r--r--	555 bytes
MAINTAINERS	-rw-r--r--	699.7 KB
Makefile	-rw-r--r--	69.9 KB
README	-rw-r--r--	727 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

writeback: account the number of pages written back

README