Skip to main content

Browse the archive

https://github.com/JuliaLang/julia
19 April 2024, 06:28:37 UTC
Revision 83b02319a777f0495782b7f7590424e71586246f authored by Matt Bauman on 16 March 2018, 17:54:04 UTC, committed by GitHub on 16 March 2018, 17:54:04 UTC 
Remove kludgy VectorStyle and MatrixStyle (#26430)
 
* Remove kludgy VectorStyle and MatrixStyle

These broadcast styles were introduced in response to https://github.com/JuliaLang/julia/pull/23939#discussion_r147042741 as a way to limit the "greediness" of Sparse's broadcasting implementation -- sparse only wanted to allow known combinations of array types (including Array but not any AbstractArray). The idea was to allow us to gradually improve the sparse broadcast implementation over 1.x in a non-breaking manner.  Unfortunately, these special styles for Array make defining new styles in the heirarchy a bit of a pain (ref. https://github.com/JuliaLang/julia/pull/23939#discussion_r155953830), and it was making my life harder in getting the 1.0 breaking changes in.

This commit removes these special broadcast styles in favor of just having Sparse identify the cases itself and re-dispatch back into the default implementation in the cases it doesn't know how to handle.

* Add a graceful deprecation
1 parent 569981a
History
Tip revision: 83b02319a777f0495782b7f7590424e71586246f authored by Matt Bauman on 16 March 2018, 17:54:04 UTC
Remove kludgy VectorStyle and MatrixStyle (#26430)
Tip revision: 83b0231
File Mode Size
.circleci
.github
base
contrib
deps
doc
etc
src
stdlib
test
ui
.freebsdci.sh -rwxr-xr-x 1.0 KB
.gitattributes -rw-r--r-- 67 bytes
.gitignore -rw-r--r-- 213 bytes
.mailmap -rw-r--r-- 9.5 KB
.travis.yml -rw-r--r-- 6.5 KB
CONTRIBUTING.md -rw-r--r-- 20.4 KB
DISTRIBUTING.md -rw-r--r-- 23.6 KB
HISTORY.md -rw-r--r-- 144.9 KB
LICENSE.md -rw-r--r-- 5.4 KB
Make.inc -rw-r--r-- 35.3 KB
Makefile -rw-r--r-- 25.5 KB
NEWS.md -rw-r--r-- 74.4 KB
README.arm.md -rw-r--r-- 5.7 KB
README.md -rw-r--r-- 29.5 KB
README.windows.md -rw-r--r-- 13.0 KB
VERSION -rw-r--r-- 10 bytes
Windows.inc -rw-r--r-- 1.5 KB
appveyor.yml -rw-r--r-- 2.2 KB

README.md

back to top