Revision 84811412464d66fcf73661a279aa1d7985166495 authored by Prashant Malani on 20 November 2019, 19:40:21 UTC, committed by David S. Miller on 20 November 2019, 20:48:13 UTC
Both rtl_work_func_t() and rtl8152_close() call napi_disable(). Since the two calls aren't protected by a lock, if the close function starts executing before the work function, we can get into a situation where the napi_disable() function is called twice in succession (first by rtl8152_close(), then by set_carrier()). In such a situation, the second call would loop indefinitely, since rtl8152_close() doesn't call napi_enable() to clear the NAPI_STATE_SCHED bit. The rtl8152_close() function in turn issues a cancel_delayed_work_sync(), and so it would wait indefinitely for the rtl_work_func_t() to complete. Since rtl8152_close() is called by a process holding rtnl_lock() which is requested by other processes, this eventually leads to a system deadlock and crash. Re-order the napi_disable() call to occur after the work function disabling and urb cancellation calls are issued. Change-Id: I6ef0b703fc214998a037a68f722f784e1d07815e Reported-by: http://crbug.com/1017928 Signed-off-by: Prashant Malani <pmalani@chromium.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b172845
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.4 KB |
Makefile | -rw-r--r-- | 356 bytes |
acl.c | -rw-r--r-- | 5.6 KB |
addr.c | -rw-r--r-- | 53.4 KB |
cache.c | -rw-r--r-- | 8.6 KB |
cache.h | -rw-r--r-- | 4.1 KB |
caps.c | -rw-r--r-- | 114.6 KB |
ceph_frag.c | -rw-r--r-- | 401 bytes |
debugfs.c | -rw-r--r-- | 7.5 KB |
dir.c | -rw-r--r-- | 47.9 KB |
export.c | -rw-r--r-- | 12.9 KB |
file.c | -rw-r--r-- | 55.9 KB |
inode.c | -rw-r--r-- | 65.2 KB |
io.c | -rw-r--r-- | 4.5 KB |
io.h | -rw-r--r-- | 387 bytes |
ioctl.c | -rw-r--r-- | 7.4 KB |
ioctl.h | -rw-r--r-- | 3.6 KB |
locks.c | -rw-r--r-- | 12.3 KB |
mds_client.c | -rw-r--r-- | 123.4 KB |
mds_client.h | -rw-r--r-- | 15.9 KB |
mdsmap.c | -rw-r--r-- | 9.3 KB |
quota.c | -rw-r--r-- | 14.0 KB |
snap.c | -rw-r--r-- | 31.7 KB |
strings.c | -rw-r--r-- | 4.2 KB |
super.c | -rw-r--r-- | 29.8 KB |
super.h | -rw-r--r-- | 36.2 KB |
xattr.c | -rw-r--r-- | 32.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...