Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 May 2024, 11:00:25 UTC
Revision 851e99ebeec3f4a672bb5010cf1ece095acee447 authored by Steven Rostedt (Google) on 25 February 2022, 20:34:26 UTC, committed by Steven Rostedt (Google) on 26 February 2022, 02:05:04 UTC 
tracefs: Set the group ownership in apply_options() not parse_options()
 
Al Viro brought it to my attention that the dentries may not be filled
when the parse_options() is called, causing the call to set_gid() to
possibly crash. It should only be called if parse_options() succeeds
totally anyway.

He suggested the logical place to do the update is in apply_options().

Link: https://lore.kernel.org/all/20220225165219.737025658@goodmis.org/
Link: https://lkml.kernel.org/r/20220225153426.1c4cab6b@gandalf.local.home

Cc: stable@vger.kernel.org
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Fixes: 48b27b6b5191 ("tracefs: Set all files to the same group ownership as the mount option")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent dd99035
History
Tip revision: 851e99ebeec3f4a672bb5010cf1ece095acee447 authored by Steven Rostedt (Google) on 25 February 2022, 20:34:26 UTC
tracefs: Set the group ownership in apply_options() not parse_options()
Tip revision: 851e99e
File Mode Size
.gitignore -rw-r--r-- 99 bytes
Kconfig -rw-r--r-- 4.8 KB
Makefile -rw-r--r-- 3.2 KB
blacklist.c -rw-r--r-- 5.7 KB
blacklist.h -rw-r--r-- 135 bytes
blacklist_hashes.c -rw-r--r-- 166 bytes
blacklist_nohashes.c -rw-r--r-- 122 bytes
common.c -rw-r--r-- 1.2 KB
common.h -rw-r--r-- 216 bytes
default_x509.genkey -rw-r--r-- 407 bytes
extract-cert.c -rw-r--r-- 3.5 KB
revocation_certificates.S -rw-r--r-- 495 bytes
system_certificates.S -rw-r--r-- 1.1 KB
system_keyring.c -rw-r--r-- 8.5 KB
back to top