Revision 85bd839983778fcd0c1c043327b14a046e979b39 authored by Gu Zheng on 10 June 2015, 18:14:43 UTC, committed by Linus Torvalds on 10 June 2015, 23:43:43 UTC
Izumi found the following oops when hot re-adding a node: BUG: unable to handle kernel paging request at ffffc90008963690 IP: __wake_up_bit+0x20/0x70 Oops: 0000 [#1] SMP CPU: 68 PID: 1237 Comm: rs:main Q:Reg Not tainted 4.1.0-rc5 #80 Hardware name: FUJITSU PRIMEQUEST2800E/SB, BIOS PRIMEQUEST 2000 Series BIOS Version 1.87 04/28/2015 task: ffff880838df8000 ti: ffff880017b94000 task.ti: ffff880017b94000 RIP: 0010:[<ffffffff810dff80>] [<ffffffff810dff80>] __wake_up_bit+0x20/0x70 RSP: 0018:ffff880017b97be8 EFLAGS: 00010246 RAX: ffffc90008963690 RBX: 00000000003c0000 RCX: 000000000000a4c9 RDX: 0000000000000000 RSI: ffffea101bffd500 RDI: ffffc90008963648 RBP: ffff880017b97c08 R08: 0000000002000020 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffff8a0797c73800 R13: ffffea101bffd500 R14: 0000000000000001 R15: 00000000003c0000 FS: 00007fcc7ffff700(0000) GS:ffff880874800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffc90008963690 CR3: 0000000836761000 CR4: 00000000001407e0 Call Trace: unlock_page+0x6d/0x70 generic_write_end+0x53/0xb0 xfs_vm_write_end+0x29/0x80 [xfs] generic_perform_write+0x10a/0x1e0 xfs_file_buffered_aio_write+0x14d/0x3e0 [xfs] xfs_file_write_iter+0x79/0x120 [xfs] __vfs_write+0xd4/0x110 vfs_write+0xac/0x1c0 SyS_write+0x58/0xd0 system_call_fastpath+0x12/0x76 Code: 5d c3 66 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 48 89 e5 48 83 ec 20 65 48 8b 04 25 28 00 00 00 48 89 45 f8 31 c0 48 8d 47 48 <48> 39 47 48 48 c7 45 e8 00 00 00 00 48 c7 45 f0 00 00 00 00 48 RIP [<ffffffff810dff80>] __wake_up_bit+0x20/0x70 RSP <ffff880017b97be8> CR2: ffffc90008963690 Reproduce method (re-add a node):: Hot-add nodeA --> remove nodeA --> hot-add nodeA (panic) This seems an use-after-free problem, and the root cause is zone->wait_table was not set to *NULL* after free it in try_offline_node. When hot re-add a node, we will reuse the pgdat of it, so does the zone struct, and when add pages to the target zone, it will init the zone first (including the wait_table) if the zone is not initialized. The judgement of zone initialized is based on zone->wait_table: static inline bool zone_is_initialized(struct zone *zone) { return !!zone->wait_table; } so if we do not set the zone->wait_table to *NULL* after free it, the memory hotplug routine will skip the init of new zone when hot re-add the node, and the wait_table still points to the freed memory, then we will access the invalid address when trying to wake up the waiting people after the i/o operation with the page is done, such as mentioned above. Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com> Reported-by: Taku Izumi <izumi.taku@jp.fujitsu.com> Reviewed by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Tang Chen <tangchen@cn.fujitsu.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 5879ae5
File | Mode | Size |
---|---|---|
i2c-hid | ||
usbhid | ||
Kconfig | -rw-r--r-- | 26.3 KB |
Makefile | -rw-r--r-- | 4.3 KB |
hid-a4tech.c | -rw-r--r-- | 3.3 KB |
hid-apple.c | -rw-r--r-- | 20.2 KB |
hid-appleir.c | -rw-r--r-- | 9.5 KB |
hid-aureal.c | -rw-r--r-- | 1.2 KB |
hid-axff.c | -rw-r--r-- | 4.8 KB |
hid-belkin.c | -rw-r--r-- | 2.3 KB |
hid-betopff.c | -rw-r--r-- | 3.9 KB |
hid-cherry.c | -rw-r--r-- | 2.0 KB |
hid-chicony.c | -rw-r--r-- | 2.4 KB |
hid-core.c | -rw-r--r-- | 93.4 KB |
hid-cp2112.c | -rw-r--r-- | 29.2 KB |
hid-cypress.c | -rw-r--r-- | 3.8 KB |
hid-debug.c | -rw-r--r-- | 41.3 KB |
hid-dr.c | -rw-r--r-- | 9.0 KB |
hid-elecom.c | -rw-r--r-- | 1.2 KB |
hid-elo.c | -rw-r--r-- | 7.3 KB |
hid-emsff.c | -rw-r--r-- | 3.8 KB |
hid-ezkey.c | -rw-r--r-- | 2.2 KB |
hid-gaff.c | -rw-r--r-- | 4.5 KB |
hid-generic.c | -rw-r--r-- | 1.1 KB |
hid-gt683r.c | -rw-r--r-- | 6.8 KB |
hid-gyration.c | -rw-r--r-- | 2.8 KB |
hid-holtek-kbd.c | -rw-r--r-- | 8.0 KB |
hid-holtek-mouse.c | -rw-r--r-- | 3.1 KB |
hid-holtekff.c | -rw-r--r-- | 6.0 KB |
hid-hyperv.c | -rw-r--r-- | 13.4 KB |
hid-icade.c | -rw-r--r-- | 5.9 KB |
hid-ids.h | -rw-r--r-- | 37.4 KB |
hid-input.c | -rw-r--r-- | 46.1 KB |
hid-kensington.c | -rw-r--r-- | 1.3 KB |
hid-keytouch.c | -rw-r--r-- | 1.6 KB |
hid-kye.c | -rw-r--r-- | 28.7 KB |
hid-lcpower.c | -rw-r--r-- | 1.7 KB |
hid-lenovo.c | -rw-r--r-- | 21.1 KB |
hid-lg.c | -rw-r--r-- | 34.7 KB |
hid-lg.h | -rw-r--r-- | 602 bytes |
hid-lg2ff.c | -rw-r--r-- | 2.7 KB |
hid-lg3ff.c | -rw-r--r-- | 4.4 KB |
hid-lg4ff.c | -rw-r--r-- | 34.0 KB |
hid-lg4ff.h | -rw-r--r-- | 708 bytes |
hid-lgff.c | -rw-r--r-- | 4.5 KB |
hid-logitech-dj.c | -rw-r--r-- | 36.7 KB |
hid-logitech-hidpp.c | -rw-r--r-- | 33.3 KB |
hid-magicmouse.c | -rw-r--r-- | 16.8 KB |
hid-microsoft.c | -rw-r--r-- | 8.3 KB |
hid-monterey.c | -rw-r--r-- | 1.9 KB |
hid-multitouch.c | -rw-r--r-- | 39.8 KB |
hid-ntrig.c | -rw-r--r-- | 27.0 KB |
hid-ortek.c | -rw-r--r-- | 1.7 KB |
hid-penmount.c | -rw-r--r-- | 1.4 KB |
hid-petalynx.c | -rw-r--r-- | 2.7 KB |
hid-picolcd.h | -rw-r--r-- | 9.7 KB |
hid-picolcd_backlight.c | -rw-r--r-- | 4.1 KB |
hid-picolcd_cir.c | -rw-r--r-- | 4.7 KB |
hid-picolcd_core.c | -rw-r--r-- | 19.0 KB |
hid-picolcd_debugfs.c | -rw-r--r-- | 27.1 KB |
hid-picolcd_fb.c | -rw-r--r-- | 17.2 KB |
hid-picolcd_lcd.c | -rw-r--r-- | 3.5 KB |
hid-picolcd_leds.c | -rw-r--r-- | 4.8 KB |
hid-pl.c | -rw-r--r-- | 6.1 KB |
hid-plantronics.c | -rw-r--r-- | 1.5 KB |
hid-primax.c | -rw-r--r-- | 2.2 KB |
hid-prodikeys.c | -rw-r--r-- | 20.6 KB |
hid-rmi.c | -rw-r--r-- | 31.4 KB |
hid-roccat-arvo.c | -rw-r--r-- | 11.3 KB |
hid-roccat-arvo.h | -rw-r--r-- | 1.8 KB |
hid-roccat-common.c | -rw-r--r-- | 4.7 KB |
hid-roccat-common.h | -rw-r--r-- | 3.1 KB |
hid-roccat-isku.c | -rw-r--r-- | 11.3 KB |
hid-roccat-isku.h | -rw-r--r-- | 2.2 KB |
hid-roccat-kone.c | -rw-r--r-- | 23.7 KB |
hid-roccat-kone.h | -rw-r--r-- | 6.8 KB |
hid-roccat-koneplus.c | -rw-r--r-- | 15.7 KB |
hid-roccat-koneplus.h | -rw-r--r-- | 3.2 KB |
hid-roccat-konepure.c | -rw-r--r-- | 5.5 KB |
hid-roccat-kovaplus.c | -rw-r--r-- | 18.4 KB |
hid-roccat-kovaplus.h | -rw-r--r-- | 3.8 KB |
hid-roccat-lua.c | -rw-r--r-- | 5.1 KB |
hid-roccat-lua.h | -rw-r--r-- | 558 bytes |
hid-roccat-pyra.c | -rw-r--r-- | 16.5 KB |
hid-roccat-pyra.h | -rw-r--r-- | 3.7 KB |
hid-roccat-ryos.c | -rw-r--r-- | 5.8 KB |
hid-roccat-savu.c | -rw-r--r-- | 5.2 KB |
hid-roccat-savu.h | -rw-r--r-- | 1.3 KB |
hid-roccat.c | -rw-r--r-- | 10.6 KB |
hid-saitek.c | -rw-r--r-- | 5.0 KB |
hid-samsung.c | -rw-r--r-- | 6.0 KB |
hid-sensor-custom.c | -rw-r--r-- | 23.9 KB |
hid-sensor-hub.c | -rw-r--r-- | 22.7 KB |
hid-sjoy.c | -rw-r--r-- | 4.9 KB |
hid-sony.c | -rw-r--r-- | 77.2 KB |
hid-speedlink.c | -rw-r--r-- | 2.3 KB |
hid-steelseries.c | -rw-r--r-- | 12.4 KB |
hid-sunplus.c | -rw-r--r-- | 1.9 KB |
hid-thingm.c | -rw-r--r-- | 7.0 KB |
hid-tivo.c | -rw-r--r-- | 2.3 KB |
hid-tmff.c | -rw-r--r-- | 7.0 KB |
hid-topseed.c | -rw-r--r-- | 2.6 KB |
hid-twinhan.c | -rw-r--r-- | 4.7 KB |
hid-uclogic.c | -rw-r--r-- | 42.7 KB |
hid-waltop.c | -rw-r--r-- | 39.9 KB |
hid-wiimote-core.c | -rw-r--r-- | 48.2 KB |
hid-wiimote-debug.c | -rw-r--r-- | 4.9 KB |
hid-wiimote-modules.c | -rw-r--r-- | 63.6 KB |
hid-wiimote.h | -rw-r--r-- | 9.3 KB |
hid-xinmo.c | -rw-r--r-- | 1.5 KB |
hid-zpff.c | -rw-r--r-- | 3.6 KB |
hid-zydacron.c | -rw-r--r-- | 4.1 KB |
hidraw.c | -rw-r--r-- | 13.9 KB |
uhid.c | -rw-r--r-- | 17.2 KB |
wacom.h | -rw-r--r-- | 5.9 KB |
wacom_sys.c | -rw-r--r-- | 42.4 KB |
wacom_wac.c | -rw-r--r-- | 106.2 KB |
wacom_wac.h | -rw-r--r-- | 4.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...