Revision 85bd839983778fcd0c1c043327b14a046e979b39 authored by Gu Zheng on 10 June 2015, 18:14:43 UTC, committed by Linus Torvalds on 10 June 2015, 23:43:43 UTC
Izumi found the following oops when hot re-adding a node: BUG: unable to handle kernel paging request at ffffc90008963690 IP: __wake_up_bit+0x20/0x70 Oops: 0000 [#1] SMP CPU: 68 PID: 1237 Comm: rs:main Q:Reg Not tainted 4.1.0-rc5 #80 Hardware name: FUJITSU PRIMEQUEST2800E/SB, BIOS PRIMEQUEST 2000 Series BIOS Version 1.87 04/28/2015 task: ffff880838df8000 ti: ffff880017b94000 task.ti: ffff880017b94000 RIP: 0010:[<ffffffff810dff80>] [<ffffffff810dff80>] __wake_up_bit+0x20/0x70 RSP: 0018:ffff880017b97be8 EFLAGS: 00010246 RAX: ffffc90008963690 RBX: 00000000003c0000 RCX: 000000000000a4c9 RDX: 0000000000000000 RSI: ffffea101bffd500 RDI: ffffc90008963648 RBP: ffff880017b97c08 R08: 0000000002000020 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffff8a0797c73800 R13: ffffea101bffd500 R14: 0000000000000001 R15: 00000000003c0000 FS: 00007fcc7ffff700(0000) GS:ffff880874800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffc90008963690 CR3: 0000000836761000 CR4: 00000000001407e0 Call Trace: unlock_page+0x6d/0x70 generic_write_end+0x53/0xb0 xfs_vm_write_end+0x29/0x80 [xfs] generic_perform_write+0x10a/0x1e0 xfs_file_buffered_aio_write+0x14d/0x3e0 [xfs] xfs_file_write_iter+0x79/0x120 [xfs] __vfs_write+0xd4/0x110 vfs_write+0xac/0x1c0 SyS_write+0x58/0xd0 system_call_fastpath+0x12/0x76 Code: 5d c3 66 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 48 89 e5 48 83 ec 20 65 48 8b 04 25 28 00 00 00 48 89 45 f8 31 c0 48 8d 47 48 <48> 39 47 48 48 c7 45 e8 00 00 00 00 48 c7 45 f0 00 00 00 00 48 RIP [<ffffffff810dff80>] __wake_up_bit+0x20/0x70 RSP <ffff880017b97be8> CR2: ffffc90008963690 Reproduce method (re-add a node):: Hot-add nodeA --> remove nodeA --> hot-add nodeA (panic) This seems an use-after-free problem, and the root cause is zone->wait_table was not set to *NULL* after free it in try_offline_node. When hot re-add a node, we will reuse the pgdat of it, so does the zone struct, and when add pages to the target zone, it will init the zone first (including the wait_table) if the zone is not initialized. The judgement of zone initialized is based on zone->wait_table: static inline bool zone_is_initialized(struct zone *zone) { return !!zone->wait_table; } so if we do not set the zone->wait_table to *NULL* after free it, the memory hotplug routine will skip the init of new zone when hot re-add the node, and the wait_table still points to the freed memory, then we will access the invalid address when trying to wake up the waiting people after the i/o operation with the page is done, such as mentioned above. Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com> Reported-by: Taku Izumi <izumi.taku@jp.fujitsu.com> Reviewed by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Tang Chen <tangchen@cn.fujitsu.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 5879ae5
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 28.5 KB |
Makefile | -rw-r--r-- | 3.8 KB |
aec62xx.c | -rw-r--r-- | 9.2 KB |
ali14xx.c | -rw-r--r-- | 6.5 KB |
alim15x3.c | -rw-r--r-- | 14.9 KB |
amd74xx.c | -rw-r--r-- | 10.0 KB |
atiixp.c | -rw-r--r-- | 5.6 KB |
au1xxx-ide.c | -rw-r--r-- | 15.0 KB |
buddha.c | -rw-r--r-- | 5.6 KB |
cmd640.c | -rw-r--r-- | 22.4 KB |
cmd64x.c | -rw-r--r-- | 12.0 KB |
cs5520.c | -rw-r--r-- | 4.7 KB |
cs5530.c | -rw-r--r-- | 8.1 KB |
cs5535.c | -rw-r--r-- | 6.2 KB |
cs5536.c | -rw-r--r-- | 7.6 KB |
cy82c693.c | -rw-r--r-- | 6.3 KB |
delkin_cb.c | -rw-r--r-- | 4.4 KB |
dtc2278.c | -rw-r--r-- | 3.8 KB |
falconide.c | -rw-r--r-- | 3.9 KB |
gayle.c | -rw-r--r-- | 4.4 KB |
hpt366.c | -rw-r--r-- | 41.9 KB |
ht6560b.c | -rw-r--r-- | 10.4 KB |
icside.c | -rw-r--r-- | 16.2 KB |
ide-4drives.c | -rw-r--r-- | 1.5 KB |
ide-acpi.c | -rw-r--r-- | 16.5 KB |
ide-atapi.c | -rw-r--r-- | 17.7 KB |
ide-cd.c | -rw-r--r-- | 45.9 KB |
ide-cd.h | -rw-r--r-- | 3.5 KB |
ide-cd_ioctl.c | -rw-r--r-- | 11.5 KB |
ide-cd_verbose.c | -rw-r--r-- | 13.6 KB |
ide-cs.c | -rw-r--r-- | 12.0 KB |
ide-devsets.c | -rw-r--r-- | 3.8 KB |
ide-disk.c | -rw-r--r-- | 19.3 KB |
ide-disk.h | -rw-r--r-- | 666 bytes |
ide-disk_ioctl.c | -rw-r--r-- | 957 bytes |
ide-disk_proc.c | -rw-r--r-- | 4.6 KB |
ide-dma-sff.c | -rw-r--r-- | 8.9 KB |
ide-dma.c | -rw-r--r-- | 13.2 KB |
ide-eh.c | -rw-r--r-- | 12.1 KB |
ide-floppy.c | -rw-r--r-- | 14.4 KB |
ide-floppy.h | -rw-r--r-- | 1.1 KB |
ide-floppy_ioctl.c | -rw-r--r-- | 7.2 KB |
ide-floppy_proc.c | -rw-r--r-- | 1.2 KB |
ide-gd.c | -rw-r--r-- | 10.8 KB |
ide-gd.h | -rw-r--r-- | 932 bytes |
ide-generic.c | -rw-r--r-- | 3.9 KB |
ide-io-std.c | -rw-r--r-- | 6.4 KB |
ide-io.c | -rw-r--r-- | 23.6 KB |
ide-ioctls.c | -rw-r--r-- | 6.7 KB |
ide-iops.c | -rw-r--r-- | 13.5 KB |
ide-legacy.c | -rw-r--r-- | 1.3 KB |
ide-lib.c | -rw-r--r-- | 4.4 KB |
ide-park.c | -rw-r--r-- | 3.5 KB |
ide-pci-generic.c | -rw-r--r-- | 6.0 KB |
ide-pio-blacklist.c | -rw-r--r-- | 2.3 KB |
ide-pm.c | -rw-r--r-- | 6.5 KB |
ide-pnp.c | -rw-r--r-- | 2.5 KB |
ide-probe.c | -rw-r--r-- | 37.5 KB |
ide-proc.c | -rw-r--r-- | 19.3 KB |
ide-scan-pci.c | -rw-r--r-- | 2.7 KB |
ide-sysfs.c | -rw-r--r-- | 3.2 KB |
ide-tape.c | -rw-r--r-- | 55.1 KB |
ide-taskfile.c | -rw-r--r-- | 16.6 KB |
ide-timings.c | -rw-r--r-- | 6.5 KB |
ide-xfer-mode.c | -rw-r--r-- | 6.7 KB |
ide.c | -rw-r--r-- | 10.4 KB |
ide_platform.c | -rw-r--r-- | 3.2 KB |
it8172.c | -rw-r--r-- | 5.1 KB |
it8213.c | -rw-r--r-- | 5.5 KB |
it821x.c | -rw-r--r-- | 20.4 KB |
jmicron.c | -rw-r--r-- | 4.5 KB |
macide.c | -rw-r--r-- | 3.0 KB |
ns87415.c | -rw-r--r-- | 8.9 KB |
opti621.c | -rw-r--r-- | 4.5 KB |
palm_bk3710.c | -rw-r--r-- | 10.6 KB |
pdc202xx_new.c | -rw-r--r-- | 14.5 KB |
pdc202xx_old.c | -rw-r--r-- | 10.1 KB |
piix.c | -rw-r--r-- | 14.0 KB |
pmac.c | -rw-r--r-- | 45.4 KB |
q40ide.c | -rw-r--r-- | 4.1 KB |
qd65xx.c | -rw-r--r-- | 10.9 KB |
qd65xx.h | -rw-r--r-- | 5.8 KB |
rapide.c | -rw-r--r-- | 2.0 KB |
rz1000.c | -rw-r--r-- | 2.3 KB |
sc1200.c | -rw-r--r-- | 9.2 KB |
serverworks.c | -rw-r--r-- | 12.6 KB |
setup-pci.c | -rw-r--r-- | 16.6 KB |
sgiioc4.c | -rw-r--r-- | 16.8 KB |
siimage.c | -rw-r--r-- | 20.9 KB |
sis5513.c | -rw-r--r-- | 18.1 KB |
sl82c105.c | -rw-r--r-- | 9.4 KB |
slc90e66.c | -rw-r--r-- | 4.8 KB |
tc86c001.c | -rw-r--r-- | 7.5 KB |
triflex.c | -rw-r--r-- | 3.8 KB |
trm290.c | -rw-r--r-- | 10.8 KB |
tx4938ide.c | -rw-r--r-- | 5.5 KB |
tx4939ide.c | -rw-r--r-- | 17.0 KB |
umc8672.c | -rw-r--r-- | 5.0 KB |
via82cxxx.c | -rw-r--r-- | 14.7 KB |
Computing file changes ...