Revision 85bd839983778fcd0c1c043327b14a046e979b39 authored by Gu Zheng on 10 June 2015, 18:14:43 UTC, committed by Linus Torvalds on 10 June 2015, 23:43:43 UTC
Izumi found the following oops when hot re-adding a node: BUG: unable to handle kernel paging request at ffffc90008963690 IP: __wake_up_bit+0x20/0x70 Oops: 0000 [#1] SMP CPU: 68 PID: 1237 Comm: rs:main Q:Reg Not tainted 4.1.0-rc5 #80 Hardware name: FUJITSU PRIMEQUEST2800E/SB, BIOS PRIMEQUEST 2000 Series BIOS Version 1.87 04/28/2015 task: ffff880838df8000 ti: ffff880017b94000 task.ti: ffff880017b94000 RIP: 0010:[<ffffffff810dff80>] [<ffffffff810dff80>] __wake_up_bit+0x20/0x70 RSP: 0018:ffff880017b97be8 EFLAGS: 00010246 RAX: ffffc90008963690 RBX: 00000000003c0000 RCX: 000000000000a4c9 RDX: 0000000000000000 RSI: ffffea101bffd500 RDI: ffffc90008963648 RBP: ffff880017b97c08 R08: 0000000002000020 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffff8a0797c73800 R13: ffffea101bffd500 R14: 0000000000000001 R15: 00000000003c0000 FS: 00007fcc7ffff700(0000) GS:ffff880874800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffc90008963690 CR3: 0000000836761000 CR4: 00000000001407e0 Call Trace: unlock_page+0x6d/0x70 generic_write_end+0x53/0xb0 xfs_vm_write_end+0x29/0x80 [xfs] generic_perform_write+0x10a/0x1e0 xfs_file_buffered_aio_write+0x14d/0x3e0 [xfs] xfs_file_write_iter+0x79/0x120 [xfs] __vfs_write+0xd4/0x110 vfs_write+0xac/0x1c0 SyS_write+0x58/0xd0 system_call_fastpath+0x12/0x76 Code: 5d c3 66 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 48 89 e5 48 83 ec 20 65 48 8b 04 25 28 00 00 00 48 89 45 f8 31 c0 48 8d 47 48 <48> 39 47 48 48 c7 45 e8 00 00 00 00 48 c7 45 f0 00 00 00 00 48 RIP [<ffffffff810dff80>] __wake_up_bit+0x20/0x70 RSP <ffff880017b97be8> CR2: ffffc90008963690 Reproduce method (re-add a node):: Hot-add nodeA --> remove nodeA --> hot-add nodeA (panic) This seems an use-after-free problem, and the root cause is zone->wait_table was not set to *NULL* after free it in try_offline_node. When hot re-add a node, we will reuse the pgdat of it, so does the zone struct, and when add pages to the target zone, it will init the zone first (including the wait_table) if the zone is not initialized. The judgement of zone initialized is based on zone->wait_table: static inline bool zone_is_initialized(struct zone *zone) { return !!zone->wait_table; } so if we do not set the zone->wait_table to *NULL* after free it, the memory hotplug routine will skip the init of new zone when hot re-add the node, and the wait_table still points to the freed memory, then we will access the invalid address when trying to wake up the waiting people after the i/o operation with the page is done, such as mentioned above. Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com> Reported-by: Taku Izumi <izumi.taku@jp.fujitsu.com> Reviewed by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Tang Chen <tangchen@cn.fujitsu.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 5879ae5
File | Mode | Size |
---|---|---|
avs | ||
reset | ||
88pm860x_battery.c | -rw-r--r-- | 25.7 KB |
88pm860x_charger.c | -rw-r--r-- | 18.9 KB |
Kconfig | -rw-r--r-- | 12.6 KB |
Makefile | -rw-r--r-- | 3.1 KB |
ab8500_bmdata.c | -rw-r--r-- | 16.5 KB |
ab8500_btemp.c | -rw-r--r-- | 32.0 KB |
ab8500_charger.c | -rw-r--r-- | 102.1 KB |
ab8500_fg.c | -rw-r--r-- | 83.6 KB |
abx500_chargalg.c | -rw-r--r-- | 60.7 KB |
apm_power.c | -rw-r--r-- | 10.1 KB |
axp288_fuel_gauge.c | -rw-r--r-- | 30.5 KB |
bq2415x_charger.c | -rw-r--r-- | 44.2 KB |
bq24190_charger.c | -rw-r--r-- | 40.4 KB |
bq24735-charger.c | -rw-r--r-- | 10.5 KB |
bq27x00_battery.c | -rw-r--r-- | 27.6 KB |
charger-manager.c | -rw-r--r-- | 54.3 KB |
collie_battery.c | -rw-r--r-- | 10.1 KB |
da9030_battery.c | -rw-r--r-- | 15.9 KB |
da9052-battery.c | -rw-r--r-- | 15.3 KB |
da9150-charger.c | -rw-r--r-- | 17.1 KB |
ds2760_battery.c | -rw-r--r-- | 18.0 KB |
ds2780_battery.c | -rw-r--r-- | 21.2 KB |
ds2781_battery.c | -rw-r--r-- | 20.9 KB |
ds2782_battery.c | -rw-r--r-- | 11.0 KB |
generic-adc-battery.c | -rw-r--r-- | 10.9 KB |
goldfish_battery.c | -rw-r--r-- | 6.2 KB |
gpio-charger.c | -rw-r--r-- | 7.3 KB |
intel_mid_battery.c | -rw-r--r-- | 21.3 KB |
ipaq_micro_battery.c | -rw-r--r-- | 7.9 KB |
isp1704_charger.c | -rw-r--r-- | 13.7 KB |
jz4740-battery.c | -rw-r--r-- | 10.4 KB |
lp8727_charger.c | -rw-r--r-- | 14.2 KB |
lp8788-charger.c | -rw-r--r-- | 18.3 KB |
ltc2941-battery-gauge.c | -rw-r--r-- | 13.8 KB |
max14577_charger.c | -rw-r--r-- | 16.5 KB |
max17040_battery.c | -rw-r--r-- | 7.2 KB |
max17042_battery.c | -rw-r--r-- | 22.8 KB |
max77693_charger.c | -rw-r--r-- | 18.5 KB |
max8903_charger.c | -rw-r--r-- | 9.2 KB |
max8925_power.c | -rw-r--r-- | 15.0 KB |
max8997_charger.c | -rw-r--r-- | 5.3 KB |
max8998_charger.c | -rw-r--r-- | 5.7 KB |
olpc_battery.c | -rw-r--r-- | 16.5 KB |
pcf50633-charger.c | -rw-r--r-- | 12.5 KB |
pda_power.c | -rw-r--r-- | 11.6 KB |
pm2301_charger.c | -rw-r--r-- | 29.8 KB |
pm2301_charger.h | -rw-r--r-- | 13.9 KB |
pmu_battery.c | -rw-r--r-- | 5.6 KB |
power_supply.h | -rw-r--r-- | 1.1 KB |
power_supply_core.c | -rw-r--r-- | 22.5 KB |
power_supply_leds.c | -rw-r--r-- | 4.7 KB |
power_supply_sysfs.c | -rw-r--r-- | 9.1 KB |
rt5033_battery.c | -rw-r--r-- | 4.6 KB |
rx51_battery.c | -rw-r--r-- | 7.9 KB |
s3c_adc_battery.c | -rw-r--r-- | 11.4 KB |
sbs-battery.c | -rw-r--r-- | 24.3 KB |
smb347-charger.c | -rw-r--r-- | 31.9 KB |
test_power.c | -rw-r--r-- | 14.1 KB |
tosa_battery.c | -rw-r--r-- | 11.8 KB |
tps65090-charger.c | -rw-r--r-- | 9.0 KB |
twl4030_charger.c | -rw-r--r-- | 17.8 KB |
twl4030_madc_battery.c | -rw-r--r-- | 7.4 KB |
wm831x_backup.c | -rw-r--r-- | 5.5 KB |
wm831x_power.c | -rw-r--r-- | 17.5 KB |
wm8350_power.c | -rw-r--r-- | 14.9 KB |
wm97xx_battery.c | -rw-r--r-- | 7.2 KB |
z2_battery.c | -rw-r--r-- | 8.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...