Revision 85de7fac3990cf0c0736edc83856add2e648c76a authored by Marek Vasut on 21 November 2012, 05:19:06 UTC, committed by Wolfram Sang on 21 January 2013, 15:26:29 UTC
The init_completion() call does reinit not only the variable carrying the flag that the completion finished, but also initialized the waitqueue associated with the completion. On the contrary, the INIT_COMPLETION() call only reinits the flag. In case there was anything still stuck in the waitqueue, subsequent call to init_completion() would be able to create possible race condition. This patch uses the proper function and moves init_completion() into .probe() call of the driver, to be issued only once. Note that such scenario is impossible, since two threads can never enter the mxs_i2c_xfer_msg(), since whole this section is protected by mutex in I2C core. This by no means allows this issue to exit though. Signed-off-by: Marek Vasut <marex@denx.de> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
1 parent 7d1f9ae
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.4 KB |
| Makefile | -rw-r--r-- | 265 bytes |
| bind.c | -rw-r--r-- | 7.0 KB |
| daemon.c | -rw-r--r-- | 16.5 KB |
| interface.c | -rw-r--r-- | 13.8 KB |
| internal.h | -rw-r--r-- | 10.8 KB |
| key.c | -rw-r--r-- | 3.7 KB |
| main.c | -rw-r--r-- | 2.5 KB |
| namei.c | -rw-r--r-- | 24.6 KB |
| proc.c | -rw-r--r-- | 3.1 KB |
| rdwr.c | -rw-r--r-- | 25.1 KB |
| security.c | -rw-r--r-- | 2.8 KB |
| xattr.c | -rw-r--r-- | 6.4 KB |
Computing file changes ...
