Revision 85de7fac3990cf0c0736edc83856add2e648c76a authored by Marek Vasut on 21 November 2012, 05:19:06 UTC, committed by Wolfram Sang on 21 January 2013, 15:26:29 UTC
The init_completion() call does reinit not only the variable carrying the flag that the completion finished, but also initialized the waitqueue associated with the completion. On the contrary, the INIT_COMPLETION() call only reinits the flag. In case there was anything still stuck in the waitqueue, subsequent call to init_completion() would be able to create possible race condition. This patch uses the proper function and moves init_completion() into .probe() call of the driver, to be issued only once. Note that such scenario is impossible, since two threads can never enter the mxs_i2c_xfer_msg(), since whole this section is protected by mutex in I2C core. This by no means allows this issue to exit though. Signed-off-by: Marek Vasut <marex@denx.de> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
1 parent 7d1f9ae
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 2.5 KB |
| Makefile | -rw-r--r-- | 480 bytes |
| acl.c | -rw-r--r-- | 10.2 KB |
| acl.h | -rw-r--r-- | 1.5 KB |
| balloc.c | -rw-r--r-- | 23.0 KB |
| bitmap.c | -rw-r--r-- | 2.8 KB |
| block_validity.c | -rw-r--r-- | 6.7 KB |
| dir.c | -rw-r--r-- | 16.3 KB |
| ext4.h | -rw-r--r-- | 91.3 KB |
| ext4_extents.h | -rw-r--r-- | 8.6 KB |
| ext4_jbd2.c | -rw-r--r-- | 4.0 KB |
| ext4_jbd2.h | -rw-r--r-- | 13.4 KB |
| extents.c | -rw-r--r-- | 131.6 KB |
| extents_status.c | -rw-r--r-- | 12.9 KB |
| extents_status.h | -rw-r--r-- | 1.2 KB |
| file.c | -rw-r--r-- | 16.2 KB |
| fsync.c | -rw-r--r-- | 5.0 KB |
| hash.c | -rw-r--r-- | 4.4 KB |
| ialloc.c | -rw-r--r-- | 33.5 KB |
| indirect.c | -rw-r--r-- | 44.6 KB |
| inline.c | -rw-r--r-- | 45.2 KB |
| inode.c | -rw-r--r-- | 144.0 KB |
| ioctl.c | -rw-r--r-- | 11.3 KB |
| mballoc.c | -rw-r--r-- | 138.4 KB |
| mballoc.h | -rw-r--r-- | 5.4 KB |
| migrate.c | -rw-r--r-- | 14.9 KB |
| mmp.c | -rw-r--r-- | 9.9 KB |
| move_extent.c | -rw-r--r-- | 44.5 KB |
| namei.c | -rw-r--r-- | 86.2 KB |
| page-io.c | -rw-r--r-- | 12.9 KB |
| resize.c | -rw-r--r-- | 56.7 KB |
| super.c | -rw-r--r-- | 150.5 KB |
| symlink.c | -rw-r--r-- | 1.3 KB |
| truncate.h | -rw-r--r-- | 1.2 KB |
| xattr.c | -rw-r--r-- | 44.5 KB |
| xattr.h | -rw-r--r-- | 7.2 KB |
| xattr_security.c | -rw-r--r-- | 2.1 KB |
| xattr_trusted.c | -rw-r--r-- | 1.5 KB |
| xattr_user.c | -rw-r--r-- | 1.6 KB |
Computing file changes ...
