Revision 85de7fac3990cf0c0736edc83856add2e648c76a authored by Marek Vasut on 21 November 2012, 05:19:06 UTC, committed by Wolfram Sang on 21 January 2013, 15:26:29 UTC
The init_completion() call does reinit not only the variable carrying the flag that the completion finished, but also initialized the waitqueue associated with the completion. On the contrary, the INIT_COMPLETION() call only reinits the flag. In case there was anything still stuck in the waitqueue, subsequent call to init_completion() would be able to create possible race condition. This patch uses the proper function and moves init_completion() into .probe() call of the driver, to be issued only once. Note that such scenario is impossible, since two threads can never enter the mxs_i2c_xfer_msg(), since whole this section is protected by mutex in I2C core. This by no means allows this issue to exit though. Signed-off-by: Marek Vasut <marex@denx.de> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
1 parent 7d1f9ae
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.2 KB |
| Makefile | -rw-r--r-- | 240 bytes |
| alloc.c | -rw-r--r-- | 21.2 KB |
| alloc.h | -rw-r--r-- | 3.8 KB |
| bmap.c | -rw-r--r-- | 14.4 KB |
| bmap.h | -rw-r--r-- | 8.2 KB |
| btnode.c | -rw-r--r-- | 7.7 KB |
| btnode.h | -rw-r--r-- | 2.0 KB |
| btree.c | -rw-r--r-- | 60.0 KB |
| btree.h | -rw-r--r-- | 2.7 KB |
| cpfile.c | -rw-r--r-- | 24.5 KB |
| cpfile.h | -rw-r--r-- | 1.7 KB |
| dat.c | -rw-r--r-- | 13.2 KB |
| dat.h | -rw-r--r-- | 2.3 KB |
| dir.c | -rw-r--r-- | 17.4 KB |
| direct.c | -rw-r--r-- | 8.9 KB |
| direct.h | -rw-r--r-- | 1.5 KB |
| export.h | -rw-r--r-- | 482 bytes |
| file.c | -rw-r--r-- | 4.6 KB |
| gcinode.c | -rw-r--r-- | 5.6 KB |
| ifile.c | -rw-r--r-- | 5.4 KB |
| ifile.h | -rw-r--r-- | 1.8 KB |
| inode.c | -rw-r--r-- | 28.5 KB |
| ioctl.c | -rw-r--r-- | 21.2 KB |
| mdt.c | -rw-r--r-- | 14.4 KB |
| mdt.h | -rw-r--r-- | 4.0 KB |
| namei.c | -rw-r--r-- | 13.0 KB |
| nilfs.h | -rw-r--r-- | 11.7 KB |
| page.c | -rw-r--r-- | 13.7 KB |
| page.h | -rw-r--r-- | 2.6 KB |
| recovery.c | -rw-r--r-- | 24.4 KB |
| segbuf.c | -rw-r--r-- | 13.8 KB |
| segbuf.h | -rw-r--r-- | 6.2 KB |
| segment.c | -rw-r--r-- | 71.2 KB |
| segment.h | -rw-r--r-- | 8.1 KB |
| sufile.c | -rw-r--r-- | 24.6 KB |
| sufile.h | -rw-r--r-- | 4.8 KB |
| super.c | -rw-r--r-- | 35.6 KB |
| the_nilfs.c | -rw-r--r-- | 20.5 KB |
| the_nilfs.h | -rw-r--r-- | 10.8 KB |
Computing file changes ...
