Revision 85de7fac3990cf0c0736edc83856add2e648c76a authored by Marek Vasut on 21 November 2012, 05:19:06 UTC, committed by Wolfram Sang on 21 January 2013, 15:26:29 UTC
The init_completion() call does reinit not only the variable carrying the flag that the completion finished, but also initialized the waitqueue associated with the completion. On the contrary, the INIT_COMPLETION() call only reinits the flag. In case there was anything still stuck in the waitqueue, subsequent call to init_completion() would be able to create possible race condition. This patch uses the proper function and moves init_completion() into .probe() call of the driver, to be issued only once. Note that such scenario is impossible, since two threads can never enter the mxs_i2c_xfer_msg(), since whole this section is protected by mutex in I2C core. This by no means allows this issue to exit though. Signed-off-by: Marek Vasut <marex@denx.de> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
1 parent 7d1f9ae
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 4.4 KB |
| Makefile | -rw-r--r-- | 420 bytes |
| block.c | -rw-r--r-- | 5.4 KB |
| cache.c | -rw-r--r-- | 11.2 KB |
| decompressor.c | -rw-r--r-- | 3.0 KB |
| decompressor.h | -rw-r--r-- | 1.9 KB |
| dir.c | -rw-r--r-- | 6.2 KB |
| export.c | -rw-r--r-- | 4.6 KB |
| file.c | -rw-r--r-- | 13.9 KB |
| fragment.c | -rw-r--r-- | 3.1 KB |
| id.c | -rw-r--r-- | 2.9 KB |
| inode.c | -rw-r--r-- | 12.4 KB |
| lzo_wrapper.c | -rw-r--r-- | 3.2 KB |
| namei.c | -rw-r--r-- | 7.4 KB |
| squashfs.h | -rw-r--r-- | 3.4 KB |
| squashfs_fs.h | -rw-r--r-- | 10.7 KB |
| squashfs_fs_i.h | -rw-r--r-- | 1.4 KB |
| squashfs_fs_sb.h | -rw-r--r-- | 2.1 KB |
| super.c | -rw-r--r-- | 13.7 KB |
| symlink.c | -rw-r--r-- | 3.8 KB |
| xattr.c | -rw-r--r-- | 8.4 KB |
| xattr.h | -rw-r--r-- | 1.6 KB |
| xattr_id.c | -rw-r--r-- | 2.7 KB |
| xz_wrapper.c | -rw-r--r-- | 4.1 KB |
| zlib_wrapper.c | -rw-r--r-- | 3.5 KB |
Computing file changes ...
