Skip to main content

Browse the archive

Revision 86455a624bb05eb7503ccbe340dca973f5dea4c8 authored by Mike Pennisi on 29 June 2018, 23:46:14 UTC, committed by Ms2ger on 02 July 2018, 14:25:31 UTC 
[fetch] Do not return value from cleanup fns
 
Today, the return value of functions provided to the `Test#add_cleanup`
function has no effect on the behavior of the test runner. Despite this,
some existing tests have already been authored to return the `null`
value.

An upcoming feature addition to testharness.js will cause the return
value to influence test results [1]. To allow the new test harness
feature to land without introducing harness errors, refactor existing
tests to omit a return value.

[1] https://github.com/web-platform-tests/wpt/issues/6075
1 parent 27406c9
Raw File
share-extra-argument-manual.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>WebShare Test: Surplus arguments ignored</title>
    <script src="/resources/testharness.js"></script>
    <script src="/resources/testharnessreport.js"></script>
    <script src="resources/manual-helper.js"></script>
  </head>
  <body>
    <script>
        setup({explicit_timeout: true});

        setupManualShareTest(
            {title: 'the title', text: 'the message', url: 'data:the url'});
        callWhenButtonClicked(() => navigator.share(
              {title: 'the title', text: 'the message', url: 'data:the url'},
              'more than required'));
    </script>
  </body>
</html>
back to top