https://github.com/torvalds/linux
Revision 86b9bbd332d0510679c7fedcee3e3bd278be5756 authored by Toke Høiland-Jørgensen on 16 August 2021, 11:59:17 UTC, committed by David S. Miller on 18 August 2021, 09:14:00 UTC
When adding support for using the skb->hash value as the flow hash in CAKE,
I accidentally introduced a logic error that broke the host-only isolation
modes of CAKE (srchost and dsthost keywords). Specifically, the flow_hash
variable should stay initialised to 0 in cake_hash() in pure host-based
hashing mode. Add a check for this before using the skb->hash value as
flow_hash.

Fixes: b0c19ed6088a ("sch_cake: Take advantage of skb->hash where appropriate")
Reported-by: Pete Heist <pete@heistp.net>
Tested-by: Pete Heist <pete@heistp.net>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 1b80fec
History
Tip revision: 86b9bbd332d0510679c7fedcee3e3bd278be5756 authored by Toke Høiland-Jørgensen on 16 August 2021, 11:59:17 UTC
sch_cake: fix srchost/dsthost hashing mode
Tip revision: 86b9bbd

back to top