https://github.com/facebook/rocksdb
Revision 8756a118be7ea1c22e0dde65c267e5a7eaaa4906 authored by Maysam Yabandeh on 06 November 2018, 07:02:01 UTC, committed by Maysam Yabandeh on 06 November 2018, 22:00:18 UTC
Summary:
When evicting an entry form the commit_cache, it is verified against the list of old snapshots to see if it overlaps with any. The list of old snapshots is split into two lists: an efficient concurrent cache and an slow vector protected by a lock. The patch fixes a bug that would stop the search in the cache if it finds any and yet would not include the larger snapshots in the slower list.
An extra info log entry is also removed. The condition to trigger that although very rare is still feasible and should not spam the LOG when that happens.
Fixes #4621
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4639

Differential Revision: D12934989

Pulled By: maysamyabandeh

fbshipit-source-id: 4e0fe8147ba292b554ae78e94c21c2ef31e03e2d
1 parent c190eb5
Raw File
Tip revision: 8756a118be7ea1c22e0dde65c267e5a7eaaa4906 authored by Maysam Yabandeh on 06 November 2018, 07:02:01 UTC
WritePrepared: Fix bug in searching in non-cached snapshots (#4639)
Tip revision: 8756a11
DUMP_FORMAT.md
## RocksDB dump format

The version 1 RocksDB dump format is fairly simple:

1) The dump starts with the magic 8 byte identifier "ROCKDUMP"

2) The magic is followed by an 8 byte big-endian version which is 0x00000001.

3) Next are arbitrarily sized chunks of bytes prepended by 4 byte little endian number indicating how large each chunk is.

4) The first chunk is special and is a json string indicating some things about the creation of this dump.  It contains the following keys:
* database-path: The path of the database this dump was created from.
* hostname: The hostname of the machine where the dump was created.
* creation-time: Unix seconds since epoc when this dump was created.

5) Following the info dump the slices paired into are key/value pairs.
back to top