https://github.com/facebook/rocksdb
Revision 8756a118be7ea1c22e0dde65c267e5a7eaaa4906 authored by Maysam Yabandeh on 06 November 2018, 07:02:01 UTC, committed by Maysam Yabandeh on 06 November 2018, 22:00:18 UTC
Summary: When evicting an entry form the commit_cache, it is verified against the list of old snapshots to see if it overlaps with any. The list of old snapshots is split into two lists: an efficient concurrent cache and an slow vector protected by a lock. The patch fixes a bug that would stop the search in the cache if it finds any and yet would not include the larger snapshots in the slower list. An extra info log entry is also removed. The condition to trigger that although very rare is still feasible and should not spam the LOG when that happens. Fixes #4621 Pull Request resolved: https://github.com/facebook/rocksdb/pull/4639 Differential Revision: D12934989 Pulled By: maysamyabandeh fbshipit-source-id: 4e0fe8147ba292b554ae78e94c21c2ef31e03e2d
1 parent c190eb5
Tip revision: 8756a118be7ea1c22e0dde65c267e5a7eaaa4906 authored by Maysam Yabandeh on 06 November 2018, 07:02:01 UTC
WritePrepared: Fix bug in searching in non-cached snapshots (#4639)
WritePrepared: Fix bug in searching in non-cached snapshots (#4639)
Tip revision: 8756a11
| File | Mode | Size |
|---|---|---|
| cf_options.cc | -rw-r--r-- | 8.5 KB |
| cf_options.h | -rw-r--r-- | 8.1 KB |
| db_options.cc | -rw-r--r-- | 13.5 KB |
| db_options.h | -rw-r--r-- | 3.1 KB |
| options.cc | -rw-r--r-- | 22.8 KB |
| options_helper.cc | -rw-r--r-- | 82.8 KB |
| options_helper.h | -rw-r--r-- | 8.2 KB |
| options_parser.cc | -rw-r--r-- | 29.9 KB |
| options_parser.h | -rw-r--r-- | 5.1 KB |
| options_sanity_check.cc | -rw-r--r-- | 1.1 KB |
| options_sanity_check.h | -rw-r--r-- | 1.7 KB |
| options_settable_test.cc | -rw-r--r-- | 20.5 KB |
| options_test.cc | -rw-r--r-- | 73.5 KB |
Computing file changes ...
