Skip to main content

Browse the archive

Revision 87bec7f2841f42f6738d11db4e7986fa95e63ea2 authored by Sergio Villar Senin on 23 March 2018, 11:33:30 UTC, committed by Chromium WPT Sync on 23 March 2018, 11:33:30 UTC 
[css-grid] Fix auto repeat tracks computation with definite min sizes
 
Indefinitely sized containers use the specified definite min-size (if any) as
available space in order to compute the number of auto repeat tracks to
create. A bug in that code was causing the grid to be one track larger than
expected. That was only happening in the case of the free space being
a multiple of the total size of the autorepeat tracks.

Bug: 823140
Change-Id: I6cc13df478da4ba00585fa557012391291941d1a
Reviewed-on: https://chromium-review.googlesource.com/973522
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#545403}
1 parent b04a923
Raw File
idlharness.https.html 
<!doctype html>
<html>
<head>
<title>Keyboard IDL tests</title>
<link rel="help" href="https://w3c.github.io/keyboard-lock/"/>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/WebIDLParser.js"></script>
<script src="/resources/idlharness.js"></script>
<script>
'use strict';

function doTest(idls) {
  var idl_array = new IdlArray();
  idl_array.add_untested_idls('interface Navigator {};');
  for (let idl of idls) {
    idl_array.add_idls(idl);
  }
  idl_array.add_objects({
    Navigator: ['navigator'],
    Keyboard: ['navigator.keyboard'],
  });
  idl_array.test();
};

function fetchText(url) {
  return fetch(url).then((response) => response.text());
}

promise_test(() => {
  return Promise.all(["/interfaces/keyboard-lock.idl"].map(fetchText))
    .then(doTest);
}, "Test driver");
</script>
back to top