Skip to main content

Browse the archive

Revision 87bec7f2841f42f6738d11db4e7986fa95e63ea2 authored by Sergio Villar Senin on 23 March 2018, 11:33:30 UTC, committed by Chromium WPT Sync on 23 March 2018, 11:33:30 UTC 
[css-grid] Fix auto repeat tracks computation with definite min sizes
 
Indefinitely sized containers use the specified definite min-size (if any) as
available space in order to compute the number of auto repeat tracks to
create. A bug in that code was causing the grid to be one track larger than
expected. That was only happening in the case of the free space being
a multiple of the total size of the autorepeat tracks.

Bug: 823140
Change-Id: I6cc13df478da4ba00585fa557012391291941d1a
Reviewed-on: https://chromium-review.googlesource.com/973522
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#545403}
1 parent b04a923
Raw File
t010-manual.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rotate the device frame around its y axis</title>
    <meta name=viewport content="width=device-width, maximum-scale=1.0">
    <script src="/resources/testharness.js"></script>
    <script src="/resources/testharnessreport.js"></script>
    <link rel="author" title="Mosquito FP7">
    <link rel="reviewer author" title="Zhiqiang Zhang" href="mailto:zhiqiang.zhang@intel.com"> <!-- 2013-10-12 -->
  </head>
  <body>
    <p>Rotate the device frame around its y axis to run the test.</p>
    <div id="log"></div>
    <script>
      var t1 = async_test("Gamma is in [-90, 90)");
      var run = false;
      window.addEventListener("deviceorientation", function(e) {
        if (!run && e.gamma !== null) {
          run = true;
          t1.step(function() {
            assert_greater_than_equal(e.gamma, -90);
            assert_less_than(e.gamma, 90);
          });
          t1.done();
        }
      }, false);
    </script>
  </body>
</html>
back to top