Revision - 87cbde8 - PM / s2idle: Invoke the ->wake() platform callback earlier - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

05 April 2024, 19:05:47 UTC

Revision 87cbde8d9081b91df86a21d0d743cd700e04890a authored by Rafael J. Wysocki on 27 September 2017, 23:45:10 UTC, committed by Rafael J. Wysocki on 28 September 2017, 23:26:13 UTC

PM / s2idle: Invoke the ->wake() platform callback earlier

The role of the ->wake() platform callback for suspend-to-idle is to
deal with possible spurious wakeups, among other things.  The ACPI
implementation of it, acpi_s2idle_wake(), additionally checks the
conditions for entering the Low Power S0 Idle state by the platform
and reports the ones that have not been met.

However, the ->wake() platform callback is invoked after calling
dpm_noirq_resume_devices(), which means that the power states of some
devices may have changed since s2idle_enter() returned, so some unmet
Low Power S0 Idle conditions may be reported incorrectly as a result
of that.

To avoid these false positives, reorder the invocations of the
dpm_noirq_resume_devices() routine and the ->wake() platform callback
in s2idle_loop().

Fixes: 726fb6b4f2a8 (ACPI / PM: Check low power idle constraints for debug only)
Tested-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

1 parent e19b205

Files
Changes

Permalinks

Tip revision: 87cbde8d9081b91df86a21d0d743cd700e04890a authored by Rafael J. Wysocki on 27 September 2017, 23:45:10 UTC
PM / s2idle: Invoke the ->wake() platform callback earlier

Tip revision: 87cbde8

File	Mode	Size
Documentation
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	31 bytes
.gitattributes	-rw-r--r--	30 bytes
.gitignore	-rw-r--r--	1.3 KB
.mailmap	-rw-r--r--	8.1 KB
COPYING	-rw-r--r--	18.3 KB
CREDITS	-rw-r--r--	96.1 KB
Kbuild	-rw-r--r--	2.2 KB
Kconfig	-rw-r--r--	252 bytes
MAINTAINERS	-rw-r--r--	420.1 KB
Makefile	-rw-r--r--	58.2 KB
README	-rw-r--r--	722 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

PM / s2idle: Invoke the ->wake() platform callback earlier

README