Revision 87f3b6b6fbcbfa715f0d0db3e7a63e65716a6d4e authored by Mathieu Desnoyers on 06 October 2008, 13:30:12 UTC, committed by Linus Torvalds on 06 October 2008, 23:34:19 UTC
* Theodore Ts'o (tytso@mit.edu) wrote: > > I've been playing with adding some markers into ext4 to see if they > could be useful in solving some problems along with Systemtap. It > appears, though, that as of 2.6.27-rc8, markers defined in code which is > compiled directly into the kernel (i.e., not as modules) don't show up > in Module.markers: > > kvm_trace_entryexit arch/x86/kvm/kvm-intel %u %p %u %u %u %u %u %u > kvm_trace_handler arch/x86/kvm/kvm-intel %u %p %u %u %u %u %u %u > kvm_trace_entryexit arch/x86/kvm/kvm-amd %u %p %u %u %u %u %u %u > kvm_trace_handler arch/x86/kvm/kvm-amd %u %p %u %u %u %u %u %u > > (Note the lack of any of the kernel_sched_* markers, and the markers I > added for ext4_* and jbd2_* are missing as wel.) > > Systemtap apparently depends on in-kernel trace_mark being recorded in > Module.markers, and apparently it's been claimed that it used to be > there. Is this a bug in systemtap, or in how Module.markers is getting > built? And is there a file that contains the equivalent information > for markers located in non-modules code? I think the problem comes from "markers: fix duplicate modpost entry" (commit d35cb360c29956510b2fe1a953bd4968536f7216) Especially : - add_marker(mod, marker, fmt); + if (!mod->skip) + add_marker(mod, marker, fmt); } return; fail: Here is a fix that should take care if this problem. Thanks for the bug report! Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Tested-by: "Theodore Ts'o" <tytso@mit.edu> CC: Greg KH <greg@kroah.com> CC: David Smith <dsmith@redhat.com> CC: Roland McGrath <roland@redhat.com> CC: Sam Ravnborg <sam@ravnborg.org> CC: Wenji Huang <wenji.huang@oracle.com> CC: Takashi Nishiie <t-nishiie@np.css.fujitsu.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent afed26d
File | Mode | Size |
---|---|---|
irq | ||
power | ||
time | ||
trace | ||
.gitignore | -rw-r--r-- | 63 bytes |
Kconfig.hz | -rw-r--r-- | 1.7 KB |
Kconfig.preempt | -rw-r--r-- | 2.8 KB |
Makefile | -rw-r--r-- | 4.4 KB |
acct.c | -rw-r--r-- | 17.2 KB |
audit.c | -rw-r--r-- | 39.4 KB |
audit.h | -rw-r--r-- | 5.5 KB |
audit_tree.c | -rw-r--r-- | 20.5 KB |
auditfilter.c | -rw-r--r-- | 45.6 KB |
auditsc.c | -rw-r--r-- | 62.7 KB |
backtracetest.c | -rw-r--r-- | 2.1 KB |
bounds.c | -rw-r--r-- | 526 bytes |
capability.c | -rw-r--r-- | 12.9 KB |
cgroup.c | -rw-r--r-- | 81.6 KB |
cgroup_debug.c | -rw-r--r-- | 2.0 KB |
compat.c | -rw-r--r-- | 27.4 KB |
configs.c | -rw-r--r-- | 3.1 KB |
cpu.c | -rw-r--r-- | 11.4 KB |
cpuset.c | -rw-r--r-- | 70.5 KB |
delayacct.c | -rw-r--r-- | 4.9 KB |
dma-coherent.c | -rw-r--r-- | 4.0 KB |
dma.c | -rw-r--r-- | 3.7 KB |
exec_domain.c | -rw-r--r-- | 4.3 KB |
exit.c | -rw-r--r-- | 45.6 KB |
extable.c | -rw-r--r-- | 2.0 KB |
fork.c | -rw-r--r-- | 40.6 KB |
futex.c | -rw-r--r-- | 50.3 KB |
futex_compat.c | -rw-r--r-- | 4.4 KB |
hrtimer.c | -rw-r--r-- | 42.2 KB |
itimer.c | -rw-r--r-- | 7.8 KB |
kallsyms.c | -rw-r--r-- | 11.7 KB |
kexec.c | -rw-r--r-- | 37.3 KB |
kfifo.c | -rw-r--r-- | 5.1 KB |
kgdb.c | -rw-r--r-- | 38.5 KB |
kmod.c | -rw-r--r-- | 14.2 KB |
kprobes.c | -rw-r--r-- | 32.1 KB |
ksysfs.c | -rw-r--r-- | 3.8 KB |
kthread.c | -rw-r--r-- | 7.2 KB |
latencytop.c | -rw-r--r-- | 5.2 KB |
lockdep.c | -rw-r--r-- | 85.1 KB |
lockdep_internals.h | -rw-r--r-- | 2.9 KB |
lockdep_proc.c | -rw-r--r-- | 18.1 KB |
marker.c | -rw-r--r-- | 23.6 KB |
module.c | -rw-r--r-- | 69.3 KB |
mutex-debug.c | -rw-r--r-- | 3.0 KB |
mutex-debug.h | -rw-r--r-- | 1.7 KB |
mutex.c | -rw-r--r-- | 10.4 KB |
mutex.h | -rw-r--r-- | 1.1 KB |
notifier.c | -rw-r--r-- | 16.7 KB |
ns_cgroup.c | -rw-r--r-- | 2.3 KB |
nsproxy.c | -rw-r--r-- | 5.4 KB |
panic.c | -rw-r--r-- | 8.3 KB |
params.c | -rw-r--r-- | 17.5 KB |
pid.c | -rw-r--r-- | 12.7 KB |
pid_namespace.c | -rw-r--r-- | 4.2 KB |
pm_qos_params.c | -rw-r--r-- | 11.6 KB |
posix-cpu-timers.c | -rw-r--r-- | 43.6 KB |
posix-timers.c | -rw-r--r-- | 29.3 KB |
printk.c | -rw-r--r-- | 32.9 KB |
profile.c | -rw-r--r-- | 15.8 KB |
ptrace.c | -rw-r--r-- | 16.1 KB |
rcuclassic.c | -rw-r--r-- | 17.1 KB |
rcupdate.c | -rw-r--r-- | 4.8 KB |
rcupreempt.c | -rw-r--r-- | 40.8 KB |
rcupreempt_trace.c | -rw-r--r-- | 9.2 KB |
rcutorture.c | -rw-r--r-- | 31.1 KB |
relay.c | -rw-r--r-- | 32.6 KB |
res_counter.c | -rw-r--r-- | 3.0 KB |
resource.c | -rw-r--r-- | 17.6 KB |
rtmutex-debug.c | -rw-r--r-- | 5.7 KB |
rtmutex-debug.h | -rw-r--r-- | 1.4 KB |
rtmutex-tester.c | -rw-r--r-- | 9.1 KB |
rtmutex.c | -rw-r--r-- | 25.9 KB |
rtmutex.h | -rw-r--r-- | 1.1 KB |
rtmutex_common.h | -rw-r--r-- | 3.3 KB |
rwsem.c | -rw-r--r-- | 2.6 KB |
sched.c | -rw-r--r-- | 222.2 KB |
sched_clock.c | -rw-r--r-- | 5.7 KB |
sched_cpupri.c | -rw-r--r-- | 4.4 KB |
sched_cpupri.h | -rw-r--r-- | 880 bytes |
sched_debug.c | -rw-r--r-- | 10.5 KB |
sched_fair.c | -rw-r--r-- | 40.5 KB |
sched_features.h | -rw-r--r-- | 371 bytes |
sched_idletask.c | -rw-r--r-- | 2.9 KB |
sched_rt.c | -rw-r--r-- | 34.3 KB |
sched_stats.h | -rw-r--r-- | 8.0 KB |
seccomp.c | -rw-r--r-- | 1.6 KB |
semaphore.c | -rw-r--r-- | 7.2 KB |
signal.c | -rw-r--r-- | 64.4 KB |
smp.c | -rw-r--r-- | 10.6 KB |
softirq.c | -rw-r--r-- | 14.9 KB |
softlockup.c | -rw-r--r-- | 8.9 KB |
spinlock.c | -rw-r--r-- | 11.4 KB |
srcu.c | -rw-r--r-- | 8.4 KB |
stacktrace.c | -rw-r--r-- | 522 bytes |
stop_machine.c | -rw-r--r-- | 4.2 KB |
sys.c | -rw-r--r-- | 42.2 KB |
sys_ni.c | -rw-r--r-- | 4.8 KB |
sysctl.c | -rw-r--r-- | 71.1 KB |
sysctl_check.c | -rw-r--r-- | 50.4 KB |
taskstats.c | -rw-r--r-- | 13.6 KB |
test_kprobes.c | -rw-r--r-- | 4.9 KB |
time.c | -rw-r--r-- | 17.3 KB |
timeconst.pl | -rw-r--r-- | 7.2 KB |
timer.c | -rw-r--r-- | 39.2 KB |
tsacct.c | -rw-r--r-- | 4.1 KB |
uid16.c | -rw-r--r-- | 5.3 KB |
user.c | -rw-r--r-- | 12.4 KB |
user_namespace.c | -rw-r--r-- | 1.6 KB |
utsname.c | -rw-r--r-- | 1.5 KB |
utsname_sysctl.c | -rw-r--r-- | 3.4 KB |
wait.c | -rw-r--r-- | 7.1 KB |
workqueue.c | -rw-r--r-- | 23.8 KB |
Computing file changes ...