Revision 87f3b6b6fbcbfa715f0d0db3e7a63e65716a6d4e authored by Mathieu Desnoyers on 06 October 2008, 13:30:12 UTC, committed by Linus Torvalds on 06 October 2008, 23:34:19 UTC
* Theodore Ts'o (tytso@mit.edu) wrote: > > I've been playing with adding some markers into ext4 to see if they > could be useful in solving some problems along with Systemtap. It > appears, though, that as of 2.6.27-rc8, markers defined in code which is > compiled directly into the kernel (i.e., not as modules) don't show up > in Module.markers: > > kvm_trace_entryexit arch/x86/kvm/kvm-intel %u %p %u %u %u %u %u %u > kvm_trace_handler arch/x86/kvm/kvm-intel %u %p %u %u %u %u %u %u > kvm_trace_entryexit arch/x86/kvm/kvm-amd %u %p %u %u %u %u %u %u > kvm_trace_handler arch/x86/kvm/kvm-amd %u %p %u %u %u %u %u %u > > (Note the lack of any of the kernel_sched_* markers, and the markers I > added for ext4_* and jbd2_* are missing as wel.) > > Systemtap apparently depends on in-kernel trace_mark being recorded in > Module.markers, and apparently it's been claimed that it used to be > there. Is this a bug in systemtap, or in how Module.markers is getting > built? And is there a file that contains the equivalent information > for markers located in non-modules code? I think the problem comes from "markers: fix duplicate modpost entry" (commit d35cb360c29956510b2fe1a953bd4968536f7216) Especially : - add_marker(mod, marker, fmt); + if (!mod->skip) + add_marker(mod, marker, fmt); } return; fail: Here is a fix that should take care if this problem. Thanks for the bug report! Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Tested-by: "Theodore Ts'o" <tytso@mit.edu> CC: Greg KH <greg@kroah.com> CC: David Smith <dsmith@redhat.com> CC: Roland McGrath <roland@redhat.com> CC: Sam Ravnborg <sam@ravnborg.org> CC: Wenji Huang <wenji.huang@oracle.com> CC: Takashi Nishiie <t-nishiie@np.css.fujitsu.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent afed26d
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 2.5 KB |
Makefile | -rw-r--r-- | 518 bytes |
associola.c | -rw-r--r-- | 42.9 KB |
auth.c | -rw-r--r-- | 23.9 KB |
bind_addr.c | -rw-r--r-- | 13.2 KB |
chunk.c | -rw-r--r-- | 8.0 KB |
command.c | -rw-r--r-- | 2.3 KB |
debug.c | -rw-r--r-- | 4.5 KB |
endpointola.c | -rw-r--r-- | 13.0 KB |
input.c | -rw-r--r-- | 30.0 KB |
inqueue.c | -rw-r--r-- | 6.9 KB |
ipv6.c | -rw-r--r-- | 29.0 KB |
objcnt.c | -rw-r--r-- | 4.2 KB |
output.c | -rw-r--r-- | 21.6 KB |
outqueue.c | -rw-r--r-- | 52.2 KB |
primitive.c | -rw-r--r-- | 7.6 KB |
proc.c | -rw-r--r-- | 13.6 KB |
protocol.c | -rw-r--r-- | 37.1 KB |
sm_make_chunk.c | -rw-r--r-- | 96.9 KB |
sm_sideeffect.c | -rw-r--r-- | 44.1 KB |
sm_statefuns.c | -rw-r--r-- | 186.1 KB |
sm_statetable.c | -rw-r--r-- | 33.5 KB |
socket.c | -rw-r--r-- | 188.9 KB |
ssnmap.c | -rw-r--r-- | 3.4 KB |
sysctl.c | -rw-r--r-- | 7.6 KB |
transport.c | -rw-r--r-- | 18.6 KB |
tsnmap.c | -rw-r--r-- | 10.4 KB |
ulpevent.c | -rw-r--r-- | 29.7 KB |
ulpqueue.c | -rw-r--r-- | 27.9 KB |
Computing file changes ...