https://github.com/facebook/rocksdb
Revision 8800975fb0f333ff20bb567e94c0a3fda3df9c1d authored by sdong on 25 February 2016, 23:42:26 UTC, committed by sdong on 26 February 2016, 19:59:31 UTC
Summary:
Based on thread scheduling, DBTestUniversalCompaction.IncreaseUniversalCompactionNumLevels can fail to flush enough files to trigger expected compactions. Fix it by waiting for flush after inserting each key.
There are failrue reported:

db/db_universal_compaction_test.cc:1134: Failure
Expected: (NumTableFilesAtLevel(options.num_levels - 1, 1)) > (0), actual: 0 vs 0

but I can't repro it. Try to fix the bug and see whether it goes away.

Test Plan: Run the test multiple time.

Reviewers: IslamAbdelRahman, anthony, andrewkr, kradhakrishnan, yhchiang

Reviewed By: yhchiang

Subscribers: leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D54747
1 parent cd3fe67
History
Tip revision: 8800975fb0f333ff20bb567e94c0a3fda3df9c1d authored by sdong on 25 February 2016, 23:42:26 UTC
Make DBTestUniversalCompaction.IncreaseUniversalCompactionNumLevels more robust
Tip revision: 8800975
File Mode Size
arcanist_util
build_tools
coverage
db
doc
examples
hdfs
include
java
memtable
port
table
third-party
tools
util
utilities
.arcconfig -rw-r--r-- 564 bytes
.clang-format -rw-r--r-- 138 bytes
.gitignore -rw-r--r-- 622 bytes
.travis.yml -rw-r--r-- 1.9 KB
AUTHORS -rw-r--r-- 247 bytes
CMakeLists.txt -rw-r--r-- 16.8 KB
CONTRIBUTING.md -rw-r--r-- 733 bytes
DUMP_FORMAT.md -rw-r--r-- 763 bytes
HISTORY.md -rw-r--r-- 30.4 KB
INSTALL.md -rw-r--r-- 3.9 KB
LICENSE -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 41.2 KB
PATENTS -rw-r--r-- 1.9 KB
README.md -rw-r--r-- 1.2 KB
ROCKSDB_LITE.md -rw-r--r-- 1.0 KB
USERS.md -rw-r--r-- 2.8 KB
Vagrantfile -rw-r--r-- 862 bytes
WINDOWS_PORT.md -rw-r--r-- 12.5 KB
appveyor.yml -rw-r--r-- 462 bytes
src.mk -rw-r--r-- 21.0 KB
thirdparty.inc -rw-r--r-- 7.0 KB

README.md

back to top