Revision 88956eabfdea7d01d550535af120d4ef265b1d02 authored by NeilBrown on 12 September 2023, 01:25:00 UTC, committed by Chuck Lever on 12 September 2023, 13:39:35 UTC
If /proc/fs/nfsd/pool_stats is open when the last nfsd thread exits, then when the file is closed a NULL pointer is dereferenced. This is because nfsd_pool_stats_release() assumes that the pointer to the svc_serv cannot become NULL while a reference is held. This used to be the case but a recent patch split nfsd_last_thread() out from nfsd_put(), and clearing the pointer is done in nfsd_last_thread(). This is easily reproduced by running rpc.nfsd 8 ; ( rpc.nfsd 0;true) < /proc/fs/nfsd/pool_stats Fortunately nfsd_pool_stats_release() has easy access to the svc_serv pointer, and so can call svc_put() on it directly. Fixes: 9f28a971ee9f ("nfsd: separate nfsd_last_thread() from nfsd_put()") Signed-off-by: NeilBrown <neilb@suse.de> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent fdd2630
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.2 KB |
Makefile | -rw-r--r-- | 287 bytes |
acl.c | -rw-r--r-- | 7.8 KB |
acl.h | -rw-r--r-- | 1.6 KB |
cache.c | -rw-r--r-- | 1.7 KB |
cache.h | -rw-r--r-- | 572 bytes |
fid.c | -rw-r--r-- | 7.3 KB |
fid.h | -rw-r--r-- | 1.9 KB |
v9fs.c | -rw-r--r-- | 16.1 KB |
v9fs.h | -rw-r--r-- | 8.0 KB |
v9fs_vfs.h | -rw-r--r-- | 3.3 KB |
vfs_addr.c | -rw-r--r-- | 9.3 KB |
vfs_dentry.c | -rw-r--r-- | 2.4 KB |
vfs_dir.c | -rw-r--r-- | 5.4 KB |
vfs_file.c | -rw-r--r-- | 14.4 KB |
vfs_inode.c | -rw-r--r-- | 33.5 KB |
vfs_inode_dotl.c | -rw-r--r-- | 25.1 KB |
vfs_super.c | -rw-r--r-- | 7.4 KB |
xattr.c | -rw-r--r-- | 4.9 KB |
xattr.h | -rw-r--r-- | 887 bytes |
Computing file changes ...