Revision 88956eabfdea7d01d550535af120d4ef265b1d02 authored by NeilBrown on 12 September 2023, 01:25:00 UTC, committed by Chuck Lever on 12 September 2023, 13:39:35 UTC
If /proc/fs/nfsd/pool_stats is open when the last nfsd thread exits, then when the file is closed a NULL pointer is dereferenced. This is because nfsd_pool_stats_release() assumes that the pointer to the svc_serv cannot become NULL while a reference is held. This used to be the case but a recent patch split nfsd_last_thread() out from nfsd_put(), and clearing the pointer is done in nfsd_last_thread(). This is easily reproduced by running rpc.nfsd 8 ; ( rpc.nfsd 0;true) < /proc/fs/nfsd/pool_stats Fortunately nfsd_pool_stats_release() has easy access to the svc_serv pointer, and so can call svc_put() on it directly. Fixes: 9f28a971ee9f ("nfsd: separate nfsd_last_thread() from nfsd_put()") Signed-off-by: NeilBrown <neilb@suse.de> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent fdd2630
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.5 KB |
Makefile | -rw-r--r-- | 372 bytes |
acl.c | -rw-r--r-- | 5.7 KB |
addr.c | -rw-r--r-- | 55.9 KB |
cache.c | -rw-r--r-- | 2.8 KB |
cache.h | -rw-r--r-- | 3.6 KB |
caps.c | -rw-r--r-- | 127.9 KB |
ceph_frag.c | -rw-r--r-- | 401 bytes |
debugfs.c | -rw-r--r-- | 13.2 KB |
dir.c | -rw-r--r-- | 53.8 KB |
export.c | -rw-r--r-- | 13.7 KB |
file.c | -rw-r--r-- | 69.5 KB |
inode.c | -rw-r--r-- | 69.8 KB |
io.c | -rw-r--r-- | 4.5 KB |
io.h | -rw-r--r-- | 387 bytes |
ioctl.c | -rw-r--r-- | 7.5 KB |
ioctl.h | -rw-r--r-- | 3.6 KB |
locks.c | -rw-r--r-- | 13.0 KB |
mds_client.c | -rw-r--r-- | 144.2 KB |
mds_client.h | -rw-r--r-- | 17.9 KB |
mdsmap.c | -rw-r--r-- | 10.7 KB |
metric.c | -rw-r--r-- | 10.6 KB |
metric.h | -rw-r--r-- | 6.1 KB |
quota.c | -rw-r--r-- | 14.5 KB |
snap.c | -rw-r--r-- | 36.4 KB |
strings.c | -rw-r--r-- | 4.3 KB |
super.c | -rw-r--r-- | 37.9 KB |
super.h | -rw-r--r-- | 43.2 KB |
util.c | -rw-r--r-- | 2.4 KB |
xattr.c | -rw-r--r-- | 36.2 KB |
Computing file changes ...