Revision 88956eabfdea7d01d550535af120d4ef265b1d02 authored by NeilBrown on 12 September 2023, 01:25:00 UTC, committed by Chuck Lever on 12 September 2023, 13:39:35 UTC
If /proc/fs/nfsd/pool_stats is open when the last nfsd thread exits, then
when the file is closed a NULL pointer is dereferenced.
This is because nfsd_pool_stats_release() assumes that the
pointer to the svc_serv cannot become NULL while a reference is held.
This used to be the case but a recent patch split nfsd_last_thread() out
from nfsd_put(), and clearing the pointer is done in nfsd_last_thread().
This is easily reproduced by running
rpc.nfsd 8 ; ( rpc.nfsd 0;true) < /proc/fs/nfsd/pool_stats
Fortunately nfsd_pool_stats_release() has easy access to the svc_serv
pointer, and so can call svc_put() on it directly.
Fixes: 9f28a971ee9f ("nfsd: separate nfsd_last_thread() from nfsd_put()")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent fdd2630
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 576 bytes |
| Makefile | -rw-r--r-- | 365 bytes |
| attributes.c | -rw-r--r-- | 8.7 KB |
| bfind.c | -rw-r--r-- | 6.1 KB |
| bitmap.c | -rw-r--r-- | 5.1 KB |
| bnode.c | -rw-r--r-- | 15.4 KB |
| brec.c | -rw-r--r-- | 13.6 KB |
| btree.c | -rw-r--r-- | 12.3 KB |
| catalog.c | -rw-r--r-- | 14.1 KB |
| dir.c | -rw-r--r-- | 14.0 KB |
| extents.c | -rw-r--r-- | 15.5 KB |
| hfsplus_fs.h | -rw-r--r-- | 16.9 KB |
| hfsplus_raw.h | -rw-r--r-- | 9.6 KB |
| inode.c | -rw-r--r-- | 19.1 KB |
| ioctl.c | -rw-r--r-- | 1.8 KB |
| options.c | -rw-r--r-- | 5.4 KB |
| part_tbl.c | -rw-r--r-- | 4.2 KB |
| super.c | -rw-r--r-- | 17.8 KB |
| tables.c | -rw-r--r-- | 119.1 KB |
| unicode.c | -rw-r--r-- | 10.5 KB |
| wrapper.c | -rw-r--r-- | 6.9 KB |
| xattr.c | -rw-r--r-- | 23.2 KB |
| xattr.h | -rw-r--r-- | 1.2 KB |
| xattr_security.c | -rw-r--r-- | 2.0 KB |
| xattr_trusted.c | -rw-r--r-- | 1.0 KB |
| xattr_user.c | -rw-r--r-- | 993 bytes |
Computing file changes ...
