Revision 88956eabfdea7d01d550535af120d4ef265b1d02 authored by NeilBrown on 12 September 2023, 01:25:00 UTC, committed by Chuck Lever on 12 September 2023, 13:39:35 UTC
If /proc/fs/nfsd/pool_stats is open when the last nfsd thread exits, then
when the file is closed a NULL pointer is dereferenced.
This is because nfsd_pool_stats_release() assumes that the
pointer to the svc_serv cannot become NULL while a reference is held.
This used to be the case but a recent patch split nfsd_last_thread() out
from nfsd_put(), and clearing the pointer is done in nfsd_last_thread().
This is easily reproduced by running
rpc.nfsd 8 ; ( rpc.nfsd 0;true) < /proc/fs/nfsd/pool_stats
Fortunately nfsd_pool_stats_release() has easy access to the svc_serv
pointer, and so can call svc_put() on it directly.
Fixes: 9f28a971ee9f ("nfsd: separate nfsd_last_thread() from nfsd_put()")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent fdd2630
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 3.3 KB |
| Makefile | -rw-r--r-- | 459 bytes |
| aops.c | -rw-r--r-- | 51.6 KB |
| aops.h | -rw-r--r-- | 3.1 KB |
| attrib.c | -rw-r--r-- | 89.4 KB |
| attrib.h | -rw-r--r-- | 3.5 KB |
| bitmap.c | -rw-r--r-- | 4.7 KB |
| bitmap.h | -rw-r--r-- | 2.8 KB |
| collate.c | -rw-r--r-- | 2.8 KB |
| collate.h | -rw-r--r-- | 934 bytes |
| compress.c | -rw-r--r-- | 28.0 KB |
| debug.c | -rw-r--r-- | 4.0 KB |
| debug.h | -rw-r--r-- | 1.5 KB |
| dir.c | -rw-r--r-- | 50.8 KB |
| dir.h | -rw-r--r-- | 908 bytes |
| endian.h | -rw-r--r-- | 1.4 KB |
| file.c | -rw-r--r-- | 59.3 KB |
| index.c | -rw-r--r-- | 14.0 KB |
| index.h | -rw-r--r-- | 4.7 KB |
| inode.c | -rw-r--r-- | 96.3 KB |
| inode.h | -rw-r--r-- | 10.3 KB |
| layout.h | -rw-r--r-- | 96.2 KB |
| lcnalloc.c | -rw-r--r-- | 31.6 KB |
| lcnalloc.h | -rw-r--r-- | 4.9 KB |
| logfile.c | -rw-r--r-- | 27.4 KB |
| logfile.h | -rw-r--r-- | 12.8 KB |
| malloc.h | -rw-r--r-- | 2.3 KB |
| mft.c | -rw-r--r-- | 98.6 KB |
| mft.h | -rw-r--r-- | 3.2 KB |
| mst.c | -rw-r--r-- | 6.2 KB |
| namei.c | -rw-r--r-- | 13.3 KB |
| ntfs.h | -rw-r--r-- | 4.2 KB |
| quota.c | -rw-r--r-- | 2.9 KB |
| quota.h | -rw-r--r-- | 432 bytes |
| runlist.c | -rw-r--r-- | 58.7 KB |
| runlist.h | -rw-r--r-- | 2.6 KB |
| super.c | -rw-r--r-- | 99.0 KB |
| sysctl.c | -rw-r--r-- | 1.3 KB |
| sysctl.h | -rw-r--r-- | 613 bytes |
| time.h | -rw-r--r-- | 2.8 KB |
| types.h | -rw-r--r-- | 1.3 KB |
| unistr.c | -rw-r--r-- | 11.4 KB |
| upcase.c | -rw-r--r-- | 3.1 KB |
| usnjrnl.c | -rw-r--r-- | 1.9 KB |
| usnjrnl.h | -rw-r--r-- | 8.4 KB |
| volume.h | -rw-r--r-- | 6.1 KB |
Computing file changes ...
