Revision 88956eabfdea7d01d550535af120d4ef265b1d02 authored by NeilBrown on 12 September 2023, 01:25:00 UTC, committed by Chuck Lever on 12 September 2023, 13:39:35 UTC
If /proc/fs/nfsd/pool_stats is open when the last nfsd thread exits, then when the file is closed a NULL pointer is dereferenced. This is because nfsd_pool_stats_release() assumes that the pointer to the svc_serv cannot become NULL while a reference is held. This used to be the case but a recent patch split nfsd_last_thread() out from nfsd_put(), and clearing the pointer is done in nfsd_last_thread(). This is easily reproduced by running rpc.nfsd 8 ; ( rpc.nfsd 0;true) < /proc/fs/nfsd/pool_stats Fortunately nfsd_pool_stats_release() has easy access to the svc_serv pointer, and so can call svc_put() on it directly. Fixes: 9f28a971ee9f ("nfsd: separate nfsd_last_thread() from nfsd_put()") Signed-off-by: NeilBrown <neilb@suse.de> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent fdd2630
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 2.3 KB |
Makefile | -rw-r--r-- | 275 bytes |
compat.h | -rw-r--r-- | 811 bytes |
dquot.c | -rw-r--r-- | 79.2 KB |
kqid.c | -rw-r--r-- | 3.2 KB |
netlink.c | -rw-r--r-- | 2.8 KB |
quota.c | -rw-r--r-- | 27.6 KB |
quota_tree.c | -rw-r--r-- | 19.7 KB |
quota_tree.h | -rw-r--r-- | 728 bytes |
quota_v1.c | -rw-r--r-- | 6.6 KB |
quota_v2.c | -rw-r--r-- | 12.6 KB |
quotaio_v1.h | -rw-r--r-- | 1.4 KB |
quotaio_v2.h | -rw-r--r-- | 2.6 KB |
Computing file changes ...