https://github.com/torvalds/linux
Revision 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC, committed by Rafael J. Wysocki on 28 April 2014, 23:22:54 UTC
During frequency transitions, the cpufreq core takes the responsibility of
invoking cpufreq_freq_transition_begin() and cpufreq_freq_transition_end()
for those cpufreq drivers that define the ->target_index callback but don't
set the ASYNC_NOTIFICATION flag.

The powernow-k7 cpufreq driver falls under this category, but this driver was
invoking the _begin() and _end() APIs itself around frequency transitions,
which led to double invocation of the _begin() API. The _begin API makes
contending callers wait until the previous invocation is complete. Hence,
the powernow-k7 driver ended up waiting on itself, leading to system hangs
during boot.

Fix this by removing the calls to the _begin() and _end() APIs from the
powernow-k7 driver, since they rightly belong to the cpufreq core.

Fixes: 12478cf0c55e (cpufreq: Make sure frequency transitions are serialized)
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 3221e55
History
Tip revision: 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC
cpufreq: powernow-k7: Fix double invocation of cpufreq_freq_transition_begin/end
Tip revision: 8997b18
File Mode Size
Kconfig -rw-r--r-- 1.5 KB
Makefile -rw-r--r-- 1022 bytes
byt-rt5640.c -rw-r--r-- 5.1 KB
haswell.c -rw-r--r-- 6.3 KB
mfld_machine.c -rw-r--r-- 11.7 KB
sst-acpi.c -rw-r--r-- 7.6 KB
sst-baytrail-dsp.c -rw-r--r-- 9.4 KB
sst-baytrail-ipc.c -rw-r--r-- 20.3 KB
sst-baytrail-ipc.h -rw-r--r-- 2.5 KB
sst-baytrail-pcm.c -rw-r--r-- 10.8 KB
sst-dsp-priv.h -rw-r--r-- 8.1 KB
sst-dsp.c -rw-r--r-- 9.0 KB
sst-dsp.h -rw-r--r-- 6.6 KB
sst-firmware.c -rw-r--r-- 14.5 KB
sst-haswell-dsp.c -rw-r--r-- 13.4 KB
sst-haswell-ipc.c -rw-r--r-- 43.9 KB
sst-haswell-ipc.h -rw-r--r-- 14.0 KB
sst-haswell-pcm.c -rw-r--r-- 23.1 KB
sst-mfld-dsp.h -rw-r--r-- 3.8 KB
sst-mfld-platform.c -rw-r--r-- 19.0 KB
sst-mfld-platform.h -rw-r--r-- 3.8 KB

back to top