https://github.com/torvalds/linux
Revision 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC, committed by Rafael J. Wysocki on 28 April 2014, 23:22:54 UTC
During frequency transitions, the cpufreq core takes the responsibility of
invoking cpufreq_freq_transition_begin() and cpufreq_freq_transition_end()
for those cpufreq drivers that define the ->target_index callback but don't
set the ASYNC_NOTIFICATION flag.

The powernow-k7 cpufreq driver falls under this category, but this driver was
invoking the _begin() and _end() APIs itself around frequency transitions,
which led to double invocation of the _begin() API. The _begin API makes
contending callers wait until the previous invocation is complete. Hence,
the powernow-k7 driver ended up waiting on itself, leading to system hangs
during boot.

Fix this by removing the calls to the _begin() and _end() APIs from the
powernow-k7 driver, since they rightly belong to the cpufreq core.

Fixes: 12478cf0c55e (cpufreq: Make sure frequency transitions are serialized)
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 3221e55
History
Tip revision: 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC
cpufreq: powernow-k7: Fix double invocation of cpufreq_freq_transition_begin/end
Tip revision: 8997b18
File Mode Size
Kconfig -rw-r--r-- 6.4 KB
Makefile -rw-r--r-- 3.4 KB
ac97.c -rw-r--r-- 12.1 KB
bells.c -rw-r--r-- 11.2 KB
dma.c -rw-r--r-- 11.0 KB
dma.h -rw-r--r-- 1005 bytes
dmaengine.c -rw-r--r-- 2.5 KB
goni_wm8994.c -rw-r--r-- 7.5 KB
h1940_uda1380.c -rw-r--r-- 6.3 KB
i2s-regs.h -rw-r--r-- 4.5 KB
i2s.c -rw-r--r-- 30.8 KB
i2s.h -rw-r--r-- 609 bytes
idma.c -rw-r--r-- 9.7 KB
idma.h -rw-r--r-- 704 bytes
jive_wm8750.c -rw-r--r-- 4.1 KB
littlemill.c -rw-r--r-- 7.9 KB
ln2440sbc_alc650.c -rw-r--r-- 1.7 KB
lowland.c -rw-r--r-- 5.3 KB
neo1973_wm8753.c -rw-r--r-- 10.7 KB
pcm.c -rw-r--r-- 16.3 KB
pcm.h -rw-r--r-- 392 bytes
regs-ac97.h -rw-r--r-- 2.3 KB
regs-i2s-v2.h -rw-r--r-- 4.2 KB
regs-iis.h -rw-r--r-- 2.2 KB
rx1950_uda1380.c -rw-r--r-- 7.0 KB
s3c-i2s-v2.c -rw-r--r-- 17.7 KB
s3c-i2s-v2.h -rw-r--r-- 3.2 KB
s3c2412-i2s.c -rw-r--r-- 5.3 KB
s3c2412-i2s.h -rw-r--r-- 871 bytes
s3c24xx-i2s.c -rw-r--r-- 12.9 KB
s3c24xx-i2s.h -rw-r--r-- 950 bytes
s3c24xx_simtec.c -rw-r--r-- 9.1 KB
s3c24xx_simtec.h -rw-r--r-- 655 bytes
s3c24xx_simtec_hermes.c -rw-r--r-- 3.3 KB
s3c24xx_simtec_tlv320aic23.c -rw-r--r-- 3.0 KB
s3c24xx_uda134x.c -rw-r--r-- 9.0 KB
smartq_wm8987.c -rw-r--r-- 6.7 KB
smdk2443_wm9710.c -rw-r--r-- 1.7 KB
smdk_spdif.c -rw-r--r-- 5.1 KB
smdk_wm8580.c -rw-r--r-- 6.0 KB
smdk_wm8580pcm.c -rw-r--r-- 4.8 KB
smdk_wm8994.c -rw-r--r-- 5.7 KB
smdk_wm8994pcm.c -rw-r--r-- 4.0 KB
smdk_wm9713.c -rw-r--r-- 2.6 KB
spdif.c -rw-r--r-- 12.0 KB
spdif.h -rw-r--r-- 553 bytes
speyside.c -rw-r--r-- 8.7 KB
tobermory.c -rw-r--r-- 5.7 KB

back to top