Skip to main content

Browse the archive

https://github.com/torvalds/linux
27 March 2024, 02:37:15 UTC
Revision 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC, committed by Rafael J. Wysocki on 28 April 2014, 23:22:54 UTC 
cpufreq: powernow-k7: Fix double invocation of cpufreq_freq_transition_begin/end
 
During frequency transitions, the cpufreq core takes the responsibility of
invoking cpufreq_freq_transition_begin() and cpufreq_freq_transition_end()
for those cpufreq drivers that define the ->target_index callback but don't
set the ASYNC_NOTIFICATION flag.

The powernow-k7 cpufreq driver falls under this category, but this driver was
invoking the _begin() and _end() APIs itself around frequency transitions,
which led to double invocation of the _begin() API. The _begin API makes
contending callers wait until the previous invocation is complete. Hence,
the powernow-k7 driver ended up waiting on itself, leading to system hangs
during boot.

Fix this by removing the calls to the _begin() and _end() APIs from the
powernow-k7 driver, since they rightly belong to the cpufreq core.

Fixes: 12478cf0c55e (cpufreq: Make sure frequency transitions are serialized)
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 3221e55
History
Tip revision: 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC
cpufreq: powernow-k7: Fix double invocation of cpufreq_freq_transition_begin/end
Tip revision: 8997b18
File Mode Size
rcar
Kconfig -rw-r--r-- 1.3 KB
Makefile -rw-r--r-- 702 bytes
dma-sh7760.c -rw-r--r-- 9.6 KB
fsi.c -rw-r--r-- 48.6 KB
hac.c -rw-r--r-- 8.0 KB
migor.c -rw-r--r-- 5.1 KB
sh7760-ac97.c -rw-r--r-- 1.6 KB
siu.h -rw-r--r-- 5.6 KB
siu_dai.c -rw-r--r-- 20.7 KB
siu_pcm.c -rw-r--r-- 16.4 KB
ssi.c -rw-r--r-- 10.1 KB
back to top