https://github.com/torvalds/linux
Revision 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC, committed by Rafael J. Wysocki on 28 April 2014, 23:22:54 UTC
During frequency transitions, the cpufreq core takes the responsibility of
invoking cpufreq_freq_transition_begin() and cpufreq_freq_transition_end()
for those cpufreq drivers that define the ->target_index callback but don't
set the ASYNC_NOTIFICATION flag.

The powernow-k7 cpufreq driver falls under this category, but this driver was
invoking the _begin() and _end() APIs itself around frequency transitions,
which led to double invocation of the _begin() API. The _begin API makes
contending callers wait until the previous invocation is complete. Hence,
the powernow-k7 driver ended up waiting on itself, leading to system hangs
during boot.

Fix this by removing the calls to the _begin() and _end() APIs from the
powernow-k7 driver, since they rightly belong to the cpufreq core.

Fixes: 12478cf0c55e (cpufreq: Make sure frequency transitions are serialized)
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 3221e55
History
Tip revision: 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC
cpufreq: powernow-k7: Fix double invocation of cpufreq_freq_transition_begin/end
Tip revision: 8997b18
File Mode Size
6fire
caiaq
hiface
misc
usx2y
Kconfig -rw-r--r-- 4.2 KB
Makefile -rw-r--r-- 529 bytes
card.c -rw-r--r-- 20.2 KB
card.h -rw-r--r-- 6.3 KB
clock.c -rw-r--r-- 11.3 KB
clock.h -rw-r--r-- 339 bytes
debug.h -rw-r--r-- 262 bytes
endpoint.c -rw-r--r-- 30.4 KB
endpoint.h -rw-r--r-- 1.3 KB
format.c -rw-r--r-- 14.2 KB
format.h -rw-r--r-- 292 bytes
helper.c -rw-r--r-- 3.1 KB
helper.h -rw-r--r-- 1.1 KB
midi.c -rw-r--r-- 65.5 KB
midi.h -rw-r--r-- 1.5 KB
mixer.c -rw-r--r-- 66.6 KB
mixer.h -rw-r--r-- 2.0 KB
mixer_maps.c -rw-r--r-- 13.0 KB
mixer_quirks.c -rw-r--r-- 42.8 KB
mixer_quirks.h -rw-r--r-- 367 bytes
pcm.c -rw-r--r-- 44.8 KB
pcm.h -rw-r--r-- 379 bytes
power.h -rw-r--r-- 375 bytes
proc.c -rw-r--r-- 6.0 KB
proc.h -rw-r--r-- 211 bytes
quirks-table.h -rw-r--r-- 75.5 KB
quirks.c -rw-r--r-- 34.6 KB
quirks.h -rw-r--r-- 1.1 KB
stream.c -rw-r--r-- 20.2 KB
stream.h -rw-r--r-- 286 bytes
usbaudio.h -rw-r--r-- 3.3 KB

back to top