Revision - 8997b18 - cpufreq: powernow-k7: Fix double invocation of [...] - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

27 March 2024, 02:37:15 UTC

Revision 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC, committed by Rafael J. Wysocki on 28 April 2014, 23:22:54 UTC

cpufreq: powernow-k7: Fix double invocation of cpufreq_freq_transition_begin/end

During frequency transitions, the cpufreq core takes the responsibility of
invoking cpufreq_freq_transition_begin() and cpufreq_freq_transition_end()
for those cpufreq drivers that define the ->target_index callback but don't
set the ASYNC_NOTIFICATION flag.

The powernow-k7 cpufreq driver falls under this category, but this driver was
invoking the _begin() and _end() APIs itself around frequency transitions,
which led to double invocation of the _begin() API. The _begin API makes
contending callers wait until the previous invocation is complete. Hence,
the powernow-k7 driver ended up waiting on itself, leading to system hangs
during boot.

Fix this by removing the calls to the _begin() and _end() APIs from the
powernow-k7 driver, since they rightly belong to the cpufreq core.

Fixes: 12478cf0c55e (cpufreq: Make sure frequency transitions are serialized)
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

1 parent 3221e55

Files
Changes

Tip revision: 8997b185119966c62c6e95e7b010b4060407e358 authored by Srivatsa S. Bhat on 28 April 2014, 18:54:58 UTC
cpufreq: powernow-k7: Fix double invocation of cpufreq_freq_transition_begin/end

Tip revision: 8997b18

File	Mode	Size
Documentation
arch
block
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.gitignore	-rw-r--r--	1.1 KB
.mailmap	-rw-r--r--	4.4 KB
COPYING	-rw-r--r--	18.3 KB
CREDITS	-rw-r--r--	93.6 KB
Kbuild	-rw-r--r--	2.5 KB
Kconfig	-rw-r--r--	252 bytes
MAINTAINERS	-rw-r--r--	271.4 KB
Makefile	-rw-r--r--	50.5 KB
README	-rw-r--r--	18.3 KB
REPORTING-BUGS	-rw-r--r--	7.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

cpufreq: powernow-k7: Fix double invocation of cpufreq_freq_transition_begin/end

README