Revision 89a70b80ebabd237bb407f9321f24677f4f1d16d authored by Johannes Schindelin on 03 January 2018, 16:54:54 UTC, committed by Junio C Hamano on 03 January 2018, 23:55:50 UTC
When cleaning up files in the $HOME directory, it really makes sense to quote the path, especially in Git's test suite, where the HOME directory is *guaranteed* to contain spaces in its name. It would appear that those two tests pass even without cleaning up the files, but really more by pure chance than by design (the cleanup seems not actually to be necessary). However, if anybody would have a left-over `trash/` directory in Git's `t/` directory, these tests would fail, because they would all of a sudden try to delete that directory, but without the `-r` (recursive) flag. That is how this issue was found. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 567c53d
t9144-git-svn-old-rev_map.sh
#!/bin/sh
#
# Copyright (c) 2009 Eric Wong
test_description='git svn old rev_map preservd'
. ./lib-git-svn.sh
test_expect_success 'setup test repository with old layout' '
mkdir i &&
(cd i && > a) &&
svn_cmd import -m- i "$svnrepo" &&
git svn init "$svnrepo" &&
git svn fetch &&
test -d .git/svn/refs/remotes/git-svn/ &&
! test -e .git/svn/git-svn/ &&
mv .git/svn/refs/remotes/git-svn .git/svn/ &&
rm -r .git/svn/refs
'
test_expect_success 'old layout continues to work' '
svn_cmd import -m- i "$svnrepo/b" &&
git svn rebase &&
echo a >> b/a &&
git add b/a &&
git commit -m- -a &&
git svn dcommit &&
! test -d .git/svn/refs/ &&
test -e .git/svn/git-svn/
'
test_done
Computing file changes ...
