Revision 89cc23c09ec31bba50521495d6e352204feec72f authored by David Bimmler on 19 March 2024, 08:48:32 UTC, committed by Jussi Mäki on 05 April 2024, 12:00:13 UTC
[ upstream commit 58ad35a84faab45fa0dab5f0078287f4cceb3926 ]

The endpointmanagers idallocator package was using a package global pool
for its identifier allocation. That's fine for running the agent, but
causes flakes in testing when multiple tests access the same pool. It's
also not idiomatic Go.

This patch makes the local endpoint identifier allocator a struct, and
the next patch will move it into the endpointmanager package itself, as
there is no other consumer.

While at it, also ensure that the RemoveAll method is only called from a
testing context, by taking a testing.TB as an argument. We cannot simply
move the method into the _test.go files, as tests from other packages
use it.

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
1 parent fdfbb25
History
File Mode Size
.github
.nvim
.vscode
Documentation
api
bpf
bugtool
cilium
cilium-health
clustermesh-apiserver
contrib
daemon
envoy
examples
hack
hubble-relay
images
install
jenkinsfiles
operator
pkg
plugins
test
tools
vendor
.authors.aux -rw-r--r-- 416 bytes
.clomonitor.yml -rw-r--r-- 984 bytes
.gitattributes -rw-r--r-- 689 bytes
.gitignore -rw-r--r-- 1.7 KB
.golangci.yaml -rw-r--r-- 3.1 KB
.mailmap -rw-r--r-- 5.9 KB
AUTHORS -rw-r--r-- 38.5 KB
CHANGELOG.md -rw-r--r-- 208.5 KB
CODEOWNERS -rw-r--r-- 11.6 KB
CODE_OF_CONDUCT.md -rw-r--r-- 2.2 KB
CONTRIBUTING.md -rw-r--r-- 473 bytes
FURTHER_READINGS.rst -rw-r--r-- 6.4 KB
LICENSE -rw-r--r-- 11.1 KB
MAINTAINERS.md -rw-r--r-- 4.3 KB
Makefile -rw-r--r-- 28.2 KB
Makefile.defs -rw-r--r-- 6.5 KB
Makefile.docker -rw-r--r-- 6.9 KB
Makefile.quiet -rw-r--r-- 818 bytes
README.rst -rw-r--r-- 17.4 KB
SECURITY.md -rw-r--r-- 629 bytes
USERS.md -rw-r--r-- 24.5 KB
VERSION -rw-r--r-- 8 bytes
Vagrantfile -rw-r--r-- 14.7 KB
go.mod -rw-r--r-- 12.0 KB
go.sum -rw-r--r-- 155.4 KB
netlify.toml -rw-r--r-- 92 bytes
vagrant_box_defaults.rb -rw-r--r-- 394 bytes

README.rst

back to top