Revision - 89d59a9 - optimize: Delete incoming unreachable edges from PhiNode (#53877) - origin: https://github.com/JuliaLang/julia

visit type:

https://github.com/JuliaLang/julia

19 April 2024, 06:28:37 UTC

Revision 89d59a91790b8fe6155c8cca16ac801e0bd4c863 authored by Keno Fischer on 28 March 2024, 17:59:05 UTC, committed by GitHub on 28 March 2024, 17:59:05 UTC

optimize: Delete incoming unreachable edges from PhiNode (#53877)

Incoming IR very rarely contains PhiNodes, but we do allow it to make
things easier on downstream packages like Diffractor that want to
generate the same code structures in both typed and untyped mode.
However, this does of course mean that once inference is finished, any
PhiNodes in the original source must be adjusted to maintain IRCode
invariants. One particular important invariant here is that the edges
list in a PhiNode must match the predecessor list, so in particular if a
predecessor becomes unreachable during inference, we must filter that
edge before passing it on to the optimizer.

---------

Co-authored-by: Shuhei Kadowaki <aviatesk@gmail.com>

1 parent 6f51966

Files
Changes

Permalinks

Tip revision: 89d59a91790b8fe6155c8cca16ac801e0bd4c863 authored by Keno Fischer on 28 March 2024, 17:59:05 UTC
optimize: Delete incoming unreachable edges from PhiNode (#53877)

Tip revision: 89d59a9

File	Mode	Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version	-rw-r--r--	5 bytes
.clang-format	-rw-r--r--	3.3 KB
.clangd	-rw-r--r--	114 bytes
.codecov.yml	-rw-r--r--	52 bytes
.git-blame-ignore-revs	-rw-r--r--	371 bytes
.gitattributes	-rw-r--r--	65 bytes
.gitignore	-rw-r--r--	571 bytes
.mailmap	-rw-r--r--	12.7 KB
CITATION.bib	-rw-r--r--	513 bytes
CITATION.cff	-rw-r--r--	1012 bytes
CONTRIBUTING.md	-rw-r--r--	23.4 KB
HISTORY.md	-rw-r--r--	388.1 KB
LICENSE.md	-rw-r--r--	1.3 KB
Make.inc	-rw-r--r--	56.0 KB
Makefile	-rw-r--r--	30.3 KB
NEWS.md	-rw-r--r--	4.4 KB
README.md	-rw-r--r--	7.4 KB
THIRDPARTY.md	-rw-r--r--	3.9 KB
VERSION	-rw-r--r--	11 bytes
julia.spdx.json	-rw-r--r--	37.8 KB
pkgimage.mk	-rw-r--r--	1.4 KB
sysimage.mk	-rw-r--r--	4.2 KB
typos.toml	-rw-r--r--	78 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/JuliaLang/julia

optimize: Delete incoming unreachable edges from PhiNode (#53877)

README.md