https://github.com/torvalds/linux
Revision 8ad8e02c2fa70cfddc1ded53ba9001c9d444075d authored by Jan Kaisrlik on 20 August 2019, 11:42:29 UTC, committed by Ulf Hansson on 03 September 2019, 14:53:28 UTC
Turns out the commit 3a0681c7448b ("mmc: core: do not retry CMD6 in __mmc_switch()") breaks initialization of a Toshiba THGBMNG5 eMMC card, when using the meson-gx-mmc.c driver on a custom board based on Amlogic A113D. The CMD6 that switches the card into HS200 mode is then one that fails and according to the below printed messages from the log: [ 1.648951] mmc0: mmc_select_hs200 failed, error -84 [ 1.648988] mmc0: error -84 whilst initialising MMC card After some analyze, it turns out that adding a delay of ~5ms inside mmc_select_bus_width() but after mmc_compare_ext_csds() has been executed, also fixes the problem. Adding yet some more debug code, trying to figure out if potentially the card could be in a busy state, both by using CMD13 and ->card_busy() ops concluded that this was not the case. Therefore, let's simply revert the commit that dropped support for retrying of CMD6, as this also fixes the problem. Fixes: 3a0681c7448b ("mmc: core: do not retry CMD6 in __mmc_switch()") Cc: stable@vger.kernel.org Signed-off-by: Jan Kaisrlik <ja.kaisrlik@gmail.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 089cf7f
Tip revision: 8ad8e02c2fa70cfddc1ded53ba9001c9d444075d authored by Jan Kaisrlik on 20 August 2019, 11:42:29 UTC
Revert "mmc: core: do not retry CMD6 in __mmc_switch()"
Revert "mmc: core: do not retry CMD6 in __mmc_switch()"
Tip revision: 8ad8e02
Computing file changes ...