https://github.com/torvalds/linux
Revision 8b13b4e0bc884ba7dc8ee4de3ee915b7d30e7f78 authored by Govindarajulu Varadarajan on 11 June 2015, 06:22:56 UTC, committed by David S. Miller on 11 June 2015, 06:42:39 UTC
When incoming packet qualifies for rx_copybreak, we copy the data to newly allocated skb. We do not free/unmap the original buffer. At this point driver assumes this buffer is unallocated. When enic_rq_alloc_buf() is called for buffer allocation, it checks if buf->os_buf is NULL. If its not NULL that means buffer can be re-used. When vnic_rq_clean() is called for freeing all rq buffers, and if the rx_copybreak reused buffer falls outside the used desc, we do not free the buffer. The following trace is observer when dma-debug is enabled. Fix is to walk through complete ring and clean if buffer is present. [ 40.555386] ------------[ cut here ]------------ [ 40.555396] WARNING: CPU: 0 PID: 491 at lib/dma-debug.c:971 dma_debug_device_change+0x188/0x1f0() [ 40.555400] pci 0000:06:00.0: DMA-API: device driver has pending DMA allocations while released from device [count=4] One of leaked entries details: [device address=0x00000000ff4cc040] [size=9018 bytes] [mapped with DMA_FROM_DEVICE] [mapped as single] [ 40.555402] Modules linked in: nfsv3 nfs_acl rpcsec_gss_krb5 auth_rpcgss oid_registry nfsv4 dns_resolver coretemp intel_rapl iosf_mbi x86_pkg_temp_thermal intel_powerclamp kvm_intel kvm crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel aes_x86_64 lrw joydev mousedev gf128mul hid_generic glue_helper mgag200 usbhid ttm hid drm_kms_helper drm ablk_helper syscopyarea sysfillrect sysimgblt i2c_algo_bit i2c_core iTCO_wdt cryptd mac_hid evdev pcspkr sb_edac edac_core tpm_tis iTCO_vendor_support ipmi_si wmi tpm ipmi_msghandler shpchp lpc_ich processor acpi_power_meter hwmon button ac sch_fq_codel nfs lockd grace sunrpc fscache sd_mod ehci_pci ehci_hcd megaraid_sas usbcore scsi_mod usb_common enic(-) crc32c_generic crc32c_intel btrfs xor raid6_pq ext4 crc16 mbcache jbd2 [ 40.555467] CPU: 0 PID: 491 Comm: rmmod Not tainted 4.1.0-rc7-ARCH-01305-gf59b71f #118 [ 40.555469] Hardware name: Cisco Systems Inc UCSB-B200-M4/UCSB-B200-M4, BIOS B200M4.2.2.2.23.061220140128 06/12/2014 [ 40.555471] 0000000000000000 00000000e2f8a5b7 ffff880275f8bc48 ffffffff8158d6f0 [ 40.555474] 0000000000000000 ffff880275f8bca0 ffff880275f8bc88 ffffffff8107b04a [ 40.555477] ffff8802734e0000 0000000000000004 ffff8804763fb3c0 ffff88027600b650 [ 40.555480] Call Trace: [ 40.555488] [<ffffffff8158d6f0>] dump_stack+0x4f/0x7b [ 40.555492] [<ffffffff8107b04a>] warn_slowpath_common+0x8a/0xc0 [ 40.555494] [<ffffffff8107b0d5>] warn_slowpath_fmt+0x55/0x70 [ 40.555498] [<ffffffff812fa408>] dma_debug_device_change+0x188/0x1f0 [ 40.555503] [<ffffffff8109aaef>] notifier_call_chain+0x4f/0x80 [ 40.555506] [<ffffffff8109aecb>] __blocking_notifier_call_chain+0x4b/0x70 [ 40.555510] [<ffffffff8109af06>] blocking_notifier_call_chain+0x16/0x20 [ 40.555514] [<ffffffff813f8066>] __device_release_driver+0xf6/0x120 [ 40.555518] [<ffffffff813f8b08>] driver_detach+0xc8/0xd0 [ 40.555523] [<ffffffff813f7c59>] bus_remove_driver+0x59/0xe0 [ 40.555527] [<ffffffff813f93a0>] driver_unregister+0x30/0x70 [ 40.555534] [<ffffffff8131532d>] pci_unregister_driver+0x2d/0xa0 [ 40.555542] [<ffffffffa0200ec2>] enic_cleanup_module+0x10/0x14e [enic] [ 40.555547] [<ffffffff8110158f>] SyS_delete_module+0x1cf/0x280 [ 40.555551] [<ffffffff811e284e>] ? ____fput+0xe/0x10 [ 40.555554] [<ffffffff810980ec>] ? task_work_run+0xbc/0xf0 [ 40.555558] [<ffffffff815930ee>] system_call_fastpath+0x12/0x71 [ 40.555561] ---[ end trace 4988cadc77c2b236 ]--- [ 40.555562] Mapped at: [ 40.555563] [<ffffffff812fa865>] debug_dma_map_page+0x95/0x150 [ 40.555566] [<ffffffffa01f4a88>] enic_rq_alloc_buf+0x1b8/0x360 [enic] [ 40.555570] [<ffffffffa01f7658>] enic_open+0xf8/0x820 [enic] [ 40.555574] [<ffffffff8148d50e>] __dev_open+0xce/0x150 [ 40.555579] [<ffffffff8148d851>] __dev_change_flags+0xa1/0x170 Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 19b596b
Tip revision: 8b13b4e0bc884ba7dc8ee4de3ee915b7d30e7f78 authored by Govindarajulu Varadarajan on 11 June 2015, 06:22:56 UTC
enic: fix memory leak in rq_clean
enic: fix memory leak in rq_clean
Tip revision: 8b13b4e
File | Mode | Size |
---|---|---|
9p | ||
adfs | ||
affs | ||
afs | ||
autofs4 | ||
befs | ||
bfs | ||
btrfs | ||
cachefiles | ||
ceph | ||
cifs | ||
coda | ||
configfs | ||
cramfs | ||
debugfs | ||
devpts | ||
dlm | ||
ecryptfs | ||
efivarfs | ||
efs | ||
exofs | ||
exportfs | ||
ext2 | ||
ext3 | ||
ext4 | ||
f2fs | ||
fat | ||
freevxfs | ||
fscache | ||
fuse | ||
gfs2 | ||
hfs | ||
hfsplus | ||
hostfs | ||
hpfs | ||
hppfs | ||
hugetlbfs | ||
isofs | ||
jbd | ||
jbd2 | ||
jffs2 | ||
jfs | ||
kernfs | ||
lockd | ||
logfs | ||
minix | ||
ncpfs | ||
nfs | ||
nfs_common | ||
nfsd | ||
nilfs2 | ||
nls | ||
notify | ||
ntfs | ||
ocfs2 | ||
omfs | ||
openpromfs | ||
overlayfs | ||
proc | ||
pstore | ||
qnx4 | ||
qnx6 | ||
quota | ||
ramfs | ||
reiserfs | ||
romfs | ||
squashfs | ||
sysfs | ||
sysv | ||
tracefs | ||
ubifs | ||
udf | ||
ufs | ||
xfs | ||
Kconfig | -rw-r--r-- | 6.5 KB |
Kconfig.binfmt | -rw-r--r-- | 7.0 KB |
Makefile | -rw-r--r-- | 4.1 KB |
aio.c | -rw-r--r-- | 42.8 KB |
anon_inodes.c | -rw-r--r-- | 4.9 KB |
attr.c | -rw-r--r-- | 7.9 KB |
bad_inode.c | -rw-r--r-- | 4.7 KB |
binfmt_aout.c | -rw-r--r-- | 10.8 KB |
binfmt_elf.c | -rw-r--r-- | 60.4 KB |
binfmt_elf_fdpic.c | -rw-r--r-- | 46.9 KB |
binfmt_em86.c | -rw-r--r-- | 2.8 KB |
binfmt_flat.c | -rw-r--r-- | 26.4 KB |
binfmt_misc.c | -rw-r--r-- | 17.5 KB |
binfmt_script.c | -rw-r--r-- | 3.0 KB |
block_dev.c | -rw-r--r-- | 45.1 KB |
buffer.c | -rw-r--r-- | 88.8 KB |
char_dev.c | -rw-r--r-- | 13.3 KB |
compat.c | -rw-r--r-- | 37.2 KB |
compat_binfmt_elf.c | -rw-r--r-- | 3.7 KB |
compat_ioctl.c | -rw-r--r-- | 45.5 KB |
coredump.c | -rw-r--r-- | 18.1 KB |
dax.c | -rw-r--r-- | 15.0 KB |
dcache.c | -rw-r--r-- | 89.6 KB |
dcookies.c | -rw-r--r-- | 6.9 KB |
direct-io.c | -rw-r--r-- | 37.8 KB |
drop_caches.c | -rw-r--r-- | 1.6 KB |
eventfd.c | -rw-r--r-- | 11.2 KB |
eventpoll.c | -rw-r--r-- | 59.0 KB |
exec.c | -rw-r--r-- | 40.6 KB |
fcntl.c | -rw-r--r-- | 16.6 KB |
fhandle.c | -rw-r--r-- | 6.5 KB |
file.c | -rw-r--r-- | 21.5 KB |
file_table.c | -rw-r--r-- | 8.4 KB |
filesystems.c | -rw-r--r-- | 6.4 KB |
fs-writeback.c | -rw-r--r-- | 44.1 KB |
fs_pin.c | -rw-r--r-- | 2.0 KB |
fs_struct.c | -rw-r--r-- | 3.3 KB |
inode.c | -rw-r--r-- | 51.7 KB |
internal.h | -rw-r--r-- | 3.5 KB |
ioctl.c | -rw-r--r-- | 15.7 KB |
libfs.c | -rw-r--r-- | 27.9 KB |
locks.c | -rw-r--r-- | 69.5 KB |
mbcache.c | -rw-r--r-- | 24.1 KB |
mount.h | -rw-r--r-- | 3.5 KB |
mpage.c | -rw-r--r-- | 19.9 KB |
namei.c | -rw-r--r-- | 112.7 KB |
namespace.c | -rw-r--r-- | 79.4 KB |
no-block.c | -rw-r--r-- | 688 bytes |
nsfs.c | -rw-r--r-- | 3.4 KB |
open.c | -rw-r--r-- | 26.6 KB |
pipe.c | -rw-r--r-- | 25.0 KB |
pnode.c | -rw-r--r-- | 11.2 KB |
pnode.h | -rw-r--r-- | 1.9 KB |
posix_acl.c | -rw-r--r-- | 19.9 KB |
proc_namespace.c | -rw-r--r-- | 7.8 KB |
read_write.c | -rw-r--r-- | 28.9 KB |
readdir.c | -rw-r--r-- | 6.9 KB |
select.c | -rw-r--r-- | 25.4 KB |
seq_file.c | -rw-r--r-- | 21.1 KB |
signalfd.c | -rw-r--r-- | 9.1 KB |
splice.c | -rw-r--r-- | 46.1 KB |
stack.c | -rw-r--r-- | 2.5 KB |
stat.c | -rw-r--r-- | 12.0 KB |
statfs.c | -rw-r--r-- | 5.3 KB |
super.c | -rw-r--r-- | 35.4 KB |
sync.c | -rw-r--r-- | 9.7 KB |
timerfd.c | -rw-r--r-- | 13.0 KB |
utimes.c | -rw-r--r-- | 5.9 KB |
xattr.c | -rw-r--r-- | 22.8 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...