Revision 8bc086899816214fbc6047c9c7e15fcab49552bf authored by Ben Hutchings on 17 March 2019, 01:17:56 UTC, committed by Michael Ellerman on 20 March 2019, 13:16:45 UTC
MAX_PHYSMEM_BITS only needs to be defined if CONFIG_SPARSEMEM is
enabled, and that was the case before commit 4ffe713b7587
("powerpc/mm: Increase the max addressable memory to 2PB").

On 32-bit systems, where CONFIG_SPARSEMEM is not enabled, we now
define it as 46.  That is larger than the real number of physical
address bits, and breaks calculations in zsmalloc:

  mm/zsmalloc.c:130:49: warning: right shift count is negative
    MAX(32, (ZS_MAX_PAGES_PER_ZSPAGE << PAGE_SHIFT >> OBJ_INDEX_BITS))
                                                   ^~
  ...
  mm/zsmalloc.c:253:21: error: variably modified 'size_class' at file scope
    struct size_class *size_class[ZS_SIZE_CLASSES];
                       ^~~~~~~~~~

Fixes: 4ffe713b7587 ("powerpc/mm: Increase the max addressable memory to 2PB")
Cc: stable@vger.kernel.org # v4.20+
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
1 parent 4622a2d
History
File Mode Size
Kconfig -rw-r--r-- 1.4 KB
Makefile -rw-r--r-- 486 bytes
acl.c -rw-r--r-- 3.8 KB
file.c -rw-r--r-- 4.3 KB
inode.c -rw-r--r-- 10.1 KB
ioctl.c -rw-r--r-- 3.9 KB
jfs_acl.h -rw-r--r-- 1.2 KB
jfs_btree.h -rw-r--r-- 4.0 KB
jfs_debug.c -rw-r--r-- 2.5 KB
jfs_debug.h -rw-r--r-- 3.3 KB
jfs_dinode.h -rw-r--r-- 5.8 KB
jfs_discard.c -rw-r--r-- 3.1 KB
jfs_discard.h -rw-r--r-- 1.0 KB
jfs_dmap.c -rw-r--r-- 111.6 KB
jfs_dmap.h -rw-r--r-- 11.2 KB
jfs_dtree.c -rw-r--r-- 100.5 KB
jfs_dtree.h -rw-r--r-- 6.6 KB
jfs_extent.c -rw-r--r-- 17.3 KB
jfs_extent.h -rw-r--r-- 1.3 KB
jfs_filsys.h -rw-r--r-- 8.9 KB
jfs_imap.c -rw-r--r-- 83.8 KB
jfs_imap.h -rw-r--r-- 6.4 KB
jfs_incore.h -rw-r--r-- 7.5 KB
jfs_inode.c -rw-r--r-- 3.5 KB
jfs_inode.h -rw-r--r-- 2.5 KB
jfs_lock.h -rw-r--r-- 1.5 KB
jfs_logmgr.c -rw-r--r-- 58.9 KB
jfs_logmgr.h -rw-r--r-- 14.7 KB
jfs_metapage.c -rw-r--r-- 19.2 KB
jfs_metapage.h -rw-r--r-- 4.2 KB
jfs_mount.c -rw-r--r-- 12.7 KB
jfs_superblock.h -rw-r--r-- 4.1 KB
jfs_txnmgr.c -rw-r--r-- 74.6 KB
jfs_txnmgr.h -rw-r--r-- 8.2 KB
jfs_types.h -rw-r--r-- 4.3 KB
jfs_umount.c -rw-r--r-- 4.0 KB
jfs_unicode.c -rw-r--r-- 3.3 KB
jfs_unicode.h -rw-r--r-- 3.7 KB
jfs_uniupr.c -rw-r--r-- 7.5 KB
jfs_xattr.h -rw-r--r-- 2.5 KB
jfs_xtree.c -rw-r--r-- 91.8 KB
jfs_xtree.h -rw-r--r-- 3.8 KB
namei.c -rw-r--r-- 37.1 KB
resize.c -rw-r--r-- 14.8 KB
super.c -rw-r--r-- 24.7 KB
symlink.c -rw-r--r-- 1.2 KB
xattr.c -rw-r--r-- 25.8 KB

back to top