Revision 8bc086899816214fbc6047c9c7e15fcab49552bf authored by Ben Hutchings on 17 March 2019, 01:17:56 UTC, committed by Michael Ellerman on 20 March 2019, 13:16:45 UTC
MAX_PHYSMEM_BITS only needs to be defined if CONFIG_SPARSEMEM is
enabled, and that was the case before commit 4ffe713b7587
("powerpc/mm: Increase the max addressable memory to 2PB").

On 32-bit systems, where CONFIG_SPARSEMEM is not enabled, we now
define it as 46.  That is larger than the real number of physical
address bits, and breaks calculations in zsmalloc:

  mm/zsmalloc.c:130:49: warning: right shift count is negative
    MAX(32, (ZS_MAX_PAGES_PER_ZSPAGE << PAGE_SHIFT >> OBJ_INDEX_BITS))
                                                   ^~
  ...
  mm/zsmalloc.c:253:21: error: variably modified 'size_class' at file scope
    struct size_class *size_class[ZS_SIZE_CLASSES];
                       ^~~~~~~~~~

Fixes: 4ffe713b7587 ("powerpc/mm: Increase the max addressable memory to 2PB")
Cc: stable@vger.kernel.org # v4.20+
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
1 parent 4622a2d
History
File Mode Size
include
.gitignore -rw-r--r-- 74 bytes
Kconfig -rw-r--r-- 2.2 KB
Makefile -rw-r--r-- 4.1 KB
apparmorfs.c -rw-r--r-- 62.9 KB
audit.c -rw-r--r-- 5.5 KB
capability.c -rw-r--r-- 4.2 KB
crypto.c -rw-r--r-- 2.5 KB
domain.c -rw-r--r-- 38.9 KB
file.c -rw-r--r-- 19.4 KB
ipc.c -rw-r--r-- 6.2 KB
label.c -rw-r--r-- 50.6 KB
lib.c -rw-r--r-- 13.1 KB
lsm.c -rw-r--r-- 44.3 KB
match.c -rw-r--r-- 18.6 KB
mount.c -rw-r--r-- 17.8 KB
net.c -rw-r--r-- 5.6 KB
nulldfa.in -rw-r--r-- 6.8 KB
path.c -rw-r--r-- 6.2 KB
policy.c -rw-r--r-- 31.7 KB
policy_ns.c -rw-r--r-- 9.9 KB
policy_unpack.c -rw-r--r-- 26.2 KB
procattr.c -rw-r--r-- 3.7 KB
resource.c -rw-r--r-- 5.2 KB
secid.c -rw-r--r-- 3.6 KB
stacksplitdfa.in -rw-r--r-- 7.3 KB
task.c -rw-r--r-- 4.3 KB

back to top