https://github.com/torvalds/linux
Revision 8e5654ce6914b950b42d1f896f3d8a75fbf307ae authored by Jiri Kosina on 09 August 2013, 09:34:19 UTC, committed by Jiri Kosina on 09 August 2013, 09:34:19 UTC
This reverts commit 407a2c2a4d85100c8c67953e4bac2f4a6c942335.

Explanation provided by Benjamin Tissoires:

Commit "HID: hid-logitech-dj, querying_devices was never set" activate
a flag which guarantees that we do not ask the receiver for too many
enumeration. When the flag is set, each following enumeration call is
discarded (the usb request is not forwarded to the receiver). The flag
is then released when the driver receive a pairing information event,
which normally follows the enumeration request.
However, the USB3 bug makes the driver think the enumeration request
has been forwarded to the receiver. However, it is actually not the
case because the USB stack returns -EPIPE. So, when a new unknown
device appears, the workaround consisting in asking for a new
enumeration is not working anymore: this new enumeration is discarded
because of the flag, which is never reset.

A solution could be to trigger a timeout before releasing it, but for
now, let's just revert the patch.

Reported-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Tested-by: Sune Mølgaard <sune@molgaard.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent f9ed432
History
Tip revision: 8e5654ce6914b950b42d1f896f3d8a75fbf307ae authored by Jiri Kosina on 09 August 2013, 09:34:19 UTC
Revert "HID: hid-logitech-dj: querying_devices was never set"
Tip revision: 8e5654c
File Mode Size
9p
adfs
affs
afs
autofs4
befs
bfs
btrfs
cachefiles
ceph
cifs
coda
configfs
cramfs
debugfs
devpts
dlm
ecryptfs
efivarfs
efs
exofs
exportfs
ext2
ext3
ext4
f2fs
fat
freevxfs
fscache
fuse
gfs2
hfs
hfsplus
hostfs
hpfs
hppfs
hugetlbfs
isofs
jbd
jbd2
jffs2
jfs
lockd
logfs
minix
ncpfs
nfs
nfs_common
nfsd
nilfs2
nls
notify
ntfs
ocfs2
omfs
openpromfs
proc
pstore
qnx4
qnx6
quota
ramfs
reiserfs
romfs
squashfs
sysfs
sysv
ubifs
udf
ufs
xfs
Kconfig -rw-r--r-- 6.0 KB
Kconfig.binfmt -rw-r--r-- 7.2 KB
Makefile -rw-r--r-- 4.2 KB
aio.c -rw-r--r-- 32.7 KB
anon_inodes.c -rw-r--r-- 6.4 KB
attr.c -rw-r--r-- 7.0 KB
bad_inode.c -rw-r--r-- 7.7 KB
binfmt_aout.c -rw-r--r-- 11.2 KB
binfmt_elf.c -rw-r--r-- 57.8 KB
binfmt_elf_fdpic.c -rw-r--r-- 48.5 KB
binfmt_em86.c -rw-r--r-- 2.7 KB
binfmt_flat.c -rw-r--r-- 26.4 KB
binfmt_misc.c -rw-r--r-- 14.8 KB
binfmt_script.c -rw-r--r-- 2.7 KB
binfmt_som.c -rw-r--r-- 7.1 KB
bio-integrity.c -rw-r--r-- 19.9 KB
bio.c -rw-r--r-- 47.6 KB
block_dev.c -rw-r--r-- 42.0 KB
buffer.c -rw-r--r-- 88.4 KB
char_dev.c -rw-r--r-- 14.0 KB
compat.c -rw-r--r-- 36.7 KB
compat_binfmt_elf.c -rw-r--r-- 3.6 KB
compat_ioctl.c -rw-r--r-- 45.4 KB
coredump.c -rw-r--r-- 17.4 KB
coredump.h -rw-r--r-- 106 bytes
dcache.c -rw-r--r-- 78.2 KB
dcookies.c -rw-r--r-- 6.9 KB
direct-io.c -rw-r--r-- 37.3 KB
drop_caches.c -rw-r--r-- 1.5 KB
eventfd.c -rw-r--r-- 11.3 KB
eventpoll.c -rw-r--r-- 57.6 KB
exec.c -rw-r--r-- 39.2 KB
fcntl.c -rw-r--r-- 16.3 KB
fhandle.c -rw-r--r-- 6.5 KB
file.c -rw-r--r-- 21.9 KB
file_table.c -rw-r--r-- 12.3 KB
filesystems.c -rw-r--r-- 6.4 KB
fs-writeback.c -rw-r--r-- 39.1 KB
fs_struct.c -rw-r--r-- 3.3 KB
generic_acl.c -rw-r--r-- 3.9 KB
inode.c -rw-r--r-- 48.6 KB
internal.h -rw-r--r-- 3.4 KB
ioctl.c -rw-r--r-- 15.5 KB
ioprio.c -rw-r--r-- 5.0 KB
libfs.c -rw-r--r-- 25.3 KB
locks.c -rw-r--r-- 63.7 KB
mbcache.c -rw-r--r-- 16.4 KB
mount.h -rw-r--r-- 2.5 KB
mpage.c -rw-r--r-- 20.0 KB
namei.c -rw-r--r-- 101.3 KB
namespace.c -rw-r--r-- 69.7 KB
no-block.c -rw-r--r-- 688 bytes
open.c -rw-r--r-- 24.8 KB
pipe.c -rw-r--r-- 29.2 KB
pnode.c -rw-r--r-- 9.0 KB
pnode.h -rw-r--r-- 1.4 KB
posix_acl.c -rw-r--r-- 9.2 KB
proc_namespace.c -rw-r--r-- 7.5 KB
read_write.c -rw-r--r-- 27.7 KB
readdir.c -rw-r--r-- 6.8 KB
select.c -rw-r--r-- 25.4 KB
seq_file.c -rw-r--r-- 21.3 KB
signalfd.c -rw-r--r-- 9.1 KB
splice.c -rw-r--r-- 47.3 KB
stack.c -rw-r--r-- 2.5 KB
stat.c -rw-r--r-- 11.3 KB
statfs.c -rw-r--r-- 5.3 KB
super.c -rw-r--r-- 34.6 KB
sync.c -rw-r--r-- 10.0 KB
timerfd.c -rw-r--r-- 11.4 KB
utimes.c -rw-r--r-- 5.7 KB
xattr.c -rw-r--r-- 23.5 KB
xattr_acl.c -rw-r--r-- 4.3 KB

back to top