Revision 8efbb7197edf027decaf02447430da8f533c5507 authored by Tam Mach on 06 June 2024, 05:43:36 UTC, committed by Tam Mach on 13 June 2024, 04:03:39 UTC
This is to avoid any unnecessary reconciliation for non-GAMMA HTTPRoute:
- Explicitly check if Kind and Group are not nil, as per the Gateway API
spec, the nil values is meant for Gateway.
- Add GAMMA check for backend services and listening service.
Additionally, one small correction on Reason status is added to make
sure that the space character is not used.
```
2024-06-06T05:34:31.583996151Z time="2024-06-06T05:34:31Z" level=error msg="Reconciler error" HTTPRoute="{attaches-to-wildcard-example-com-with-hostname-intersection gateway-conformance-infra}" controller=httproute controllerGroup=gateway.networking.k8s.io controllerKind=HTTPRoute error="failed to update HTTPRoute status: HTTPRoute.gateway.networking.k8s.io \"attaches-to-wildcard-example-com-with-hostname-intersection\" is invalid: parents[0].conditions[0].reason: Invalid value: \"Invalid HTTPRoute\": parents[0].conditions[0].reason in body should match '^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$'" name=attaches-to-wildcard-example-com-with-hostname-intersection namespace=gateway-conformance-infra reconcileID="\"2c43d9eb-52ad-4344-b0ff-e58c227221fb\"" subsys=controller-runtime
```
Relates: 363fdd4ff951e02ebf666b1dccf17d0dfb5a0f47
Signed-off-by: Tam Mach <tam.mach@cilium.io>
1 parent 4d6bee1
.gitignore
# Compiled Object files, Static and Dynamic libs (Shared Objects)
*.o
*.a
*.so
*.so.*
*.d
# LLVM IR files
*.ll
*.ll-*
# Folders
_obj
_test
_build/
# Architecture specific extensions/prefixes
*.cgo1.go
*.cgo2.c
_cgo_defun.c
_cgo_gotypes.go
_cgo_export.*
_testmain.go
*.exe
*.test
*.prof
*.swn
*.swp
.vagrant
vagrant.kubeconfig
coverage.out
coverage-all.out
coverage-all.html
coverage-all-tmp.out
bpf-coverage.html
bpf-coverage.cover
.DS_Store
.idea/
.vscode/*
!.vscode/launch.json
!.vscode/extensions.json
*.plist
*_bash_completion
*.swo
outgoing
*cscope.files
*cscope.out
*cscope.in.out
*cscope.po.out
*tags
.gdb_history
compile_commands.json
man/
test/envoy/cilium-files
test/test_results*
test/.vagrant
test/tmp.yaml
test/*_manifest.yaml
test/*.xml
test/*.json
test/*.log
test/bpf/_results
test/cilium-[0-9a-f]*.yaml
test/*tmp
test/cilium-istioctl
# Updates E2E Test
old-charts/
# generated test files
test/k8s/manifests/cnp-second-namespaces.yaml
test/cilium.conf.ginkgo
external-workload-ca.crt
external-workload-tls.crt
external-workload-tls.key
# GKE temporary files
test/gke/cluster-name
test/gke/cluster-uri
test/gke/cluster-version
test/gke/gke-kubeconfig
test/gke/resize-kubeconfig
test/gke/registry-adder.yaml
# Emacs backup files
*~
# generated from make targets
*.ok
*.build_all
LICENSE.all
# Temporary files that allow build containers/VMs work without git
# Not to be ignored by docker.
GIT_VERSION
# The following files get created during image builds
.buildx
.buildx_builder
# Local developer config to be executed in the dev VM and CI VMs started locally
.devvmrc
# Generated dockerignore files
images/*/Dockerfile.dockerignore
# Local Emacs files
.dir-locals.el
# Clangd cache for indexed bpf code
bpf/.cache
.cache
# Include dummy bpf object necessary for XDP_TX
!test/l4lb/bpf_xdp_veth_host.o
# Files used for direnv
.direnv
.envrc
Computing file changes ...
