Revision - 8efbdb5 - fix(zone.js): patch global instead of Mocha object (#45047) - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

07 August 2024, 03:31:07 UTC

Revision 8efbdb57c11a6c632f69d7e142a632b6a853fa46 authored by JiaLiPassion on 11 February 2022, 04:31:54 UTC, committed by Alex Rickabaugh on 16 February 2022, 21:51:51 UTC

fix(zone.js): patch global instead of Mocha object (#45047)

Close #42834

In the new version fo Mocha, all global test functions are from `global`
object instead of `Mocha` object. Adn the current `zone.js` Mocha
patch's logic looks like this.

```
global.describe = Mocha.describe = function() {
  return originalMochaDescribe.apply(this, arguments);
}
```

and `originalMochaDescribe` is the unpathced Mocha implementation
looks like this

```
function describe() {
  return context.describe(...);
}
```

And the `context` will finally delegate to `global.describe()`,
so the current `zone.js` patch causes infinite loop.

This commit will not patch function of `Mocha` object any longer.

PR Close #45047

1 parent 6769f94

Files
Changes

Permalinks

Tip revision: 8efbdb57c11a6c632f69d7e142a632b6a853fa46 authored by JiaLiPassion on 11 February 2022, 04:31:54 UTC
fix(zone.js): patch global instead of Mocha object (#45047)

Tip revision: 8efbdb5

File	Mode	Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
aio
devtools
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	2.8 KB
.bazelrc	-rw-r--r--	6.7 KB
.bazelversion	-rw-r--r--	6 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	240 bytes
.gitignore	-rw-r--r--	797 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.npmrc	-rw-r--r--	21 bytes
.nvmrc	-rw-r--r--	8 bytes
.prettierrc	-rw-r--r--	157 bytes
.pullapprove.yml	-rw-r--r--	48.2 KB
.yarnrc	-rw-r--r--	130 bytes
BUILD.bazel	-rw-r--r--	2.0 KB
CHANGELOG.md	-rw-r--r--	994.7 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	15.9 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	4.7 KB
WORKSPACE	-rw-r--r--	3.2 KB
browser-providers.conf.js	-rw-r--r--	1.8 KB
gulpfile.js	-rw-r--r--	631 bytes
karma-js.conf.js	-rw-r--r--	6.0 KB
package.json	-rw-r--r--	9.4 KB
renovate.json	-rw-r--r--	2.7 KB
test-events.js	-rw-r--r--	259 bytes
tsconfig-tslint.json	-rw-r--r--	171 bytes
tslint.json	-rw-r--r--	5.4 KB
yarn.lock	-rw-r--r--	698.4 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(zone.js): patch global instead of Mocha object (#45047)

README.md