https://github.com/web-platform-tests/wpt
Revision 8f1ef70886a1443ccd9980448031c88a44c3faea authored by Ben Pastene on 13 April 2018, 17:03:33 UTC, committed by Chromium WPT Sync on 13 April 2018, 17:03:33 UTC
This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9.

Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887

Original change's description:
> Reland: Use PostTask to schedule cross-process postMessage forwarding.
>
> Changes from original attempt at https://crrev.com/c/999182:
> - fix flakiness in two additional ChromeOS login tests
> - fix CSP WPT tests to not depend on ordering between iframe's onload
>   and postMessage - see https://crbug.com/832319.
>
> Previously, we sent the IPC to forward a cross-process postMessage
> immediately.  This caused a behavioral difference from the
> same-process case where the postMessage is always scheduled.  Namely,
> in a scenario like this:
>
>   frame.postMessage(...);
>   doSomethingThatSendsIPCsToFrame(frame);
>
> the IPCs from JS following the postMessage would've been ordered
> incorrectly, causing |frame| to see their side effects after the
> postMessage dispatch in the cross-process case, whereas they would be
> seen before the postMessage dispatch in the same-process case.  One
> example of this is frame.focus(), and another is a frame element
> onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
> a postMessage dispatched from an inline script while the frame was
> still loading.
>
> To resolve these ordering concerns, this CL changes cross-process
> postMessage to do a PostTask on the sender side before sending the
> message to the browser process.  This improves the current state of
> the world, but does not yet achieve a perfect match for the IPC
> ordering in the same-process case - see discussion on the bug.
>
> Bug: 828529
> Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
> Reviewed-on: https://chromium-review.googlesource.com/999182
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#550284}
> Reviewed-on: https://chromium-review.googlesource.com/1011287
> Cr-Commit-Position: refs/heads/master@{#550621}

TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org

Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828529
Reviewed-on: https://chromium-review.googlesource.com/1012138
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550649}
1 parent 1e5a5fe
History
Tip revision: 8f1ef70886a1443ccd9980448031c88a44c3faea authored by Ben Pastene on 13 April 2018, 17:03:33 UTC
Revert "Reland: Use PostTask to schedule cross-process postMessage forwarding."
Tip revision: 8f1ef70
File Mode Size
resources
OWNERS -rw-r--r-- 18 bytes
README.md -rw-r--r-- 1.3 KB
cookieStore_delete_arguments.tentative.window.js -rw-r--r-- 6.3 KB
cookieStore_event_arguments.tenative.window.js -rw-r--r-- 2.5 KB
cookieStore_event_basic.tentative.window.js -rw-r--r-- 971 bytes
cookieStore_event_delete.tenative.window.js -rw-r--r-- 1.1 KB
cookieStore_event_overwrite.tentative.window.js -rw-r--r-- 1.0 KB
cookieStore_getAll_arguments.tentative.window.js -rw-r--r-- 4.6 KB
cookieStore_getAll_set_basic.tentative.window.js -rw-r--r-- 749 bytes
cookieStore_get_arguments.tentative.window.js -rw-r--r-- 2.9 KB
cookieStore_get_delete_basic.tentative.window.js -rw-r--r-- 675 bytes
cookieStore_get_set_basic.tentative.window.js -rw-r--r-- 698 bytes
cookieStore_has_arguments.tentative.window.js -rw-r--r-- 3.3 KB
cookieStore_has_basic.tentative.window.js -rw-r--r-- 898 bytes
cookieStore_in_detached_frame.tentative.html -rw-r--r-- 621 bytes
cookieStore_set_arguments.tentative.window.js -rw-r--r-- 8.0 KB
cookieStore_set_expires_option.tentative.window.js -rw-r--r-- 2.0 KB
cookieStore_special_names.tentative.html -rw-r--r-- 2.7 KB
cookieStore_special_names.tentative.https.html -rw-r--r-- 1.7 KB
delete_cookies.tentative.html -rw-r--r-- 363 bytes
delete_cookies.tentative.https.html -rw-r--r-- 371 bytes
document_cookie.tentative.html -rw-r--r-- 365 bytes
document_cookie.tentative.https.html -rw-r--r-- 373 bytes
document_getAll_multiple.tentative.html -rw-r--r-- 1.6 KB
get_set_get_all.tentative.html -rw-r--r-- 366 bytes
get_set_get_all.tentative.https.html -rw-r--r-- 374 bytes
http_cookie_and_set_cookie_headers.tentative.html -rw-r--r-- 403 bytes
http_cookie_and_set_cookie_headers.tentative.https.html -rw-r--r-- 411 bytes
idlharness.tentative.html -rw-r--r-- 1.6 KB
idlharness_serviceworker.js -rw-r--r-- 1.2 KB
idlharness_serviceworker.tentative.https.html -rw-r--r-- 640 bytes
no_name_and_no_value.tentative.html -rw-r--r-- 380 bytes
no_name_and_no_value.tentative.https.html -rw-r--r-- 388 bytes
no_name_equals_in_value.tentative.html -rw-r--r-- 384 bytes
no_name_equals_in_value.tentative.https.html -rw-r--r-- 392 bytes
no_name_multiple_values.tentative.html -rw-r--r-- 387 bytes
no_name_multiple_values.tentative.https.html -rw-r--r-- 395 bytes
ordering.tentative.https.html -rw-r--r-- 359 bytes
serviceworker_cookieStore_arguments.js -rw-r--r-- 443 bytes
serviceworker_cookieStore_arguments.tentative.https.html -rw-r--r-- 747 bytes
serviceworker_cookieStore_basic.js -rw-r--r-- 386 bytes
serviceworker_cookieStore_basic.tentative.https.html -rw-r--r-- 731 bytes

README.md

back to top