Skip to main content

Browse the archive

Revision 8f1ef70886a1443ccd9980448031c88a44c3faea authored by Ben Pastene on 13 April 2018, 17:03:33 UTC, committed by Chromium WPT Sync on 13 April 2018, 17:03:33 UTC 
Revert "Reland: Use PostTask to schedule cross-process postMessage forwarding."
 
This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9.

Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887

Original change's description:
> Reland: Use PostTask to schedule cross-process postMessage forwarding.
>
> Changes from original attempt at https://crrev.com/c/999182:
> - fix flakiness in two additional ChromeOS login tests
> - fix CSP WPT tests to not depend on ordering between iframe's onload
>   and postMessage - see https://crbug.com/832319.
>
> Previously, we sent the IPC to forward a cross-process postMessage
> immediately.  This caused a behavioral difference from the
> same-process case where the postMessage is always scheduled.  Namely,
> in a scenario like this:
>
>   frame.postMessage(...);
>   doSomethingThatSendsIPCsToFrame(frame);
>
> the IPCs from JS following the postMessage would've been ordered
> incorrectly, causing |frame| to see their side effects after the
> postMessage dispatch in the cross-process case, whereas they would be
> seen before the postMessage dispatch in the same-process case.  One
> example of this is frame.focus(), and another is a frame element
> onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
> a postMessage dispatched from an inline script while the frame was
> still loading.
>
> To resolve these ordering concerns, this CL changes cross-process
> postMessage to do a PostTask on the sender side before sending the
> message to the browser process.  This improves the current state of
> the world, but does not yet achieve a perfect match for the IPC
> ordering in the same-process case - see discussion on the bug.
>
> Bug: 828529
> Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
> Reviewed-on: https://chromium-review.googlesource.com/999182
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#550284}
> Reviewed-on: https://chromium-review.googlesource.com/1011287
> Cr-Commit-Position: refs/heads/master@{#550621}

TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org

Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828529
Reviewed-on: https://chromium-review.googlesource.com/1012138
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550649}
1 parent 1e5a5fe
Raw File
DOMMatrix-stringifier.html 
<!DOCTYPE html>
<title>Geometry Interfaces: DOMMatrix and DOMMatrixReadOnly stringifier</title>
<link rel="help" href="https://drafts.fxtf.org/geometry/#DOMMatrix">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
["DOMMatrix", "DOMMatrixReadOnly", "WebKitCSSMatrix"].forEach(constr => {
  const prefix = `${constr} stringifier:`;

  // Basic
  test(() => {
    const matrix = new self[constr]();
    assert_equals(String(matrix), "matrix(1, 0, 0, 1, 0, 0)");
  }, `${prefix} identity (2d)`);

  test(() => {
    const matrix = self[constr].fromMatrix({is2D: false});
    assert_equals(String(matrix), "matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1)");
  }, `${prefix} identity (3d)`);

  // Non-finites
  [NaN, Infinity, -Infinity].forEach(num => {
    test(() => {
      const matrix = new self[constr]([1, 0, 0, 1, 0, num]);
      assert_throws("InvalidStateError", () => String(matrix));
    }, `${prefix} ${num} (2d)`);

    test(() => {
      const matrix = new self[constr]([1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, num, 0, 1]);
      assert_throws("InvalidStateError", () => String(matrix));
    }, `${prefix} ${num} (3d)`);
  });

  // Precision
  [
    ['1/3', '0.3333333333333333'],
    ['1/300000', '0.0000033333333333333333'],
    ['1/300000000', '3.3333333333333334e-9'],
    ['100000 + (1/3)', '100000.33333333333'],
    ['Math.pow(2, 53) + 1', '9007199254740992'],
    ['Math.pow(2, 53) + 2', '9007199254740994'],
    ['Number.MAX_VALUE', '1.7976931348623157e+308'],
    ['Number.MIN_VALUE', '5e-324'],
  ].forEach(([input, expected]) => {
    const num = eval(input);
    test(() => {
      const matrix = new self[constr]([1, 0, 0, 1, 0, num]);
      assert_equals(String(matrix), `matrix(1, 0, 0, 1, 0, ${expected})`);
    }, `${prefix} ${input} (2d)`);

    test(() => {
      const matrix = new self[constr]([1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, num, 0, 1]);
    assert_equals(String(matrix), `matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, ${expected}, 0, 1)`);
    }, `${prefix} ${input} (3d)`);
  });

  // Should not invoke getters for m11 etc
  function defineThrowingGetters(matrix) {
    Object.defineProperty(matrix, 'a', {
      get: () => assert_unreached('getter for a')
    });
    Object.defineProperty(matrix, 'm11', {
      get: () => assert_unreached('getter for m11')
    });
  }

  test(() => {
    const matrix = new self[constr]();
    defineThrowingGetters(matrix);
    assert_equals(String(matrix), "matrix(1, 0, 0, 1, 0, 0)");
  }, `${prefix} throwing getters (2d)`);

  test(() => {
    const matrix = self[constr].fromMatrix({is2D: false});
    defineThrowingGetters(matrix);
    assert_equals(String(matrix), "matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1)");
  }, `${prefix} throwing getters (3d)`);
});
</script>
back to top