Revision 8f1ef70886a1443ccd9980448031c88a44c3faea authored by Ben Pastene on 13 April 2018, 17:03:33 UTC, committed by Chromium WPT Sync on 13 April 2018, 17:03:33 UTC
This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9.
Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887
Original change's description:
> Reland: Use PostTask to schedule cross-process postMessage forwarding.
>
> Changes from original attempt at https://crrev.com/c/999182:
> - fix flakiness in two additional ChromeOS login tests
> - fix CSP WPT tests to not depend on ordering between iframe's onload
> and postMessage - see https://crbug.com/832319.
>
> Previously, we sent the IPC to forward a cross-process postMessage
> immediately. This caused a behavioral difference from the
> same-process case where the postMessage is always scheduled. Namely,
> in a scenario like this:
>
> frame.postMessage(...);
> doSomethingThatSendsIPCsToFrame(frame);
>
> the IPCs from JS following the postMessage would've been ordered
> incorrectly, causing |frame| to see their side effects after the
> postMessage dispatch in the cross-process case, whereas they would be
> seen before the postMessage dispatch in the same-process case. One
> example of this is frame.focus(), and another is a frame element
> onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
> a postMessage dispatched from an inline script while the frame was
> still loading.
>
> To resolve these ordering concerns, this CL changes cross-process
> postMessage to do a PostTask on the sender side before sending the
> message to the browser process. This improves the current state of
> the world, but does not yet achieve a perfect match for the IPC
> ordering in the same-process case - see discussion on the bug.
>
> Bug: 828529
> Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
> Reviewed-on: https://chromium-review.googlesource.com/999182
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#550284}
> Reviewed-on: https://chromium-review.googlesource.com/1011287
> Cr-Commit-Position: refs/heads/master@{#550621}
TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org
Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828529
Reviewed-on: https://chromium-review.googlesource.com/1012138
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550649}
1 parent 1e5a5fe
historical.html
<!doctype html>
<title>Historical Geometry APIs</title>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<link rel=help href="https://drafts.fxtf.org/geometry/#changes">
<script>
// Removed members
[
// https://github.com/w3c/fxtf-drafts/commit/99e3212469026b2f2f50926a41912d110a1741b7
['DOMMatrixReadOnly', 'scaleNonUniform'],
['DOMMatrix', 'scaleNonUniformSelf'],
// https://github.com/w3c/fxtf-drafts/commit/86da3dc961d442f9d8dc7ab59065a9804e109286
['DOMMatrix', 'multiplyBy'],
['DOMMatrix', 'preMultiplyBy'],
['DOMMatrix', 'translateBy'],
['DOMMatrix', 'scaleBy'],
['DOMMatrix', 'scale3dBy'],
['DOMMatrix', 'scaleNonUniformBy'],
['DOMMatrix', 'rotateBy'],
['DOMMatrix', 'rotateFromVectorBy'],
['DOMMatrix', 'rotateAxisAngleBy'],
['DOMMatrix', 'skewXBy'],
['DOMMatrix', 'skewYBy'],
].forEach(([interf, member]) => {
test(() => {
assert_true(interf in self, `${interf} should exist`);
assert_false(member in self[interf].prototype, 'on prototype');
const instance = new self[interf]();
assert_false(member in instance, 'on instance');
}, `${interf} ${member} must be nuked`);
});
// Removed static methods
// https://github.com/w3c/fxtf-drafts/commit/3c43462bcc857bb830f8af04532cdf33c5a634aa
['DOMMatrix', 'DOMMatrixReadOnly'].forEach(interf => {
test(() => {
assert_true(interf in self, `${interf} should exist`);
assert_false('fromString' in self[interf], 'on interface object');
}, `${interf} fromString static member must be nuked`);
});
// Optional arguments
[
// https://github.com/w3c/fxtf-drafts/commit/99e3212469026b2f2f50926a41912d110a1741b7
['DOMMatrixReadOnly', 'scale'],
['DOMMatrix', 'scaleSelf'],
// https://github.com/w3c/fxtf-drafts/commit/8493a9c3d94da91ead5db6e05b51319494f5855f
['DOMMatrixReadOnly', 'translate'],
['DOMMatrixReadOnly', 'scale3d'],
['DOMMatrixReadOnly', 'rotateFromVector'],
['DOMMatrixReadOnly', 'rotateAxisAngle'],
['DOMMatrixReadOnly', 'skewX'],
['DOMMatrixReadOnly', 'skewY'],
['DOMMatrix', 'translateSelf'],
['DOMMatrix', 'scale3dSelf'],
['DOMMatrix', 'rotateFromVectorSelf'],
['DOMMatrix', 'rotateAxisAngleSelf'],
['DOMMatrix', 'skewXSelf'],
['DOMMatrix', 'skewYSelf'],
// https://github.com/w3c/fxtf-drafts/commit/62b9cb9d5be4982d2a9cbf314e3a59efb8a68dd6
['DOMPointReadOnly', 'matrixTransform'],
['DOMMatrixReadOnly', 'multiply'],
['DOMMatrix', 'multiplySelf'],
['DOMMatrix', 'preMultiplySelf'],
].forEach(([interf, member]) => {
test(() => {
assert_equals(self[interf].prototype[member].length, 0, 'on prototype');
const instance = new self[interf]();
assert_equals(instance[member].length, 0, 'on instance');
}, `${interf} ${member} number of required arguments`);
});
// Renamed interfaces
[
// https://github.com/w3c/fxtf-drafts/commit/9031c94c8536cec7f7007c18d7be037a793e5ed5
'CSSMatrix',
// https://github.com/w3c/csswg-drafts/commit/8d01810fe403bc935c24ee5a29101cac9b958c8c
'DOMMatrixImmutable',
// https://github.com/w3c/csswg-drafts/commit/6e05c3ee01528daba6dc0776f342beae577cefa9
'ClientRect',
'ClientRectList',
// Non-standard
'WebKitPoint',
'MSCSSMatrix',
].forEach(interf => {
test(() => {
assert_false(interf in self);
}, `${interf} must be nuked`);
});
</script>
Computing file changes ...
