Skip to main content

Browse the archive

Revision 8f1ef70886a1443ccd9980448031c88a44c3faea authored by Ben Pastene on 13 April 2018, 17:03:33 UTC, committed by Chromium WPT Sync on 13 April 2018, 17:03:33 UTC 
Revert "Reland: Use PostTask to schedule cross-process postMessage forwarding."
 
This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9.

Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887

Original change's description:
> Reland: Use PostTask to schedule cross-process postMessage forwarding.
>
> Changes from original attempt at https://crrev.com/c/999182:
> - fix flakiness in two additional ChromeOS login tests
> - fix CSP WPT tests to not depend on ordering between iframe's onload
>   and postMessage - see https://crbug.com/832319.
>
> Previously, we sent the IPC to forward a cross-process postMessage
> immediately.  This caused a behavioral difference from the
> same-process case where the postMessage is always scheduled.  Namely,
> in a scenario like this:
>
>   frame.postMessage(...);
>   doSomethingThatSendsIPCsToFrame(frame);
>
> the IPCs from JS following the postMessage would've been ordered
> incorrectly, causing |frame| to see their side effects after the
> postMessage dispatch in the cross-process case, whereas they would be
> seen before the postMessage dispatch in the same-process case.  One
> example of this is frame.focus(), and another is a frame element
> onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
> a postMessage dispatched from an inline script while the frame was
> still loading.
>
> To resolve these ordering concerns, this CL changes cross-process
> postMessage to do a PostTask on the sender side before sending the
> message to the browser process.  This improves the current state of
> the world, but does not yet achieve a perfect match for the IPC
> ordering in the same-process case - see discussion on the bug.
>
> Bug: 828529
> Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
> Reviewed-on: https://chromium-review.googlesource.com/999182
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#550284}
> Reviewed-on: https://chromium-review.googlesource.com/1011287
> Cr-Commit-Position: refs/heads/master@{#550621}

TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org

Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828529
Reviewed-on: https://chromium-review.googlesource.com/1012138
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550649}
1 parent 1e5a5fe
Raw File
xml_xpath_runner.html 
<!doctype html>
<title>XPath tests</title>
<script src='/resources/testharness.js'></script>
<script src='/resources/testharnessreport.js'></script>
<script>
setup({ explicit_done: true });

function find_child_element(context, element) {
  for (var i = 0; i < context.childNodes.length; i++) {
    var child = context.childNodes[i];
    if (child.nodeType === Node.ELEMENT_NODE && child.tagName === element)
      return child;
  }
}

function xpath_test(test_el) {
  /* note this func adopts the tree! */
  var new_doc = document.implementation.createDocument("", "");
  var xpath = find_child_element(test_el, "xpath");
  var result = find_child_element(test_el, "result");
  var namespace = find_child_element(result, "namespace");
  var localname = find_child_element(result, "localname");
  var nth = find_child_element(result, "nth");
  var tree = find_child_element(test_el, "tree");
  var actual_tree = new_doc.adoptNode(tree.firstElementChild);
  new_doc.appendChild(actual_tree);
  test(function() {
    var result = new_doc.evaluate(xpath.textContent, // expression
                                  actual_tree, // context node
                                  new_doc.createNSResolver(actual_tree), // resolver
                                  XPathResult.ANY_TYPE, // type
                                  null); // result
    var matched = [];
    var cur;
    while ((cur = result.iterateNext()) !== null) {
      matched.push(cur);
    }
    assert_equals(matched.length, 1, "Should match one node");
    var similar = new_doc.getElementsByTagNameNS(namespace.textContent,
                                                 localname.textContent);
    assert_equals(matched[0], similar[nth.textContent]);
  });
}

var xhr = new XMLHttpRequest();
xhr.open("GET", "xml_xpath_tests.xml");
xhr.onload = function(e) {
  var tests = xhr.responseXML.documentElement;
  for (var i = 0; i < tests.childNodes.length; i++) {
    var child = tests.childNodes[i];
    if (child.nodeType === Node.ELEMENT_NODE) {
      xpath_test(child);
    }
  }
  done();
};
xhr.send();
</script>
back to top