Revision 8f1ef70886a1443ccd9980448031c88a44c3faea authored by Ben Pastene on 13 April 2018, 17:03:33 UTC, committed by Chromium WPT Sync on 13 April 2018, 17:03:33 UTC
This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9.
Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887
Original change's description:
> Reland: Use PostTask to schedule cross-process postMessage forwarding.
>
> Changes from original attempt at https://crrev.com/c/999182:
> - fix flakiness in two additional ChromeOS login tests
> - fix CSP WPT tests to not depend on ordering between iframe's onload
> and postMessage - see https://crbug.com/832319.
>
> Previously, we sent the IPC to forward a cross-process postMessage
> immediately. This caused a behavioral difference from the
> same-process case where the postMessage is always scheduled. Namely,
> in a scenario like this:
>
> frame.postMessage(...);
> doSomethingThatSendsIPCsToFrame(frame);
>
> the IPCs from JS following the postMessage would've been ordered
> incorrectly, causing |frame| to see their side effects after the
> postMessage dispatch in the cross-process case, whereas they would be
> seen before the postMessage dispatch in the same-process case. One
> example of this is frame.focus(), and another is a frame element
> onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
> a postMessage dispatched from an inline script while the frame was
> still loading.
>
> To resolve these ordering concerns, this CL changes cross-process
> postMessage to do a PostTask on the sender side before sending the
> message to the browser process. This improves the current state of
> the world, but does not yet achieve a perfect match for the IPC
> ordering in the same-process case - see discussion on the bug.
>
> Bug: 828529
> Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
> Reviewed-on: https://chromium-review.googlesource.com/999182
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#550284}
> Reviewed-on: https://chromium-review.googlesource.com/1011287
> Cr-Commit-Position: refs/heads/master@{#550621}
TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org
Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828529
Reviewed-on: https://chromium-review.googlesource.com/1012138
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550649}
1 parent 1e5a5fe
observe.html
<!doctype html>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="./resources/resizeTestHelper.js"></script>
<p>ResizeObserver tests</p>
<div id="target1" style="width:100px;height:100px;">t1</div>
<div id="target2" style="width:100px;height:100px;">t2</div>
<img id="target3" style="width:100px;height:100px;">
<iframe src="./resources/iframe.html" width="300px" height="100px" style="display:block"></iframe>
<script>
'use strict';
let t1 = document.querySelector('#target1');
let t2 = document.querySelector('#target2');
// allow uncaught exception because ResizeObserver posts exceptions
// to window error handler when limit is exceeded.
setup({allow_uncaught_exception: true});
function test0() {
let helper = new ResizeTestHelper(
"test0: simple observation",
[
{
setup: observer => {
observer.observe(t1);
t1.style.width = "5px";
},
notify: entries => {
assert_equals(entries.length, 1, "1 pending notification");
assert_equals(entries[0].target, t1, "target is t1");
assert_equals(entries[0].contentRect.width, 5, "target width");
}
}
]);
return helper.start();
}
function test1() {
let helper = new ResizeTestHelper(
"test1: multiple observation on same element trigger only one",
[
{
setup: observer => {
observer.observe(t1);
observer.observe(t1);
t1.style.width = "10px";
},
notify: entries => {
assert_equals(entries.length, 1, "1 pending notification");
}
}
]);
return helper.start();
}
function test2() {
test(() => {
assert_throws({name: "TypeError"}, _=> {
let ro = new ResizeObserver(() => {});
ro.observe({});
});
},
"test2: throw exception when observing non-element"
);
return Promise.resolve();
}
function test3() {
let helper = new ResizeTestHelper(
"test3: disconnect stops all notifications", [
{
setup: observer => {
observer.observe(t1);
observer.observe(t2);
observer.disconnect();
t1.style.width = "30px";
},
notify: entries => {
assert_unreached("no entries should be observed");
},
timeout: () => {
// expected
}
}
]);
return helper.start();
}
function test4() {
let helper = new ResizeTestHelper(
"test4: unobserve target stops notifications, unobserve non-observed does nothing", [
{
setup: observer => {
observer.observe(t1);
observer.observe(t2);
observer.unobserve(t1);
observer.unobserve(document.body);
t1.style.width = "40px";
t2.style.width = "40px";
},
notify: entries => {
assert_equals(entries.length, 1, "only t2");
assert_equals(entries[0].target, t2, "t2 was observed");
}
}
]);
return helper.start();
}
function test5() {
let t3 = document.querySelector('#target3');
var helper = new ResizeTestHelper("test5: observe img",[
{
setup: observer => {
observer.observe(t3);
},
notify: entries => {
}
},
{
setup: observer => {
t3.style.width = "100.5px";
},
notify: entries => {
assert_equals(entries.length, 1);
assert_equals(entries[0].contentRect.width, 100.5);
}
}
]);
return helper.start();
}
function test6() {
let resolvePromise;
let promise = new Promise((resolve) => {
resolvePromise = resolve;
});
let test = async_test('test6: iframe notifications');
let testRequested = false;
let iframe = document.querySelector('iframe');
window.addEventListener('message', event => {
switch(event.data) {
case 'readyToTest':
if (!testRequested) {
iframe.contentWindow.postMessage('startTest', '*');
testRequested = true;
}
break;
case 'success':
case 'fail':
window.requestAnimationFrame(() => {
test.step( () => {
assert_equals(event.data, 'success');
test.done();
resolvePromise();
});
});
break;
}
}, false);
return promise;
}
function test7() {
let harnessTest = async_test("test7: callback.this");
let resolvePromise;
let ro = new ResizeObserver( function(entries, obs) {
let callbackThis = this;
resolvePromise();
harnessTest.step(() => {
assert_equals(callbackThis, ro, "callback.this is ResizeObserver");
assert_equals(obs, ro, "2nd argument is ResizeObserver");
ro.disconnect();
// every reference to RO must be null before test completes
// to avoid triggering test leak-detection
ro = null;
callbackThis = null;
obs = null;
harnessTest.done();
});
}
);
ro.observe(t1);
return new Promise( (resolve, reject) => {
resolvePromise = resolve;
});
}
let guard;
test(_ => {
assert_own_property(window, "ResizeObserver");
guard = async_test('guard');
}, "ResizeObserver implemented")
test0()
.then(() => { return test1(); })
.then(() => { return test2(); })
.then(() => { return test3(); })
.then(() => { return test4(); })
.then(() => { return test5(); })
.then(() => { return test6(); })
.then(() => { return test7(); })
.then(() => { guard.done(); });
</script>
Computing file changes ...
