https://github.com/facebook/rocksdb
Revision 8f339ed6dec5a7c02388f1446ddceae39ad7ee1d authored by Anirban Rahut on 11 January 2017, 00:01:52 UTC, committed by Anirban Rahut on 11 January 2017, 19:43:29 UTC
Summary: There is some old code in PosixWritableFile::Close(), which
truncates the file to the measured size and then does an extra fallocate
with KEEP_SIZE. This is commented as a failsafe because in some
cases ftruncate doesn't do the right job (I don't know of an instance of
this btw). However doing an fallocate with KEEP_SIZE should not increase
the file size. However on Travis Worker which is Docker (likely AUFS )
its not working. There are comments on web that show that the AUFS
author had initially not implemented fallocate, and then did it later.
So not sure what is the quality of the implementation.

Test Plan: Testing on travis and internal sandcastle

Reviewers: IslamAbdelRahman
1 parent 2172b66
History
Tip revision: 8f339ed6dec5a7c02388f1446ddceae39ad7ee1d authored by Anirban Rahut on 11 January 2017, 00:01:52 UTC
Guarding extra fallocate call with TRAVIS because its not working properly on travis
Tip revision: 8f339ed
File Mode Size
arcanist_util
build_tools
cmake
coverage
db
docs
examples
hdfs
include
java
memtable
port
table
third-party
tools
util
utilities
.arcconfig -rw-r--r-- 566 bytes
.clang-format -rw-r--r-- 138 bytes
.gitignore -rw-r--r-- 700 bytes
.travis.yml -rw-r--r-- 1.7 KB
AUTHORS -rw-r--r-- 247 bytes
CMakeLists.txt -rw-r--r-- 23.7 KB
CONTRIBUTING.md -rw-r--r-- 733 bytes
DEFAULT_OPTIONS_HISTORY.md -rw-r--r-- 1.1 KB
DUMP_FORMAT.md -rw-r--r-- 763 bytes
HISTORY.md -rw-r--r-- 39.2 KB
INSTALL.md -rw-r--r-- 3.9 KB
LANGUAGE-BINDINGS.md -rw-r--r-- 646 bytes
LICENSE -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 50.3 KB
PATENTS -rw-r--r-- 1.9 KB
README.md -rw-r--r-- 1.4 KB
ROCKSDB_LITE.md -rw-r--r-- 1.0 KB
USERS.md -rw-r--r-- 4.6 KB
Vagrantfile -rw-r--r-- 877 bytes
WINDOWS_PORT.md -rw-r--r-- 12.5 KB
appveyor.yml -rw-r--r-- 555 bytes
src.mk -rw-r--r-- 24.1 KB
thirdparty.inc -rw-r--r-- 7.8 KB

README.md

back to top