8fae7df | dario-piotrowicz | 24 November 2021, 20:48:43 UTC | fix(docs-infra): add safari-only media query for aio footer flex (#44266) safari handles rem based media queries differently so in order to provide a similar user-experience to safari users, add a new safari-only media query for the footer's flex container resolves #44242 PR Close #44266 | 29 November 2021, 17:37:44 UTC |
1284d00 | JoostK | 24 November 2021, 21:01:26 UTC | refactor(platform-browser-dynamic): remove private export of `ResourceLoaderImpl` (#44267) This type was exported for the ViewEngine compiler as it needed to reference the class in its DI codegen. This is no longer a requirement with Ivy, hence the private export can be removed. This change prevents an import of `@angular/compiler` to be referenced in the .d.ts file of `@angular/platform-browser-dynamic`, which is beneficial for application compilations as that prevents the `@angular/compiler` .d.ts files from being included in the `ts.Program` of an application. Closes #44157. PR Close #44267 | 29 November 2021, 17:37:00 UTC |
47f1c0f | Pete Bacon Darwin | 25 November 2021, 09:23:26 UTC | fix(docs-infra): ensure deprecated styling is not overridden (#44275) The `.code-anchor` styling was overriding the `.deprecated-api-item` styling. The `text-decoration` is not needed on `.code-anchor` since it inherits this from the `a` rule in the typography.scss file. Fixes #44264 PR Close #44275 | 29 November 2021, 17:36:23 UTC |
594bd12 | Kristiyan Kostadinov | 25 November 2021, 11:05:42 UTC | test(core): clean up tests relying on entryComponents (#44276) Cleans up all the tests that had to declare a separate module in order to pass in `entryComponents` when creating components dynamically. This covers almost all of the `entryComponents` usages, except for a few which I've left for now, because they're testing some of the existing leftover `entryComponents` logic in core. PR Close #44276 | 29 November 2021, 17:36:04 UTC |
2c954bb | Christian-E | 28 November 2021, 20:57:41 UTC | docs: fix filename of the file containing the 'routes'-array in lazy loading guide (#44297) PR Close #44297 | 29 November 2021, 17:35:44 UTC |
b31973c | Andrew Kushnir | 09 November 2021, 02:20:56 UTC | test: remove Ivy/ViewEngine switch helpers and obsolete tests (#44120) This commit removes special functions that were used to run tests in ViewEngine or Ivy only. Since ViewEngine is deprecated and we no longer run ViewEngine tests on CI, we can cleanup those special helpers and ViewEngine-only tests. PR Close #44120 | 24 November 2021, 19:42:39 UTC |
d8e6577 | JoostK | 30 October 2021, 21:25:49 UTC | refactor(ngcc): remove Ivy switch marker transform (#43891) ngcc used to rewrite `PRE_R3` markers to become `POST_R3` in order to switch the runtime implementation in `@angular/core` from View Engine to Ivy. Now that `@angular/core` is published as native Ivy package and the runtime switch code has been removed, there is no need for ngcc to perform this transform anymore. PR Close #43891 | 24 November 2021, 19:26:25 UTC |
b2ac81d | JoostK | 19 October 2021, 17:03:48 UTC | refactor(compiler-cli): remove Ivy switch transform (#43891) Now that the core package has been cleaned up to no longer contain Ivy switch code, the transform to switch the `PRE_R3` markers to become `POST_R3` is deleted as well. PR Close #43891 | 24 November 2021, 19:26:25 UTC |
b06e398 | Rohan Pednekar | 05 November 2021, 13:48:14 UTC | fix(core): add missing info about a component in the "pipe could not be found" error message (#44081) Add error handling for pipe with component class name in which it has a problem. Add it in ngDevMode, so that it will be a tree-shake away from the production bundle. PR Close #44081 | 24 November 2021, 18:57:11 UTC |
83bbbd3 | Doug Parker | 10 November 2021, 23:50:55 UTC | docs: document `ng update` support guarantees (#44142) PR Close #44142 | 24 November 2021, 18:56:32 UTC |
adaff41 | Pei Wang | 18 November 2021, 02:19:19 UTC | ci: Upgrade tsec to 0.2.0. (#44205) tools/tsec.bzl is now part of tsec. Remove from Angular repo and update BUILD.bazel files. PR Close #44205 | 24 November 2021, 18:55:58 UTC |
0ad0054 | Joey Perrott | 18 November 2021, 18:25:37 UTC | build: update repository to node@16 locally (#44211) As node 16 is now active LTS, updating to node 16 is a better choice for our own development. Notably its support for M1 chips is an important value add for us. PR Close #44211 | 24 November 2021, 18:55:33 UTC |
29c8fee | Joey Perrott | 18 November 2021, 22:47:29 UTC | test(common): change fallback default URL in MockPlatformLocation (#44211) In node@16 the URL constructor fails for for a malformed URL such as http://<empty>/. Instead http://_empty_ is used as this conveys the same information in tests but is correctly formed. PR Close #44211 | 24 November 2021, 18:55:33 UTC |
7b0e9b0 | dario-piotrowicz | 18 November 2021, 22:59:01 UTC | docs(animations): remove incorrect information regarding animateChild (#44216) Remove incorrect information present in the angular.io animations documentation stating that animateChild does not work with route transition animations as that turned out not to be true This PR effectively reverts the changes make in PR: #44014 For more context see issue #30477 PR Close #44216 | 24 November 2021, 18:54:22 UTC |
6ae3858 | dario-piotrowicz | 10 November 2021, 21:38:52 UTC | docs(core): improve viewEncapsulation documentation (#44151) Slighlty improve the `viewEncapsulation` documentation (both in code comments and content files) to make it more clear and understandable. See https://github.com/angular/angular/pull/44099#discussion_r745890903 PR Close #44151 | 24 November 2021, 18:53:45 UTC |
2bf131a | dario-piotrowicz | 19 November 2021, 22:26:57 UTC | fix(docs-infra): move aio footer inside mat-sidenav-container (#44236) currently the aio footer sits outside the mat-sidenav-container, as a result when the mat-sidenav in over mode appears, the footer is not placed under the sidenav backdrop, move the footer inside the mat-sidenav-container so that it does PR Close #44236 | 24 November 2021, 17:04:01 UTC |
3697acc | George Kalpakas | 23 November 2021, 08:48:32 UTC | build(docs-infra): upgrade cli command docs sources to 481eb4544 (#44250) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/b8e198ba5...481eb4544): **Modified** - help/new.json PR Close #44250 | 24 November 2021, 17:03:38 UTC |
4527931 | Artur | 24 November 2021, 13:26:39 UTC | docs: fix issue link in v13 release notes (#44258) See: #44181 PR Close #44258 | 24 November 2021, 17:02:57 UTC |
414d5fe | Jessica Janiuk | 24 November 2021, 00:38:00 UTC | ci: add jessicajaniuk to pullapprove groups (#44255) This adds jessicajaniuk to fw-animations and fw-testing. PR Close #44255 | 24 November 2021, 17:02:30 UTC |
8c71b9f | Alex Rickabaugh | 09 November 2021, 19:02:39 UTC | refactor: delete the View Engine runtime (#43884) This commit removes the View Engine runtime. Itself, this change is relatively straightforward, but it represents the final step in a multi-year journey. It's only possible due to the hard work of many current and former team members and collaborators, who are too numerous to list here. Co-authored-by: Alan Agius <alan.agius4@gmail.com> Co-authored-by: Andrew Kushnir <akushnir@google.com> Co-authored-by: Andrew Scott <atscott01@gmail.com> Co-authored-by: Andrew Seguin <andrewjs@google.com> Co-authored-by: Cédric Exbrayat <cedric@ninja-squad.com> Co-authored-by: Charles Lyding <19598772+clydin@users.noreply.github.com> Co-authored-by: Dave Shevitz <dshevitz@google.com> Co-authored-by: Doug Parker <dgp1130@users.noreply.github.com> Co-authored-by: Dylan Hunn <dylhunn@gmail.com> Co-authored-by: Emma Twersky <emmatwersky@google.com> Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> Co-authored-by: Igor Minar <iminar@google.com> Co-authored-by: Jeremy Elbourn <jelbourn@google.com> Co-authored-by: Jessica Janiuk <jessicajaniuk@google.com> Co-authored-by: JiaLiPassion <JiaLi.Passion@gmail.com> Co-authored-by: Joey Perrott <josephperrott@gmail.com> Co-authored-by: Joost Koehoorn <joost.koehoorn@gmail.com> Co-authored-by: Kristiyan Kostadinov <crisbeto@abv.bg> Co-authored-by: Madleina Scheidegger <mscheid@google.com> Co-authored-by: Mark Thompson <2554588+MarkTechson@users.noreply.github.com> Co-authored-by: Minko Gechev <mgechev@gmail.com> Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com> Co-authored-by: Pawel Kozlowski <pkozlowski.opensource@gmail.com> Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> Co-authored-by: Wagner Maciel <wagnermaciel@google.com> Co-authored-by: Zach Arend <zachzach@google.com> PR Close #43884 | 23 November 2021, 21:10:06 UTC |
aadfad7 | Alex Rickabaugh | 02 November 2021, 21:39:52 UTC | build: remove view engine build infrastructure (#43884) This commit removes --config=viewengine and makes Ivy the default for building Angular. PR Close #43884 | 23 November 2021, 21:10:06 UTC |
bb9ff60 | Alex Rickabaugh | 09 November 2021, 18:59:21 UTC | test: remove view-engine-only tests (#43884) This commit removes most tests that were designated as only covering View Engine code. It also removes tag filters from CI and local commands to run tests. In a few cases (such as with the packages/compiler tests), this tag was improperly applied, and certain test cases have been added back running in Ivy mode. This commit also empties `@angular/compiler/testing` as it is no longer necessary (this is safe since compiler packages are not public API). It can be deleted in the future. PR Close #43884 | 23 November 2021, 21:10:06 UTC |
f44cb57 | unknown | 20 November 2021, 23:13:53 UTC | fix(router): prevent componentless routes from being detached (#44240) Currently, when deactivating a route, the detach method of the RouteReuseStrategy is always called even when we are dealing with a componentless route. If when using a custom strategy we attempt to detach a componentless route, an exception is thrown causing the navigation to break. This change prevents this from happening, by not triggering the detach of the route reuse strategy. Fixes #44239 PR Close #44240 | 23 November 2021, 17:12:27 UTC |
2772eea | Ramesh Thiruchelvam | 18 November 2021, 17:21:09 UTC | refactor(core): clean up isDevMode for tree-shaking (#44210) Removing the usage of isDevMode with ngDevMode flag. This will make the dev-mode code tree-shakable from the production builds. PR Close #44210 | 23 November 2021, 17:11:59 UTC |
40eb2f5 | Renovate Bot | 19 November 2021, 11:32:21 UTC | build: update dependency source-map-support to v0.5.21 (#44225) PR Close #44225 | 23 November 2021, 17:10:59 UTC |
a0177c6 | Renovate Bot | 21 November 2021, 00:25:38 UTC | build: update angular (#44241) PR Close #44241 | 23 November 2021, 17:10:24 UTC |
782b893 | Renovate Bot | 22 November 2021, 17:50:48 UTC | build: update dependency @angular-eslint/eslint-plugin-template to v13 (#44224) PR Close #44224 | 22 November 2021, 20:18:00 UTC |
24b6353 | Pete Bacon Darwin | 19 November 2021, 13:17:24 UTC | fix(ngcc): ensure that ngcc does not write a lock-file into node_modules package directories (#44228) When executing, ngcc writes a lock-file that is used to coordinate multiple concurrent instances of ngcc. Previously, this file was written at `node_modules/@angular/compiler-cli/ngcc`, or similar depending upon the bundling of the package. But this causes problems for setups where `node_modules` package directories are expected to be read-only. Now, the lock-file is written as `.ngcc_lock_file` into the top of the `node_modules`, which is an acceptable place to store transient files. This change should help to unblock use of tools like pnpm and lerna, which can use symlinks to readonly package directories. PR Close #44228 | 22 November 2021, 17:55:13 UTC |
f7dd0f8 | George Kalpakas | 19 November 2021, 20:36:02 UTC | build(docs-infra): update examples lockfile (#44232) In #44214, the `package.json` used to install dependencies for docs examples was updated, but the corresponding lockfile was not. Update the lockfile to keep it in sync with `package.json`. PR Close #44232 | 22 November 2021, 17:40:27 UTC |
34c3ec6 | Renovate Bot | 19 November 2021, 18:53:47 UTC | build: update dependency @angular-eslint/eslint-plugin to v13 (#44223) PR Close #44223 | 22 November 2021, 17:36:00 UTC |
6214636 | David Shevitz | 05 November 2021, 22:59:54 UTC | docs: add two new overview pages: developer-guide-overview and understanding-angular-overview (#44091) PR Close #44091 | 20 November 2021, 00:12:10 UTC |
c55ce75 | Doug Parker | 01 October 2021, 23:43:23 UTC | refactor(bazel): always add `strictTemplates` option to `tsconfig.json` (#43674) `strictTemplates` was only conditionally added to the `tsconfig.json` file to avoid breaking the angular/components repo (see https://github.com/angular/angular/pull/43582#issuecomment-928567758). Components has been updated in https://github.com/angular/components/pull/23677, so this condition is no longer necessary and `strictTemplates` can always be included in `tsconfig.json` without breakage. PR Close #43674 | 19 November 2021, 22:28:03 UTC |
53c99bb | Douglas Parker | 15 November 2021, 19:43:24 UTC | docs: add dynamic `import()` ES module change to v13 release notes (#44181) Closes angular/angular-cli#22159. See: https://github.com/angular/angular-cli/issues/22159#issuecomment-969251924 PR Close #44181 | 19 November 2021, 22:27:40 UTC |
489cf42 | Paul Gschwendtner | 22 June 2020, 08:09:47 UTC | fix(common): incorrect error type for XHR errors in `TestRequest` (#36082) Currently the `HttpClient` always wraps errors from XHR requests, but the underlying errors are always of type `ProgressEvent`, or don't have a native error if the status code is just indicating failure (e.g. 404). This behavior does not match in the `TestRequest` class provided by `@angular/common/http/testing` where errors are considered being of type `ErrorEvent`. This is incorrect because `ErrorEvent`s provide information for errors in scripts or files which are evaluated. Since the `HttpClient` never evaluates scripts/files, and also since XHR requests clearly are documented to emit `ProgressEvent`'s, we should change the `TestSupport` to retrieve such `ProgressEvent`'s instead of incompatible objects of type `ErrorEvent`. In favor of having a deprecation period, we keep supporting `ErrorEvent` in the `TestRequest.error` signature. Eventually, we can remove this signature in the future. Resources: * https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/error_event * https://developer.mozilla.org/en-US/docs/Web/API/ErrorEvent * https://xhr.spec.whatwg.org/#event-xhr-errpr Related to: https://github.com/angular/angular/issues/34748. DEPRECATED: `TestRequest` from `@angular/common/http/testing` no longer accepts `ErrorEvent` when simulating XHR errors. Instead instances of `ProgressEvent` should be passed, matching with the native browser behavior. PR Close #36082 | 19 November 2021, 21:26:52 UTC |
53bdbc6 | Renovate Bot | 19 November 2021, 09:01:29 UTC | build: update angular (#44221) PR Close #44221 | 19 November 2021, 19:44:55 UTC |
d8ae34a | dario-piotrowicz | 09 November 2021, 23:52:22 UTC | fix(docs-infra): remove negative margin (#44126) remove the top padding for the homepage article, instead of having that top padding and moving the element up via a negative bottom margin in the intro section note: the result is identical except for when the article's media query is applied, the difference is barely noticeable anyways PR Close #44126 | 19 November 2021, 19:32:29 UTC |
9255d0b | dario-piotrowicz | 09 November 2021, 22:34:34 UTC | fix(docs-infra): fix aio homepage breaking on certain widths (#44126) the aio homepage has a fixed width for its hero content, that is not handling well certain window widths, fix that by removing the fixed width and tweaking related media queries PR Close #44126 | 19 November 2021, 19:32:29 UTC |
48ca7dc | Kristiyan Kostadinov | 14 November 2021, 08:35:42 UTC | fix(compiler-cli): interpret string concat calls (#44167) These changes add support for interpreting `String.prototype.concat` calls. We need to support it, because in TypeScript 4.5 string template expressions are transpiled to `concat` calls, rather than string concatenations. See https://github.com/microsoft/TypeScript/pull/45304. PR Close #44167 | 19 November 2021, 19:30:59 UTC |
2e6b07a | Kristiyan Kostadinov | 18 November 2021, 08:38:13 UTC | refactor(core): clean up leftover isDevMode usages (#44208) Removes a couple of leftover calls to `isDevMode`. PR Close #44208 | 19 November 2021, 19:30:20 UTC |
b930547 | JoostK | 18 November 2021, 22:44:06 UTC | fix(core): support cyclic metadata in TestBed overrides (#44215) The TestBed APIs to override metadata would crash when the metadata contained objects with cyclic references. Metadata overrides use the JSON serialized representation of a value to compare objects, which throws an error if the value has cyclic references. This commit avoids the error by replacing multiple occurrences of the same object using a unique string representation for the object. Fixes #43948 PR Close #44215 | 19 November 2021, 19:27:08 UTC |
894aaea | George Kalpakas | 18 November 2021, 20:05:21 UTC | refactor(elements): remove unneeded Custom Elements polyfill from docs examples (#44214) In PR #43975, the `Angular Elements` guide was updated to remove mentions of the Custom Elements-related polyfills, since they are no longer necessary in v13+ (due to all CLI projects being ES2015+ and all supported browsers natively supporting Custom Elements). This commit updates the related docs example boilerplate to not include the unneeded `@webcomponents/custom-elements` polyfill. PR Close #44214 | 19 November 2021, 18:46:16 UTC |
e397a4c | George Kalpakas | 18 November 2021, 19:57:54 UTC | docs(docs-infra): remove obsolete mention of skipping HTTPS-related audits (#44214) Since commit 6e405513942f675c6c64ff4cb4a62e0df649e26a, the `audit-web-app` script no longer needs to skip HTTPS-related audits. Update the docs comment to reflect that. PR Close #44214 | 19 November 2021, 18:46:16 UTC |
7e121e4 | Renovate Bot | 19 November 2021, 09:06:18 UTC | build: update dependency @angular-eslint/builder to v13 (#44222) PR Close #44222 | 19 November 2021, 18:43:59 UTC |
f4c1501 | Renovate Bot | 19 November 2021, 10:11:37 UTC | build: update dependency @angular-eslint/template-parser to v13 (#44226) PR Close #44226 | 19 November 2021, 18:43:11 UTC |
76833aa | George Kalpakas | 18 November 2021, 18:42:58 UTC | build(docs-infra): upgrade cli command docs sources to b8e198ba5 (#44212) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/afd86f0cd...b8e198ba5): **Modified** - help/new.json PR Close #44212 | 18 November 2021, 21:30:26 UTC |
155742e | dario-piotrowicz | 06 November 2021, 17:54:32 UTC | refactor(animations): improve some animations comments (#44203) Fix various typos and also improve sentences (by making them more clear or grammatically correct) present in comments inside the animations package PR Close #44203 | 18 November 2021, 21:12:54 UTC |
213105c | Dylan Hunn | 17 November 2021, 23:29:23 UTC | ci: add dylhunn to review groups for forms. (#44204) This is needed so I can review forms PRs that affect public API. PR Close #44204 | 18 November 2021, 18:24:28 UTC |
88c6564 | Ravi Chandra | 17 November 2021, 19:35:21 UTC | docs: remove tslint references from file structure document (guide/file-structure) (#44202) remove tslint references from the file structure documentation as angular cli no more generates tslint configuration files by default Fixes #44163 PR Close #44202 | 18 November 2021, 18:21:31 UTC |
8330520 | Renovate Bot | 16 November 2021, 09:30:55 UTC | build: update dependency lighthouse to v9 (#44184) PR Close #44184 | 18 November 2021, 18:20:38 UTC |
9c40f6c | Paul Gschwendtner | 18 November 2021, 13:55:50 UTC | build: update extract js module output target to reflect latest API changes (#44145) The API of the `extract_js_module_output` rule has changed with the latest build of the shared dev-infra package. This commit adds the missing attributes to the targets using this rule, avoiding the CI failures as these attributes are mandatory. Note: For NPM packages the linker mappings are not relevant, neither do we want to include sources from the external NPM packages inside those. PR Close #44145 | 18 November 2021, 18:17:14 UTC |
6d8a889 | Renovate Bot | 18 November 2021, 01:52:52 UTC | build: update angular (#44145) PR Close #44145 | 18 November 2021, 18:17:14 UTC |
38c02e1 | Andrew Kushnir | 15 November 2021, 22:17:39 UTC | fix(forms): make the `FormControlStatus` available as a public API (#44183) This commit makes the `FormControlStatus` symbol available as a public API. The symbol itself was intended to become a part of the public API, but due to the missing re-export, the symbol remains private. Fixes #44176. PR Close #44183 | 17 November 2021, 18:37:28 UTC |
65597d6 | Andrew Kushnir | 26 October 2021, 04:15:41 UTC | refactor(forms): inherit `ngOnChanges` hooks from the base class (#43945) This commit updates the code of the min/max and minlength/maxlength validator directives to inherit `ngOnChanges` hooks from the base class (the `AbstractValidatorDirective` one), rather than implementing the hooks on the child classes. This was needed to avoid issues with hooks inheritance in ViewEngine, but since it's deprecated, the code can be cleaned up. PR Close #43945 | 17 November 2021, 18:36:40 UTC |
6474c3d | Alan Agius | 17 November 2021, 13:03:20 UTC | ci: remove `cla/google` from required statues (#44197) The CLA tools no longer report statuses as it is being run as Github actions. PR Close #44197 | 17 November 2021, 18:35:10 UTC |
6a2d8e2 | Marc Redemske | 16 November 2021, 20:54:58 UTC | docs: remove redudant word in goldens/README.md (#44192) PR Close #44192 | 17 November 2021, 18:34:08 UTC |
e0c7360 | Pete Bacon Darwin | 09 November 2021, 09:19:33 UTC | build(docs-infra): ensure overloaded functions render correctly (#44090) If there were 1 or 2 additional overloads on a free-standing function in the API the overloads were not being shown. Also the type of overload parameters were not being escaped correctly. PR Close #44090 | 17 November 2021, 18:33:10 UTC |
dbc46d6 | Andrew Kushnir | 05 November 2021, 22:27:14 UTC | docs: deprecate factory-based signature of the `downgradeModule` function (#44090) DEPRECATED: The `downgradeModule` function calls with NgModule factories are deprecated. Please use NgModule class based `downgradeModule` calls instead. PR Close #44090 | 17 November 2021, 18:33:10 UTC |
80a90f0 | profanis | 11 November 2021, 10:24:53 UTC | docs: add profanis to GDE resources (#44147) PR Close #44147 | 17 November 2021, 18:32:25 UTC |
90a4ae1 | Andrew Kushnir | 17 November 2021, 17:48:22 UTC | release: cut the v13.1.0-next.2 release (#44201) | 17 November 2021, 17:48:22 UTC |
b558d4e | Andrew Kushnir | 17 November 2021, 17:45:42 UTC | docs: release notes for the v13.0.2 release (#44200) | 17 November 2021, 17:45:42 UTC |
6c618de | fusho-takahashi | 24 September 2021, 22:14:53 UTC | docs: Adding type annotation to ngOnInit() to make it consistent with the class structure produced by the CLI (#43579) PR Close #43579 | 16 November 2021, 22:09:51 UTC |
130f06e | Armen Vardanyan | 21 October 2021, 09:22:30 UTC | docs: add armen vardanyan to GDE resources (#43919) PR Close #43919 | 16 November 2021, 22:09:01 UTC |
8ce9a60 | Joey Perrott | 16 November 2021, 20:59:59 UTC | build: update to latest commit for feature-request github action (#44191) Updating as this fixes a permissions error. PR Close #44191 | 16 November 2021, 22:08:24 UTC |
aa4d7d2 | Andrew Kushnir | 16 November 2021, 20:37:31 UTC | ci: update pullapprove.yml (#44193) This commit updates the PullApprove config, since Zach is currently focused on improving Components. PR Close #44193 | 16 November 2021, 22:07:19 UTC |
5a24f96 | Paul Gschwendtner | 16 November 2021, 15:23:53 UTC | refactor(elements): remove non-existent schematic collection breaking with `ng add` (#44187) Removes a non-existent schematic collection wired up for `@angular/elements` that has been removed with: https://github.com/angular/angular/commit/619b7cc3857b34598a0036f8ebf9bc2eb27f5507. Fixes #44160. PR Close #44187 | 16 November 2021, 20:03:41 UTC |
9303654 | Dylan Hunn | 16 November 2021, 18:10:13 UTC | ci: add dylhunn to review groups for size, piblic api, minimum, and circular (#44190) This is needed so I can review forms PRs that affect public API. PR Close #44190 | 16 November 2021, 20:02:14 UTC |
00ae55c | dario-piotrowicz | 14 November 2021, 10:38:28 UTC | docs(animations): improve wording for animation example (#44168) improve the wording of the text explaining an animation code snippet as that can be misinterpreted resolves #43952 PR Close #44168 | 16 November 2021, 17:45:14 UTC |
6d2276e | Ramesh Thiruchelvam | 14 November 2021, 14:40:56 UTC | test: type spy objects in test example (#44170) Example for test doesn't use typing for Jasmine Spy objects. Updated them with `SpyObj<T>` typing as in the Angular Documentation. See https://angular.io/guide/testing-services PR Close #44170 | 16 November 2021, 17:38:43 UTC |
aac579d | Martin von Gagern | 08 November 2021, 09:23:15 UTC | refactor(router): add type annotation for UrlSegment.parameterMap (#44175) Having the type specified explicitly makes the API reference more readable. PR Close #44175 | 16 November 2021, 17:36:17 UTC |
b7fd9eb | Joey Perrott | 15 November 2021, 18:59:23 UTC | ci: remove `cla: yes` from required labels (#44179) Remove `cla: yes` from the require labels for merging as the CLACheck tool no longer relies on labels. Enforcement of the CLA being signed is still enforced by the status check which is visible both in Github as well as checked by merge tooling. PR Close #44179 | 15 November 2021, 19:21:56 UTC |
265e9e3 | Pete Bacon Darwin | 12 November 2021, 14:15:08 UTC | build: add instructions for getting Angular version for bug report (#44159) The template asked for the Angular version but did not say how to get it. Closes #44158 PR Close #44159 | 15 November 2021, 19:21:05 UTC |
4489043 | Joey Perrott | 11 November 2021, 18:04:31 UTC | build: update to yarn v1.22.17 (#44150) Update to the latest version of yarn, 1.22.17. PR Close #44150 | 15 November 2021, 19:19:05 UTC |
f817e30 | Andrew Scott | 10 November 2021, 23:53:08 UTC | release: cut the v13.1.0-next.1 release (#44141) | 10 November 2021, 23:53:08 UTC |
f3d512c | Andrew Scott | 10 November 2021, 23:49:11 UTC | docs: release notes for the v13.0.1 release (#44140) | 10 November 2021, 23:49:11 UTC |
7a48c15 | Joey Perrott | 10 November 2021, 22:53:31 UTC | build: update to latest @angular/dev-infra-private to address issues related to verifying environment (#44137) Update to the latest package which properly checks if the running version of ng-dev is the version described in yarn lock. PR Close #44137 | 10 November 2021, 23:38:34 UTC |
1632605 | Andrew Kushnir | 10 November 2021, 21:51:25 UTC | refactor(core): format recently updated file to comply the lint rules (#44136) This commit updates a file that was changed recently, but that change triggered the `lint` CI job to fail, since the lint rules were slightly changed. PR Close #44136 | 10 November 2021, 23:36:56 UTC |
0bd01ca | dario-piotrowicz | 06 November 2021, 16:57:20 UTC | refactor(core): move outdated comment to view.ts (#44099) remove the comment suggesting to use a const enum for ViewEncapsulation in the renderer3/definitions.ts file and add a similar comment in the view.ts file in which the enum is defined Note: the new comment does not contain the suggestion of changing `None` to `0` as it is unclear what benefits that would bring (for more info see: https://github.com/angular/angular/pull/44099#discussion_r744157686) PR Close #44099 | 10 November 2021, 20:42:19 UTC |
4809bbd | Renovate Bot | 10 November 2021, 18:23:55 UTC | build: update angular (#44074) PR Close #44074 | 10 November 2021, 20:41:38 UTC |
790dfe5 | ileil | 01 November 2021, 17:50:01 UTC | docs: update review tag to topic (#44008) PR Close #44008 | 10 November 2021, 19:29:13 UTC |
393efa5 | Pete Bacon Darwin | 03 November 2021, 19:42:02 UTC | fix(compiler): ensure that partially compiled queries can handle forward references (#44113) When a partially compiled component or directive is "linked" in JIT mode, the body of its declaration is evaluated by the JavaScript runtime. If a class is referenced in a query (e.g. `ViewQuery` or `ContentQuery`) but its definition is later in the file, then the reference must be wrapped in a `forwardRef()` call. Previously, query predicates were not wrapped correctly in partial declarations causing the code to crash at runtime. In AOT mode, this code is never evaluated but instead transformed as part of the build, so this bug did not become apparent until Angular Material started running JIT mode tests on its distributable output. This change fixes this problem by noting when queries are wrapped in `forwardRef()` calls and ensuring that this gets passed through to partial compilation declarations and then suitably stripped during linking. See https://github.com/angular/components/pull/23882 and https://github.com/angular/components/issues/23907 PR Close #44113 | 10 November 2021, 18:25:16 UTC |
67fbec3 | Pete Bacon Darwin | 08 November 2021, 21:22:32 UTC | refactor(compiler): rename R3ProviderExpression and associated helpers (#44113) This interface will be used in other situations so this change renames it to be more general as `MaybeForwardRefExpression`. PR Close #44113 | 10 November 2021, 18:25:16 UTC |
89aa94b | Renovate Bot | 09 November 2021, 22:43:33 UTC | build: lock file maintenance (#44111) PR Close #44111 | 10 November 2021, 18:22:57 UTC |
18cc7c8 | Pete Bacon Darwin | 09 November 2021, 10:01:56 UTC | test(compiler): remove IE11 match in JIT compiler tests (#44122) Since we no longer support (nor test on) IE11 we can remove these matches for `anonymous` functions. PR Close #44122 | 10 November 2021, 17:37:24 UTC |
ac7d5fa | Pavan Kumar Jadda | 10 November 2021, 04:49:46 UTC | docs: updates typescript configuration file links (#44131) The links for `tsconfig.json` target and module sections no longer valid. This commit updates the document with correct links PR Close #44131 | 10 November 2021, 17:37:02 UTC |
7ac2a8c | Pei Wang | 21 October 2021, 22:22:39 UTC | ci: Windows support for tsec_test. (#43924) Contents of generated tsconfig for tsec_test now depend on whether Bazel uses symlinked runfiles for nodejs_test. The current implementation assumes that symlinked runfiles are not available on Windows. PR Close #43924 | 10 November 2021, 04:36:48 UTC |
236bdff | raman | 04 November 2021, 08:42:55 UTC | fix(platform-browser): use correct parent in animation removeChild callback (#44033) Animation's `onRemovalComplete` callback is using incorrect `parentNode`. Should be parentNode provided by `delegate.parentNode(element)` instead of direct `element.parentNode`. This is not a problem with default renderer but can cause problems with custom renderer if it uses another logic to add/remove nodes. Fixes #44023 PR Close #44033 | 10 November 2021, 01:21:56 UTC |
670cd10 | Andrew Scott | 04 November 2021, 17:44:21 UTC | refactor(language-service): Move language service code out of ivy/ folder (#44064) This commit moves code in the language service package out of the ivy subfolder. Ivy is the _only_ engine supported in v13+ so there's no need to have a name for it. PR Close #44064 | 10 November 2021, 01:20:04 UTC |
4738569 | Andrew Scott | 04 November 2021, 17:28:32 UTC | refactor(language-service): Remove View Engine code from language service package (#44064) This commit removes ViewEngine-specific code from the langauge service package. This code is no longer used since VE is not supported in v13+. PR Close #44064 | 10 November 2021, 01:20:04 UTC |
891318e | Renovate Bot | 08 November 2021, 18:58:30 UTC | build: update all non-major dependencies (#43974) PR Close #43974 | 09 November 2021, 21:00:17 UTC |
247c18d | Kristiyan Kostadinov | 08 November 2021, 12:45:34 UTC | fix(compiler-cli): handle pre-release versions when checking version (#44109) Currently the TS version checking function interprets a version like `1.2.3-rc.5` as `1.2.NaN` which would allow it to bypass the version checking altogether. These changes add a little bit more logic to ensure that such versions are handled correctly. There's also an error if we don't manage to parse the version string. Also it seemed like we never actually ran the version check unit tests, because they didn't have a test target. PR Close #44109 | 09 November 2021, 20:54:45 UTC |
93b314d | kreuzerk | 06 November 2021, 18:05:53 UTC | docs: including additional assets into libraries (#44076) PR Close #44076 | 09 November 2021, 20:54:21 UTC |
28ef5af | Pete Bacon Darwin | 30 October 2021, 20:33:08 UTC | refactor(ngcc): improve logging of progress (#43996) This commit adds additional information to encourage developers to contact the author of View Engine libraries and ask them to update to partial Ivy. Fixes #42308 PR Close #43996 | 09 November 2021, 18:10:18 UTC |
74345f3 | George Kalpakas | 08 November 2021, 13:54:17 UTC | build(docs-infra): remove unnecessary work-around for SW config generation (#44114) Since angular.io is now updated to a version that includes the fix from #43679, the work-around added in 841c5aebbfc7f40fdf838cc3e73395cf8b94bdf9 can now be removed. PR Close #44114 | 09 November 2021, 18:08:20 UTC |
26fc12e | Paul Gschwendtner | 04 November 2021, 19:05:29 UTC | ci: instruct renovate to apply patch label to avoid divergence with other version branches (#44065) Renovate currently always applies the minor label. This often causes the patch/FF/RC branches to quickly diverge. We should always apply the patch label with the goal of keeping infra-related changes in sync as much as possible.. Then it is still possible to selectively apply the minor/major label if needed (this forces the reviewer to actually think about where this should go in, if it fails!). PR Close #44065 | 09 November 2021, 18:08:00 UTC |
c3b5838 | dario-piotrowicz | 31 October 2021, 11:18:54 UTC | fix(docs-infra): prevent automatic linking of 'number' (#44000) add 'number' to the ignoreGenericWords set so that it doesn't get wrongly linked to the decimalPipe during the aio docs generation as it is a generic typescript term PR Close #44000 | 09 November 2021, 18:03:39 UTC |
0ae4187 | dario-piotrowicz | 13 October 2021, 21:13:44 UTC | refactor(docs-infra): remove eslint directive comments from examples (#43831) Linting has recently been removed from the examples provided in angular.io (see PRs #43592 and #43746) such removal effects the downloadable and stackblitz examples but linting is still generally used in the examples in the aio project itself (they are being migrated from tslint to eslint in PR #43218) thus eslint directive comments are still necessary in the code itself. So the comments need to be present but need not to be exposed to the users (not in the zips, stackblitzes nor docs themselves), these changes are removing such comments during the examples' parsing phase (effectively removing them from all three sources mentioned above). Original discussion: https://github.com/angular/angular/pull/43218#discussion_r697305494 resolves #43788 PR Close #43831 | 09 November 2021, 18:02:33 UTC |
4f8eaac | JoostK | 25 September 2021, 10:50:41 UTC | fix(core): do not use Function constructors in development mode to avoid CSP violations (#43587) This commit removes the dynamic creation of named arrays for internal runtime storage arrays as they may cause CSP violations in development mode, when an application's CSP configuration does not include `unsafe-eval`. Named arrays for view data can still be enabled in development mode using the `ngDevMode=namedConstructors` query parameter when loading the application. The usage of native class syntax for named arrays does not have the desired effect when the code is downleveled to ES5. Since ES5 targets are becoming increasingly more rare this is considered less of a problem than the CSP violation. Fixes #43494 PR Close #43587 | 09 November 2021, 18:02:13 UTC |
50ed778 | profanis | 12 December 2020, 18:15:00 UTC | docs(animations): express the seconds in numbers (#40098) I've noticed that the seconds are expressed both by using numbers and words. For example, the doc says `0.5 second` and not `half second`. I believe is more readable to express them by using numbers and is consistent too. PR Close #40098 | 09 November 2021, 18:01:46 UTC |
2a27447 | JoostK | 30 July 2020, 21:08:27 UTC | fix(compiler-cli): ensure literal types are retained when `strictNullInputTypes` is disabled (#38305) Consider the `NgModel` directive which has the `ngModelOptions` input: ```ts class NgModel { @Input() ngModelOptions: { updateOn: 'blur'|'change'|'submit' }; } ``` In a template this may be set using an object literal as follows: ```html <input ngModel [ngModelOptions]="{updateOn: 'blur'}"> ``` This assignment should be accepted, as the object's type aligns with the `ngModelOptions` input in `NgModel`. However, if the `strictNullInputTypes` option is disabled this assignment would inadvertently produce an error: ``` Type '{ updateOn: string; }' is not assignable to type '{ updateOn: "blur"|"change"|"submit"; }'. Types of property 'updateOn' are incompatible. Type 'string' is not assignable to type '"blur"|"change"|"submit"' ``` This is due to the `'blur'` value being inferred to be of type `string` instead of retaining its literal type. The non-null assertion operator that is automatically inserted for input binding assignments when `strictNullInputTypes` is disabled inhibits TypeScript from inferring the string value as its literal type. This commit fixes the issue by omitting the insertion of the non-null operator for object literals and array literals. PR Close #38305 | 09 November 2021, 18:01:24 UTC |
491dd3d | Joey Perrott | 08 November 2021, 20:23:45 UTC | refactor(compiler-cli): use relative imports within the @angular/compiler-cli package (#44118) Intrapackage imports should always be done via relative imports rather than using the external import location. PR Close #44118 | 08 November 2021, 22:08:27 UTC |